Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C5367C3526D for ; Wed, 26 Jan 2022 15:46:06 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id C22DD838AD; Wed, 26 Jan 2022 16:43:15 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1643211796; bh=j4a6qdHaGmB704Sz9Nc2Y08ylA3qcHNsq8+b8O7/VOw=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=tFN+m4V9OWCzx/lIXjxu5J//RGtzcNtO4FnJlaBFicgNsnO0k+kMU9Q6uTjWOl2ku mUOf5iNL3JiRpj7UgB6VYMoiby7PGycTm7mWbac2laO7gx8cxwYnwk27tV2ffPH/Td lJ99RkBIa6uumkLBQQ+kLDv0QHjBayeWKg6rP1Zdak4I6Ct16czv2BbTCbWQ2DBiah 6z6BfDrOo+Xz/sGeIpj57nl0KqZP07G8IDsjU0VDRmms0LpMTYxFYBzAl9W46Xi1QU GsRGhXGKZw5j6eRATUnrfKwwtIf6/g+5/q/LDY+QSogmCjKkd2KfuP0xnC3UEc90zb rWknlK09o8CEg== Received: by phobos.denx.de (Postfix, from userid 109) id 7C1D183841; Wed, 26 Jan 2022 16:42:24 +0100 (CET) Received: from mout-u-107.mailbox.org (mout-u-107.mailbox.org [91.198.250.252]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 83DF483A78 for ; Wed, 26 Jan 2022 16:42:21 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=sr@denx.de Received: from smtp102.mailbox.org (smtp102.mailbox.org [IPv6:2001:67c:2050:105:465:1:3:0]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-u-107.mailbox.org (Postfix) with ESMTPS id 4JkSdn1RWvz9spR; Wed, 26 Jan 2022 16:42:21 +0100 (CET) Message-ID: Date: Wed, 26 Jan 2022 16:42:17 +0100 MIME-Version: 1.0 Subject: Re: [PATCH u-boot-marvell 13/14] tools: kwboot: Fix usage of -D without -t Content-Language: en-US To: =?UTF-8?Q?Marek_Beh=c3=ban?= Cc: u-boot@lists.denx.de, pali@kernel.org, =?UTF-8?Q?Marek_Beh=c3=ban?= References: <20220125171313.14498-1-kabel@kernel.org> <20220125171313.14498-14-kabel@kernel.org> From: Stefan Roese In-Reply-To: <20220125171313.14498-14-kabel@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On 1/25/22 18:13, Marek Behún wrote: > From: Pali Rohár > > When -D is specified then both bootmsg and debugmsg are not set, but > imgpath is set. Fix this check for valid and required parameters. > > Signed-off-by: Pali Rohár > Signed-off-by: Marek Behún Reviewed-by: Stefan Roese Thanks, Stefan > --- > tools/kwboot.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/kwboot.c b/tools/kwboot.c > index fca1c73c55..859559fb72 100644 > --- a/tools/kwboot.c > +++ b/tools/kwboot.c > @@ -1819,7 +1819,7 @@ main(int argc, char **argv) > } > } while (1); > > - if (!bootmsg && !term && !debugmsg) > + if (!bootmsg && !term && !debugmsg && !imgpath) > goto usage; > > ttypath = argv[optind++]; Viele Grüße, Stefan Roese -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de