From: "flichtenheld (Code Review)" Date: Thu, 7 Aug 2025 15:07:51 +0000 References: Reply-To: frank@...2641..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="xOE4UhdgvnQ="; charset=UTF-8 Subject: [Openvpn-devel] [XS] Change in openvpn[master]: t_client.sh: Do not wait 3 seconds for OpenVPN to come up List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos Cc: openvpn-devel --xOE4UhdgvnQ= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1139?usp=3Demail to review the following change. Change subject: t_client.sh: Do not wait 3 seconds for OpenVPN to come up ...................................................................... t_client.sh: Do not wait 3 seconds for OpenVPN to come up On most machines 1 second should be quite enough. Given that we run currently 23 tests on most t_client runs, this makes over 40 seconds difference. Not nothing. Change-Id: Ice8c7ff4d8118a9e6465a4724207a355138360b8 Signed-off-by: Frank Lichtenheld --- M tests/t_client.sh.in 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/39/1139/1 diff --git a/tests/t_client.sh.in b/tests/t_client.sh.in index 7a271b6..1309ba1 100755 --- a/tests/t_client.sh.in +++ b/tests/t_client.sh.in @@ -383,7 +383,7 @@ ovpn_init_success=3D0 while [ $ovpn_init_check -gt 0 ]; do - sleep 3 # Wait for OpenVPN to initialize and have had time to writ= e the pid file + sleep 1 # Wait for OpenVPN to initialize and have had time to writ= e the pid file grep "Initialization Sequence Completed" $LOGDIR/$SUF:openvpn.log >= /dev/null if [ $? -eq 0 ]; then ovpn_init_check=3D0 -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1139?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ice8c7ff4d8118a9e6465a4724207a355138360b8 Gerrit-Change-Number: 1139 Gerrit-PatchSet: 1 Gerrit-Owner: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-MessageType: newchange --xOE4UhdgvnQ= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: plaisthos.

flichtenheld would like plaisthos to review this change.

V= iew Change

t_client.sh: Do not wait 3 seconds for OpenVPN to come up
On most machines 1 second should be quite enough. Given
that we run= currently 23 tests on most t_client runs, this
makes over 40 seconds di= fference. Not nothing.

Change-Id: Ice8c7ff4d8118a9e6465a4724207a3551= 38360b8
Signed-off-by: Frank Lichtenheld <frank@...2641...>
---=
M tests/t_client.sh.in
1 file changed, 1 insertion(+), 1 deletion(-)=

git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/39/=
1139/1
diff --git a/tests/t_client.sh.in b/tests/t_client.sh.in
index 7a271b6..1309ba1 100755
--- a/tests/t_cl= ient.sh.in
+++ b/tests/t_client.sh.in
@@ -3= 83,7 +383,7 @@
ovpn_init_success=3D0
= while [ $ovpn_init_check -gt 0 ];
do
- sleep 3 # Wait for OpenVPN = to initialize and have had time to write the pid file

+ sleep 1 # Wait for OpenVPN to ini= tialize and have had time to write the pid file
gre= p "Initialization Sequence Completed" $LOGDIR/$SUF:openvpn.log &g= t;/dev/null
if [ $? -eq 0 ]; then
= ovpn_init_check=3D0

To view,= visit c= hange 1139. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ice8c7ff4d8118a9e6465a472420= 7a355138360b8
Gerrit-Change-Number: 1139
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-MessageType: newchange
--xOE4UhdgvnQ=--