Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1FA1BC433EF for ; Tue, 11 Jan 2022 12:10:52 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 1123081E25; Tue, 11 Jan 2022 13:10:50 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=walle.cc Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=walle.cc header.i=@walle.cc header.b="vkXAY5J3"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 12E2A8002A; Tue, 11 Jan 2022 13:10:48 +0100 (CET) Received: from ssl.serverraum.org (ssl.serverraum.org [176.9.125.105]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 0C8B382C6D for ; Tue, 11 Jan 2022 13:10:45 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=walle.cc Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=michael@walle.cc Received: from ssl.serverraum.org (web.serverraum.org [172.16.0.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ssl.serverraum.org (Postfix) with ESMTPSA id 9220222236; Tue, 11 Jan 2022 13:10:43 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2016061301; t=1641903043; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aAqSLY2JSpafsEChAT77Lql4FUYSZ0zpP/8Cppf/GGA=; b=vkXAY5J3dFAlxI53BJ89IoX4HT2/Psfmm6w+RrRUC+4M/lGXUjMlifqBwR5mo9CYhZZzRE 1BIRCzjPBh7YBFfg3pp/O2WzX6UbCvDg+fY57AK/0JlJMrnWYv9121vBUrnwCEXNCD0paw 17i4oqDeKglk4bzEMqZdSQ+zVQcqovc= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 11 Jan 2022 13:10:41 +0100 From: Michael Walle To: Gaurav Jain Cc: u-boot@lists.denx.de, Stefano Babic , Fabio Estevam , Peng Fan , Simon Glass , Priyanka Jain , Ye Li , Horia Geanta , Ji Luo , Franck Lenormand , Silvano Di Ninno , Sahil malhotra , Pankaj Gupta , Varun Sethi , "NXP i . MX U-Boot Team" , Shengzhou Liu , Mingkai Hu , Rajesh Bhagat , Meenakshi Aggarwal , Wasim Khan , Alison Wang , Pramod Kumar , Tang Yuantian , Adrian Alonso , Vladimir Oltean Subject: Re: [PATCH v9 11/14] Layerscape: Enable Job ring driver model. In-Reply-To: <20220111112805.3566-12-gaurav.jain@nxp.com> References: <20220111112805.3566-1-gaurav.jain@nxp.com> <20220111112805.3566-12-gaurav.jain@nxp.com> User-Agent: Roundcube Webmail/1.4.12 Message-ID: X-Sender: michael@walle.cc X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Gaurav, Am 2022-01-11 12:28, schrieb Gaurav Jain: > @@ -1329,6 +1331,7 @@ config TARGET_LS2080ARDB > select FSL_DDR_BIST > select FSL_DDR_INTERACTIVE if !SPL > select GPIO_EXTRA_HEADER > + select FSL_CAAM See below. > diff --git a/arch/arm/cpu/armv8/fsl-layerscape/cpu.c > b/arch/arm/cpu/armv8/fsl-layerscape/cpu.c > index 2ded3e4efc..29aa9a3f10 100644 > --- a/arch/arm/cpu/armv8/fsl-layerscape/cpu.c > +++ b/arch/arm/cpu/armv8/fsl-layerscape/cpu.c > @@ -1,6 +1,6 @@ > // SPDX-License-Identifier: GPL-2.0+ > /* > - * Copyright 2017-2020 NXP > + * Copyright 2017-2021 NXP > * Copyright 2014-2015 Freescale Semiconductor, Inc. > */ > > @@ -49,6 +49,7 @@ > #endif > #endif > #include > +#include > > DECLARE_GLOBAL_DATA_PTR; > > @@ -1650,6 +1651,13 @@ __weak int serdes_misc_init(void) > > int arch_misc_init(void) > { > + struct udevice *dev; > + int ret; > + > + ret = uclass_get_device_by_driver(UCLASS_MISC, > DM_DRIVER_GET(caam_jr), &dev); > + if (ret) > + printf("Failed to initialize %s: %d\n", dev->name, ret); This will fail when the CAAM driver isn't enabled and will then print this error message. Should be guarded with IS_ENABLED(FSL_CAAM). > diff --git a/configs/ls2088ardb_tfa_defconfig > b/configs/ls2088ardb_tfa_defconfig > index a28b45b129..5230d7ead8 100644 > --- a/configs/ls2088ardb_tfa_defconfig > +++ b/configs/ls2088ardb_tfa_defconfig > @@ -53,7 +53,6 @@ CONFIG_ENV_ADDR=0x580500000 > CONFIG_NET_RANDOM_ETHADDR=y > CONFIG_DM=y > CONFIG_SATA_CEVA=y > -CONFIG_FSL_CAAM=y > CONFIG_DDR_CLK_FREQ=133333333 > CONFIG_DDR_ECC=y > CONFIG_ECC_INIT_VIA_DDRCONTROLLER=y .. I still don't understand why you make the FSL_CAAM mandatory and remove the option here. Same for all other boards. -michael