From: Simon Goldschmidt Date: Tue, 7 May 2019 21:36:15 +0200 Subject: [U-Boot] [PATCH] ARM: socfpga: Fix FPGA bitstream loading code In-Reply-To: <20190507191922.12551-1-marex@denx.de> References: <20190507191922.12551-1-marex@denx.de> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 07.05.19 21:19, Marek Vasut wrote: > According to SoCFPGA Cyclone V datasheet rev.2018.01.26 page 175 > (Chapter 5, FPGA Manager, data register) and Arria10 datasheet > rev.2017.07.22 page 211 (Chapter 5.4.1.2, FPGA Manager, img_data_w > register), the FPGA data register must be written with writes with > non-incrementing address. > > The current code increments the address in 32-byte bursts. Fix the > code so it does not increment the address and writes the register > repeatedly instead. > > Signed-off-by: Marek Vasut > Cc: Chin Liang See > Cc: Dinh Nguyen > Cc: Simon Goldschmidt > Cc: Tien Fong Chee > --- > drivers/fpga/socfpga.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/fpga/socfpga.c b/drivers/fpga/socfpga.c > index 685957626b..6ecea771ce 100644 > --- a/drivers/fpga/socfpga.c > +++ b/drivers/fpga/socfpga.c > @@ -55,8 +55,7 @@ void fpgamgr_program_write(const void *rbf_data, size_t rbf_size) > " cmp %2, #0\n" > " beq 2f\n" > "1: ldmia %0!, {r0-r7}\n" > - " stmia %1!, {r0-r7}\n" > - " sub %1, #32\n" > + " stmia %1, {r0-r7}\n" Iirc, stmia without the "!" still stores the registers to different addresses, it just does not change %1 any more if you leave away the "!"? So this would save on opcode, but not change anything? Regards, Simon > " subs %2, #1\n" > " bne 1b\n" > "2: cmp %3, #0\n" >