Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EC015C00A94 for ; Fri, 12 Apr 2024 12:15:47 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.704602.1101062 (Exim 4.92) (envelope-from ) id 1rvFoS-0002om-S0; Fri, 12 Apr 2024 12:15:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 704602.1101062; Fri, 12 Apr 2024 12:15:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rvFoS-0002of-PI; Fri, 12 Apr 2024 12:15:24 +0000 Received: by outflank-mailman (input) for mailman id 704602; Fri, 12 Apr 2024 12:15:24 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rvFoR-0002oY-WF for xen-devel@lists.xenproject.org; Fri, 12 Apr 2024 12:15:24 +0000 Received: from mail-ot1-x336.google.com (mail-ot1-x336.google.com [2607:f8b0:4864:20::336]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 55cab136-f8c6-11ee-b908-491648fe20b8; Fri, 12 Apr 2024 14:15:23 +0200 (CEST) Received: by mail-ot1-x336.google.com with SMTP id 46e09a7af769-6ea0fd9ca89so578805a34.3 for ; Fri, 12 Apr 2024 05:15:22 -0700 (PDT) Received: from [10.80.67.140] (default-46-102-197-194.interdsl.co.uk. [46.102.197.194]) by smtp.gmail.com with ESMTPSA id t12-20020a05620a004c00b0078d43da0be3sm2305590qkt.5.2024.04.12.05.15.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 12 Apr 2024 05:15:20 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 55cab136-f8c6-11ee-b908-491648fe20b8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=google; t=1712924121; x=1713528921; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=plbEXkQWlx5weAXa2T3dGeOsiQSYbb5/wBl5tIl0vUA=; b=QWMJWyGznXetgiajVJHFUYrQcoA0JHAsMhOb2y2mIszAy3EHRDESCRFdt1ap5k8QJt CCCHAQCZ+jdXqhzpvEgjUBUEj71/cathS7bMqs/+3qjy5k5vuzpJA/FbbbnJxfGd9V56 KT7fVL0tKWCgBcv1KKUwc4DlUc5/rzzX5hxz0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712924121; x=1713528921; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=plbEXkQWlx5weAXa2T3dGeOsiQSYbb5/wBl5tIl0vUA=; b=gu4LstF0rEHmo+V0UsP8k+CcwwgInepBuGcf+TzvZD4/KNc17Pjc8St6cVGYEw39lR Yhza/WecSg3j63C8LS6JV2eqArRrOabBXvSCaunR6UHjsfie66w1a4igk/TIt54ICI/I Gjlgu/EEGLjMHawd7s60QyTsWiv6decE+x674wa79BgvRFLK77T+AbyrmjnoaG7CDLA+ iTxZcLQzXKqyfluBN4maTVL+J5Yl9P/Hqa5fBkXYoXoHVI/UJKC5OxwpMIH4aAQUuRZW tcISYNiPQhcnHAR3SjD2qQy8YLtupv1ETncHeUYTupMZ67BluGuvd1ul7ZLFn99OKaTN XerQ== X-Forwarded-Encrypted: i=1; AJvYcCULlRlydyeNQYq5DtNzJRwtCfquWRkURuEClJhwO2U/sm9/nA/kwxVT4/hSCyPbeDNWfNbKgIuCIJpT22FCHesi/JyVg3CGf3rvLeX1tbQ= X-Gm-Message-State: AOJu0Yxua8Zbxc2c34FNcutfXBpL2dZU/x1TCqzfTg8KPPbeXp+HakNo sUNN+MNPLOuwitk6tXCZ50T/nKO4whj27LryL2CAqDk4m1+HxNTZAwjffqJXVpw= X-Google-Smtp-Source: AGHT+IE+LETmLKSi9+DXNSG+gZrGUWqxRiYHkUeAlJirq/C8wVDddMXxpNUz31BxO3lnJZbNMF6aFA== X-Received: by 2002:a05:6830:1d78:b0:6ea:f61:ec98 with SMTP id l24-20020a0568301d7800b006ea0f61ec98mr2660956oti.7.1712924121648; Fri, 12 Apr 2024 05:15:21 -0700 (PDT) Message-ID: Date: Fri, 12 Apr 2024 13:15:18 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/5] gzip: clean up comments and fix code alignment To: "Daniel P. Smith" , xen-devel@lists.xenproject.org Cc: Jason Andryuk , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini References: <20240411152518.2995-1-dpsmith@apertussolutions.com> <20240411152518.2995-3-dpsmith@apertussolutions.com> <382b8aaf-ea9f-42c7-b57b-945fa4fd36aa@citrix.com> Content-Language: en-GB From: Andrew Cooper Autocrypt: addr=andrew.cooper3@citrix.com; keydata= xsFNBFLhNn8BEADVhE+Hb8i0GV6mihnnr/uiQQdPF8kUoFzCOPXkf7jQ5sLYeJa0cQi6Penp VtiFYznTairnVsN5J+ujSTIb+OlMSJUWV4opS7WVNnxHbFTPYZVQ3erv7NKc2iVizCRZ2Kxn srM1oPXWRic8BIAdYOKOloF2300SL/bIpeD+x7h3w9B/qez7nOin5NzkxgFoaUeIal12pXSR Q354FKFoy6Vh96gc4VRqte3jw8mPuJQpfws+Pb+swvSf/i1q1+1I4jsRQQh2m6OTADHIqg2E ofTYAEh7R5HfPx0EXoEDMdRjOeKn8+vvkAwhviWXTHlG3R1QkbE5M/oywnZ83udJmi+lxjJ5 YhQ5IzomvJ16H0Bq+TLyVLO/VRksp1VR9HxCzItLNCS8PdpYYz5TC204ViycobYU65WMpzWe LFAGn8jSS25XIpqv0Y9k87dLbctKKA14Ifw2kq5OIVu2FuX+3i446JOa2vpCI9GcjCzi3oHV e00bzYiHMIl0FICrNJU0Kjho8pdo0m2uxkn6SYEpogAy9pnatUlO+erL4LqFUO7GXSdBRbw5 gNt25XTLdSFuZtMxkY3tq8MFss5QnjhehCVPEpE6y9ZjI4XB8ad1G4oBHVGK5LMsvg22PfMJ ISWFSHoF/B5+lHkCKWkFxZ0gZn33ju5n6/FOdEx4B8cMJt+cWwARAQABzSlBbmRyZXcgQ29v cGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPsLBegQTAQgAJAIbAwULCQgHAwUVCgkI CwUWAgMBAAIeAQIXgAUCWKD95wIZAQAKCRBlw/kGpdefoHbdD/9AIoR3k6fKl+RFiFpyAhvO 59ttDFI7nIAnlYngev2XUR3acFElJATHSDO0ju+hqWqAb8kVijXLops0gOfqt3VPZq9cuHlh IMDquatGLzAadfFx2eQYIYT+FYuMoPZy/aTUazmJIDVxP7L383grjIkn+7tAv+qeDfE+txL4 SAm1UHNvmdfgL2/lcmL3xRh7sub3nJilM93RWX1Pe5LBSDXO45uzCGEdst6uSlzYR/MEr+5Z JQQ32JV64zwvf/aKaagSQSQMYNX9JFgfZ3TKWC1KJQbX5ssoX/5hNLqxMcZV3TN7kU8I3kjK mPec9+1nECOjjJSO/h4P0sBZyIUGfguwzhEeGf4sMCuSEM4xjCnwiBwftR17sr0spYcOpqET ZGcAmyYcNjy6CYadNCnfR40vhhWuCfNCBzWnUW0lFoo12wb0YnzoOLjvfD6OL3JjIUJNOmJy RCsJ5IA/Iz33RhSVRmROu+TztwuThClw63g7+hoyewv7BemKyuU6FTVhjjW+XUWmS/FzknSi dAG+insr0746cTPpSkGl3KAXeWDGJzve7/SBBfyznWCMGaf8E2P1oOdIZRxHgWj0zNr1+ooF /PzgLPiCI4OMUttTlEKChgbUTQ+5o0P080JojqfXwbPAyumbaYcQNiH1/xYbJdOFSiBv9rpt TQTBLzDKXok86M7BTQRS4TZ/ARAAkgqudHsp+hd82UVkvgnlqZjzz2vyrYfz7bkPtXaGb9H4 Rfo7mQsEQavEBdWWjbga6eMnDqtu+FC+qeTGYebToxEyp2lKDSoAsvt8w82tIlP/EbmRbDVn 7bhjBlfRcFjVYw8uVDPptT0TV47vpoCVkTwcyb6OltJrvg/QzV9f07DJswuda1JH3/qvYu0p vjPnYvCq4NsqY2XSdAJ02HrdYPFtNyPEntu1n1KK+gJrstjtw7KsZ4ygXYrsm/oCBiVW/OgU g/XIlGErkrxe4vQvJyVwg6YH653YTX5hLLUEL1NS4TCo47RP+wi6y+TnuAL36UtK/uFyEuPy wwrDVcC4cIFhYSfsO0BumEI65yu7a8aHbGfq2lW251UcoU48Z27ZUUZd2Dr6O/n8poQHbaTd 6bJJSjzGGHZVbRP9UQ3lkmkmc0+XCHmj5WhwNNYjgbbmML7y0fsJT5RgvefAIFfHBg7fTY/i kBEimoUsTEQz+N4hbKwo1hULfVxDJStE4sbPhjbsPCrlXf6W9CxSyQ0qmZ2bXsLQYRj2xqd1 bpA+1o1j2N4/au1R/uSiUFjewJdT/LX1EklKDcQwpk06Af/N7VZtSfEJeRV04unbsKVXWZAk uAJyDDKN99ziC0Wz5kcPyVD1HNf8bgaqGDzrv3TfYjwqayRFcMf7xJaL9xXedMcAEQEAAcLB XwQYAQgACQUCUuE2fwIbDAAKCRBlw/kGpdefoG4XEACD1Qf/er8EA7g23HMxYWd3FXHThrVQ HgiGdk5Yh632vjOm9L4sd/GCEACVQKjsu98e8o3ysitFlznEns5EAAXEbITrgKWXDDUWGYxd pnjj2u+GkVdsOAGk0kxczX6s+VRBhpbBI2PWnOsRJgU2n10PZ3mZD4Xu9kU2IXYmuW+e5KCA vTArRUdCrAtIa1k01sPipPPw6dfxx2e5asy21YOytzxuWFfJTGnVxZZSCyLUO83sh6OZhJkk b9rxL9wPmpN/t2IPaEKoAc0FTQZS36wAMOXkBh24PQ9gaLJvfPKpNzGD8XWR5HHF0NLIJhgg 4ZlEXQ2fVp3XrtocHqhu4UZR4koCijgB8sB7Tb0GCpwK+C4UePdFLfhKyRdSXuvY3AHJd4CP 4JzW0Bzq/WXY3XMOzUTYApGQpnUpdOmuQSfpV9MQO+/jo7r6yPbxT7CwRS5dcQPzUiuHLK9i nvjREdh84qycnx0/6dDroYhp0DFv4udxuAvt1h4wGwTPRQZerSm4xaYegEFusyhbZrI0U9tJ B8WrhBLXDiYlyJT6zOV2yZFuW47VrLsjYnHwn27hmxTC/7tvG3euCklmkn9Sl9IAKFu29RSo d5bD8kMSCYsTqtTfT6W4A3qHGvIDta3ptLYpIAOD2sY3GYq2nf3Bbzx81wZK14JdDDHUX2Rs 6+ahAA== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 12/04/2024 12:28 pm, Daniel P. Smith wrote: > On 4/11/24 15:11, Andrew Cooper wrote: > >> Thoughts? > > I think it is all doable, the only question is would you prefer to see > the PKZIP_BUG_WORKAROUND and NOMEMCPY drop happen before relocating > the files or after relocation? I'd suggest dropping these two in a prep patch ahead of this main cleanup. ~Andrew