From: "Souza, Jose" Subject: Re: [PATCH 2/2] drm/i915/icl: Get DDI clock for ICL for MG PLL and TBT PLL Date: Tue, 14 Aug 2018 20:06:48 +0000 Message-ID: References: <20180727200457.16560-1-paulo.r.zanoni@intel.com> <20180727200457.16560-2-paulo.r.zanoni@intel.com> <817cd6bb1c3c4f86f92bd68e4fa6966f610435ad.camel@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id 95B0389268 for ; Tue, 14 Aug 2018 20:07:08 +0000 (UTC) In-Reply-To: <817cd6bb1c3c4f86f92bd68e4fa6966f610435ad.camel@intel.com> Content-Language: en-US Content-ID: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "intel-gfx@lists.freedesktop.org" , "Zanoni, Paulo R" List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCAyMDE4LTA4LTEzIGF0IDIyOjE5ICswMDAwLCBTb3V6YSwgSm9zZSB3cm90ZToNCj4g T24gRnJpLCAyMDE4LTA3LTI3IGF0IDEzOjA0IC0wNzAwLCBQYXVsbyBaYW5vbmkgd3JvdGU6DQo+ ID4gRnJvbTogTWFuYXNpIE5hdmFyZSA8bWFuYXNpLmQubmF2YXJlQGludGVsLmNvbT4NCj4gPiAN Cj4gPiBQTExzIGFyZSB0aGUgc291cmNlIGNsb2NrcyBmb3IgdGhlIERESXMgc28gaW4gb3JkZXIg dG8gZGV0ZXJtaW5lDQo+ID4gdGhlDQo+ID4gZGRpIGNsb2NrIHdlIG5lZWQgdG8gY2hlY2sgdGhl IFBMTCBjb25maWd1cmF0aW9uLg0KPiA+IA0KPiA+IEZvciBNRyBQSHkgUG9ydHMgKEMgLSBGKSwg ZGVwZW5kaW5nIG9uIHdoZXRoZXIgaXQgaXMgYSBUQlQgUExMIG9yDQo+ID4gTUcNCj4gPiBQTEwg dGhlIGxpbmsgbG9jayBjYW4gYmUgb2J0YWluZWQgZnJvbSB0aGUgdGhlIFBMTCBkaXZpc29ycyBi YXNlZA0KPiA+IG9uDQo+ID4gdGhlIHNwZWNpZmljYXRpb24uDQo+ID4gDQo+ID4gdjIgKGZyb20g UGF1bG8pOg0KPiA+ICAqIE1ha2UgdGhlIGFsZ29yaXRobSBsb29rIG1vcmUgbGlrZSB3aGF0J3Mg aW4gdGhlIHNwZWMsIGFsc28NCj4gPiBkb2N1bWVudA0KPiA+ICAgIHdoZXJlIHdlIGRpZmZlciBm b3JtIHRoZSBzcGVjIGFuZCB3aHkuDQo+ID4gICogTWFrZSB0aGUgY29kZSBhIGxpdHRsZSBtb3Jl IGNvbnNpc3RlbnQgd2l0aCBvdXIgY29kaW5nIHN0eWxlLg0KPiA+IA0KPiA+IENjOiBKYW1lcyBB dXNtdXMgPGphbWVzLmF1c211c0BpbnRlbC5jb20+DQo+ID4gU2lnbmVkLW9mZi1ieTogTWFuYXNp IE5hdmFyZSA8bWFuYXNpLmQubmF2YXJlQGludGVsLmNvbT4NCj4gPiBTaWduZWQtb2ZmLWJ5OiBQ YXVsbyBaYW5vbmkgPHBhdWxvLnIuemFub25pQGludGVsLmNvbT4NCj4gPiAtLS0NCj4gPiAgZHJp dmVycy9ncHUvZHJtL2k5MTUvaTkxNV9yZWcuaCAgfCAgNSArKw0KPiA+ICBkcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9kZGkuYyB8IDgxDQo+ID4gKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKy0NCj4gPiAgMiBmaWxlcyBjaGFuZ2VkLCA4NCBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9u cygtKQ0KPiA+IA0KPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3Jl Zy5oDQo+ID4gYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3JlZy5oDQo+ID4gaW5kZXggZTA0 YWM0N2Q1M2RiLi5jZDM3ZTc2ZDRkMTkgMTAwNjQ0DQo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJt L2k5MTUvaTkxNV9yZWcuaA0KPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVn LmgNCj4gPiBAQCAtOTQ1OCw2ICs5NDU4LDcgQEAgZW51bSBza2xfcG93ZXJfZ2F0ZSB7DQo+ID4g ICNkZWZpbmUgICBNR19DTEtUT1AyX0hTQ0xLQ1RMX0hTRElWX1JBVElPXzUJCSgyIDw8DQo+ID4g MTIpDQo+ID4gICNkZWZpbmUgICBNR19DTEtUT1AyX0hTQ0xLQ1RMX0hTRElWX1JBVElPXzcJCSgz IDw8DQo+ID4gMTIpDQo+ID4gICNkZWZpbmUgICBNR19DTEtUT1AyX0hTQ0xLQ1RMX0RTRElWX1JB VElPKHgpCQkoKHgpIDw8DQo+ID4gOCkNCj4gPiArI2RlZmluZSAgIE1HX0NMS1RPUDJfSFNDTEtD VExfRFNESVZfUkFUSU9fU0hJRlQJCTgNCj4gPiAgI2RlZmluZSAgIE1HX0NMS1RPUDJfSFNDTEtD VExfRFNESVZfUkFUSU9fTUFTSwkJKDB4ZiA8PA0KPiA+IDgpDQo+ID4gICNkZWZpbmUgTUdfQ0xL VE9QMl9IU0NMS0NUTChwb3J0KSBfTU1JT19QT1JUKChwb3J0KSAtIFBPUlRfQywgXA0KPiA+ICAJ CQkJCSAgICAgX01HX0NMS1RPUDJfSFNDTEtDVExfUE9SVDENCj4gPiAsIFwNCj4gPiBAQCAtOTQ2 OCw3ICs5NDY5LDEwIEBAIGVudW0gc2tsX3Bvd2VyX2dhdGUgew0KPiA+ICAjZGVmaW5lIF9NR19Q TExfRElWMF9QT1JUMwkJCQkweDE2QUEwMA0KPiA+ICAjZGVmaW5lIF9NR19QTExfRElWMF9QT1JU NAkJCQkweDE2QkEwMA0KPiA+ICAjZGVmaW5lICAgTUdfUExMX0RJVjBfRlJBQ05FTl9ICQkJCSgx IDw8DQo+ID4gMzApDQo+ID4gKyNkZWZpbmUgICBNR19QTExfRElWMF9GQkRJVl9GUkFDX01BU0sJ CQkoMHgzZmZmDQo+ID4gZmYgPDwgOCkNCj4gPiArI2RlZmluZSAgIE1HX1BMTF9ESVYwX0ZCRElW X0ZSQUNfU0hJRlQJCQk4DQo+ID4gICNkZWZpbmUgICBNR19QTExfRElWMF9GQkRJVl9GUkFDKHgp CQkJKCh4KSA8PA0KPiA+IDgpDQo+ID4gKyNkZWZpbmUgICBNR19QTExfRElWMF9GQkRJVl9JTlRf TUFTSwkJCSgweGZmDQo+ID4gPDwgMCkNCj4gPiAgI2RlZmluZSAgIE1HX1BMTF9ESVYwX0ZCRElW X0lOVCh4KQkJCSgoeCkgPDwgMCkNCj4gPiAgI2RlZmluZSBNR19QTExfRElWMChwb3J0KSBfTU1J T19QT1JUKChwb3J0KSAtIFBPUlRfQywNCj4gPiBfTUdfUExMX0RJVjBfUE9SVDEsIFwNCj4gPiAg CQkJCSAgICAgX01HX1BMTF9ESVYwX1BPUlQyKQ0KPiA+IEBAIC05NDgzLDYgKzk0ODcsNyBAQCBl bnVtIHNrbF9wb3dlcl9nYXRlIHsNCj4gPiAgI2RlZmluZSAgIE1HX1BMTF9ESVYxX0RJVEhFUl9E SVZfNAkJCSgyIDw8IDEyKQ0KPiA+ICAjZGVmaW5lICAgTUdfUExMX0RJVjFfRElUSEVSX0RJVl84 CQkJKDMgPDwgMTIpDQo+ID4gICNkZWZpbmUgICBNR19QTExfRElWMV9ORElWUkFUSU8oeCkJCQko KHgpIDw8IDQpDQo+ID4gKyNkZWZpbmUgICBNR19QTExfRElWMV9GQlBSRURJVl9NQVNLCQkJKDB4 ZiA8PA0KPiA+IDApDQo+ID4gICNkZWZpbmUgICBNR19QTExfRElWMV9GQlBSRURJVih4KQkJCSgo eCkgPDwgMCkNCj4gPiAgI2RlZmluZSBNR19QTExfRElWMShwb3J0KSBfTU1JT19QT1JUKChwb3J0 KSAtIFBPUlRfQywNCj4gPiBfTUdfUExMX0RJVjFfUE9SVDEsIFwNCj4gPiAgCQkJCSAgICAgX01H X1BMTF9ESVYxX1BPUlQyKQ0KPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9kZGkuYw0KPiA+IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGRpLmMNCj4gPiBp bmRleCAwYWRjMDQzNTI5ZjIuLmExOGQ1NzA0NmJjYyAxMDA2NDQNCj4gPiAtLS0gYS9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9kZGkuYw0KPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX2RkaS5jDQo+ID4gQEAgLTE0MjcsNiArMTQyNyw4MSBAQCBzdGF0aWMgaW50IGNubF9j YWxjX3dycGxsX2xpbmsoc3RydWN0DQo+ID4gZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsDQo+ ID4gIAlyZXR1cm4gZGNvX2ZyZXEgLyAocDAgKiBwMSAqIHAyICogNSk7DQo+ID4gIH0NCj4gPiAg DQo+ID4gK3N0YXRpYyBpbnQgaWNsX2NhbGNfdGJ0X3BsbF9saW5rKHN0cnVjdCBkcm1faTkxNV9w cml2YXRlDQo+ID4gKmRldl9wcml2LA0KPiA+ICsJCQkJIGVudW0gcG9ydCBwb3J0KQ0KPiA+ICt7 DQo+ID4gKwl1MzIgdmFsID0gSTkxNV9SRUFEKERESV9DTEtfU0VMKHBvcnQpKSAmIERESV9DTEtf U0VMX01BU0s7DQo+ID4gKw0KPiA+ICsJc3dpdGNoICh2YWwpIHsNCj4gPiArCWNhc2UgRERJX0NM S19TRUxfTk9ORToNCj4gPiArCQlyZXR1cm4gMDsNCj4gPiArCWNhc2UgRERJX0NMS19TRUxfVEJU XzE2MjoNCj4gPiArCQlyZXR1cm4gMTYyMDAwOw0KPiA+ICsJY2FzZSBERElfQ0xLX1NFTF9UQlRf MjcwOg0KPiA+ICsJCXJldHVybiAyNzAwMDA7DQo+ID4gKwljYXNlIERESV9DTEtfU0VMX1RCVF81 NDA6DQo+ID4gKwkJcmV0dXJuIDU0MDAwMDsNCj4gPiArCWNhc2UgRERJX0NMS19TRUxfVEJUXzgx MDoNCj4gPiArCQlyZXR1cm4gODEwMDAwOw0KPiA+ICsJZGVmYXVsdDoNCj4gPiArCQlNSVNTSU5H X0NBU0UodmFsKTsNCj4gPiArCQlyZXR1cm4gMDsNCj4gPiArCX0NCj4gPiArfQ0KPiA+ICsNCj4g PiArc3RhdGljIGludCBpY2xfY2FsY19tZ19wbGxfbGluayhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0 ZSAqZGV2X3ByaXYsDQo+ID4gKwkJCQllbnVtIHBvcnQgcG9ydCkNCj4gPiArew0KPiA+ICsJdTMy IG1nX3BsbF9kaXYwLCBtZ19jbGt0b3BfaHNjbGtjdGw7DQo+ID4gKwl1MzIgbTEsIG0yX2ludCwg bTJfZnJhYywgZGl2MSwgZGl2MiwgcmVmY2xrOw0KPiA+ICsJdTY0IHRtcDsNCj4gPiArDQo+ID4g KwlyZWZjbGsgPSBkZXZfcHJpdi0+Y2RjbGsuaHcucmVmOw0KPiA+ICsNCj4gPiArCW1nX3BsbF9k aXYwID0gSTkxNV9SRUFEKE1HX1BMTF9ESVYwKHBvcnQpKTsNCj4gPiArCW1nX2Nsa3RvcF9oc2Ns a2N0bCA9IEk5MTVfUkVBRChNR19DTEtUT1AyX0hTQ0xLQ1RMKHBvcnQpKTsNCj4gPiArDQo+ID4g KwltMSA9IEk5MTVfUkVBRChNR19QTExfRElWMShwb3J0KSkgJiBNR19QTExfRElWMV9GQlBSRURJ Vl9NQVNLOw0KPiA+ICsJbTJfaW50ID0gbWdfcGxsX2RpdjAgJiBNR19QTExfRElWMF9GQkRJVl9J TlRfTUFTSzsNCj4gPiArCW0yX2ZyYWMgPSAobWdfcGxsX2RpdjAgJiBNR19QTExfRElWMF9GUkFD TkVOX0gpID8NCj4gPiArCQkgIChtZ19wbGxfZGl2MCAmIE1HX1BMTF9ESVYwX0ZCRElWX0ZSQUNf TUFTSykgPj4NCj4gPiArCQkgIE1HX1BMTF9ESVYwX0ZCRElWX0ZSQUNfU0hJRlQgOiAwOw0KPiA+ ICsNCj4gPiArCXN3aXRjaCAobWdfY2xrdG9wX2hzY2xrY3RsICYNCj4gPiBNR19DTEtUT1AyX0hT Q0xLQ1RMX0hTRElWX1JBVElPX01BU0spIHsNCj4gPiArCWNhc2UgTUdfQ0xLVE9QMl9IU0NMS0NU TF9IU0RJVl9SQVRJT18yOg0KPiA+ICsJCWRpdjEgPSAyOw0KPiA+ICsJCWJyZWFrOw0KPiA+ICsJ Y2FzZSBNR19DTEtUT1AyX0hTQ0xLQ1RMX0hTRElWX1JBVElPXzM6DQo+ID4gKwkJZGl2MSA9IDM7 DQo+ID4gKwkJYnJlYWs7DQo+ID4gKwljYXNlIE1HX0NMS1RPUDJfSFNDTEtDVExfSFNESVZfUkFU SU9fNToNCj4gPiArCQlkaXYxID0gNTsNCj4gPiArCQlicmVhazsNCj4gPiArCWNhc2UgTUdfQ0xL VE9QMl9IU0NMS0NUTF9IU0RJVl9SQVRJT183Og0KPiA+ICsJCWRpdjEgPSA3Ow0KPiA+ICsJCWJy ZWFrOw0KPiA+ICsJZGVmYXVsdDoNCj4gPiArCQlNSVNTSU5HX0NBU0UobWdfY2xrdG9wX2hzY2xr Y3RsKTsNCj4gPiArCQlyZXR1cm4gMDsNCj4gPiArCX0NCj4gPiArDQo+ID4gKwlkaXYyID0gKG1n X2Nsa3RvcF9oc2Nsa2N0bCAmDQo+ID4gTUdfQ0xLVE9QMl9IU0NMS0NUTF9EU0RJVl9SQVRJT19N QVNLKSA+Pg0KPiA+ICsJCU1HX0NMS1RPUDJfSFNDTEtDVExfRFNESVZfUkFUSU9fU0hJRlQ7DQo+ ID4gKwkvKiBkaXYyIHZhbHVlIG9mIDAgaXMgc2FtZSBhcyAxIG1lYW5zIG5vIGRpdiAqLw0KPiA+ ICsJaWYgKGRpdjIgPT0gMCkNCj4gPiArCQlkaXYyID0gMTsNCj4gPiArDQo+ID4gKwkvKg0KPiA+ ICsJICogQWRqdXN0IHRoZSBvcmlnaW5hbCBmb3JtdWxhIHRvIGRlbGF5IHRoZSBkaXZpc2lvbiBi eSAyXjIyIGluDQo+ID4gb3JkZXIgdG8NCj4gPiArCSAqIG1pbmltaXplIHBvc3NpYmxlIHJvdW5k aW5nIGVycm9ycy4NCj4gPiArCSAqLw0KPiA+ICsJdG1wID0gKHU2NCltMSAqIG0yX2ludCAqIHJl ZmNsayArDQo+ID4gKwkgICAgICAoKCh1NjQpbTEgKiBtMl9mcmFjICogcmVmY2xrKSA+PiAyMik7 DQo+IA0KPiBJbiBteSBjYWxjdWxhdGlvbnMgdGhpcyBpcyBub3QgdGhlIHNhbWUgYXM6IE0xICog TTIgKiByZWZjbGsNCj4gDQo+IEFzIE0yIGlzID0gbTJfaW50ICsgKG0yX2ZyYWMvMl4yMikNCj4g DQo+IE90aGVyIHRoYW4gdGhhdCBldmVyeXRoaW5nIGVsc2UgbG9va3MgZ29vZC4NCg0KUGxlYXNl IGRpc2NvbnNpZGVyIHRoYXQsIEkgZGlkIHRoZSBjYWxjdWxhdGlvbnMgYWdhaW4gYW5kIHRoaXMg bmV3DQpmb3JtdWxhIG1hdGNoZXMgc3BlYy4NCg0KUmV2aWV3ZWQtYnk6IEpvc8OpIFJvYmVydG8g ZGUgU291emEgPGpvc2Uuc291emFAaW50ZWwuY29tPg0KDQoNCj4gDQo+IA0KPiA+ICsJdG1wID0g ZGl2X3U2NCh0bXAsIDUgKiBkaXYxICogZGl2Mik7DQo+ID4gKw0KPiA+ICsJcmV0dXJuIHRtcDsN Cj4gPiArfQ0KPiA+ICsNCj4gPiAgc3RhdGljIHZvaWQgZGRpX2RvdGNsb2NrX2dldChzdHJ1Y3Qg aW50ZWxfY3J0Y19zdGF0ZSAqcGlwZV9jb25maWcpDQo+ID4gIHsNCj4gPiAgCWludCBkb3RjbG9j azsNCj4gPiBAQCAtMTQ2Nyw4ICsxNTQyLDEwIEBAIHN0YXRpYyB2b2lkIGljbF9kZGlfY2xvY2tf Z2V0KHN0cnVjdA0KPiA+IGludGVsX2VuY29kZXIgKmVuY29kZXIsDQo+ID4gIAkJCWxpbmtfY2xv Y2sgPQ0KPiA+IGljbF9jYWxjX2RwX2NvbWJvX3BsbF9saW5rKGRldl9wcml2LA0KPiA+ICAJCQkJ CQkJCXBsbF9pZCkNCj4gPiA7DQo+ID4gIAl9IGVsc2Ugew0KPiA+IC0JCS8qIEZJWE1FIC0gQWRk IGZvciBNRyBQTEwgKi8NCj4gPiAtCQlXQVJOKDEsICJNRyBQTEwgY2xvY2tfZ2V0IGNvZGUgbm90 IGltcGxlbWVudGVkIHlldFxuIik7DQo+ID4gKwkJaWYgKHBsbF9pZCA9PSBEUExMX0lEX0lDTF9U QlRQTEwpDQo+ID4gKwkJCWxpbmtfY2xvY2sgPSBpY2xfY2FsY190YnRfcGxsX2xpbmsoZGV2X3By aXYsDQo+ID4gcG9ydCk7DQo+ID4gKwkJZWxzZQ0KPiA+ICsJCQlsaW5rX2Nsb2NrID0gaWNsX2Nh bGNfbWdfcGxsX2xpbmsoZGV2X3ByaXYsDQo+ID4gcG9ydCk7DQo+ID4gIAl9DQo+ID4gIA0KPiA+ ICAJcGlwZV9jb25maWctPnBvcnRfY2xvY2sgPSBsaW5rX2Nsb2NrOw0KPiANCj4gX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18NCj4gSW50ZWwtZ2Z4IG1haWxp bmcgbGlzdA0KPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnDQo+IGh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4DQpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBs aXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK