Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D88C6C433EF for ; Tue, 11 Jan 2022 20:10:25 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.256064.439220 (Exim 4.92) (envelope-from ) id 1n7NT8-0003fC-RG; Tue, 11 Jan 2022 20:10:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 256064.439220; Tue, 11 Jan 2022 20:10:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1n7NT8-0003f5-OE; Tue, 11 Jan 2022 20:10:10 +0000 Received: by outflank-mailman (input) for mailman id 256064; Tue, 11 Jan 2022 20:10:09 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1n7NT6-0003ex-W3 for xen-devel@lists.xenproject.org; Tue, 11 Jan 2022 20:10:08 +0000 Received: from ppsw-32.csi.cam.ac.uk (ppsw-32.csi.cam.ac.uk [131.111.8.132]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 78b75536-731a-11ec-81c1-a30af7de8005; Tue, 11 Jan 2022 21:10:08 +0100 (CET) Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:48120) by ppsw-32.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.136]:25) with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) id 1n7NT5-000Wvn-0G (Exim 4.95) (return-path ); Tue, 11 Jan 2022 20:10:07 +0000 Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86]) (Authenticated sender: amc96) by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id C89C21FDB6; Tue, 11 Jan 2022 20:10:06 +0000 (GMT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 78b75536-731a-11ec-81c1-a30af7de8005 X-Cam-AntiVirus: no malware found X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus Message-ID: Date: Tue, 11 Jan 2022 20:10:06 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH v2 3/3] tools/libs/ctrl: remove file related handling Content-Language: en-GB To: Juergen Gross , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20220111150318.22570-1-jgross@suse.com> <20220111150318.22570-4-jgross@suse.com> From: Andrew Cooper In-Reply-To: <20220111150318.22570-4-jgross@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 11/01/2022 15:03, Juergen Gross wrote: > There is no special file handling related to libxenctrl in Mini-OS > any longer, so the close hook can be removed. > > Signed-off-by: Juergen Gross Acked-by: Andrew Cooper > --- > V2: > - new patch > --- > tools/libs/ctrl/xc_minios.c | 9 --------- > 1 file changed, 9 deletions(-) > > diff --git a/tools/libs/ctrl/xc_minios.c b/tools/libs/ctrl/xc_minios.c > index 1799daafdc..3dea7a78a5 100644 > --- a/tools/libs/ctrl/xc_minios.c > +++ b/tools/libs/ctrl/xc_minios.c > @@ -35,15 +35,6 @@ > > #include "xc_private.h" > > -void minios_interface_close_fd(int fd); > - > -extern void minios_interface_close_fd(int fd); This is even more nonsense than the evtchn side.  Good riddance. ~Andrew > - > -void minios_interface_close_fd(int fd) > -{ > - files[fd].type = FTYPE_NONE; > -} > - > /* Optionally flush file to disk and discard page cache */ > void discard_file_cache(xc_interface *xch, int fd, int flush) > {