From: Simon Goldschmidt Date: Tue, 7 May 2019 21:42:04 +0200 Subject: [U-Boot] [PATCH 2/2] ARM: socfpga: Clear PL310 early in SPL In-Reply-To: <20190507192055.13093-2-marex@denx.de> References: <20190507192055.13093-1-marex@denx.de> <20190507192055.13093-2-marex@denx.de> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 07.05.19 21:20, Marek Vasut wrote: > On SoCFPGA Gen5 systems, it can rarely happen that a reboot from Linux > will result in stale data in PL310 L2 cache controller. Even if the L2 > cache controller is disabled via the CTRL register CTRL_EN bit, those > data can interfere with operation of devices using DMA, like e.g. the > DWMMC controller. This can in turn cause e.g. SPL to fail reading data > from SD/MMC. I bet this is copy & paste from the gen5 patch? It should probably say "On SoCFPGA A10 systems"? Other than that: Reviewed-by: Simon Goldschmidt > > The obvious solution here would be to fully reset the L2 cache controller > via the reset manager MPUMODRST L2 bit, however this causes bus hang even > if executed entirely from L1 I-cache to avoid generating any bus traffic > through the L2 cache controller. > > This patch thus configures and enables the L2 cache controller very early > in the SPL boot process, clears the L2 cache and disables the L2 cache > controller again. > > The reason for doing it in SPL is because we need to avoid accessing any > of the potentially stale data in the L2 cache, and we are certain any of > the stale data will be below the OCRAM address range. To further reduce > bus traffic during the L2 cache invalidation, we enable L1 I-cache and > run the invalidation code entirely out of the L1 I-cache. > > Signed-off-by: Marek Vasut > Cc: Chin Liang See > Cc: Dalon Westergreen > Cc: Dinh Nguyen > Cc: Simon Goldschmidt > Cc: Tien Fong Chee > --- > arch/arm/mach-socfpga/spl_a10.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/mach-socfpga/spl_a10.c b/arch/arm/mach-socfpga/spl_a10.c > index c8e73d47c0..8eb856f3d8 100644 > --- a/arch/arm/mach-socfpga/spl_a10.c > +++ b/arch/arm/mach-socfpga/spl_a10.c > @@ -81,6 +81,7 @@ void board_init_f(ulong dummy) > > socfpga_init_security_policies(); > socfpga_sdram_remap_zero(); > + socfpga_pl310_clear(); > > /* Assert reset to all except L4WD0 and L4TIMER0 */ > socfpga_per_reset_all(); >