From: Harry Wentland Subject: Re: [PATCH 6/6] drm/amd/display: Tidy up mem_input_program_surface_flip_and_addr() Date: Tue, 23 May 2017 11:39:51 -0400 Message-ID: References: <20170516142205.468-1-tom.stdenis@amd.com> <20170516142205.468-7-tom.stdenis@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: Content-Language: en-US List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: "Deucher, Alexander" , "StDenis, Tom" , "amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" T24gMjAxNy0wNS0yMyAxMToxNyBBTSwgRGV1Y2hlciwgQWxleGFuZGVyIHdyb3RlOgo+PiAtLS0t LU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQo+PiBGcm9tOiBhbWQtZ2Z4IFttYWlsdG86YW1kLWdmeC1i b3VuY2VzQGxpc3RzLmZyZWVkZXNrdG9wLm9yZ10gT24gQmVoYWxmCj4+IE9mIFRvbSBTdCBEZW5p cwo+PiBTZW50OiBUdWVzZGF5LCBNYXkgMTYsIDIwMTcgMTA6MjIgQU0KPj4gVG86IGFtZC1nZnhA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4+IENjOiBTdERlbmlzLCBUb20KPj4gU3ViamVjdDogW1BB VENIIDYvNl0gZHJtL2FtZC9kaXNwbGF5OiBUaWR5IHVwCj4+IG1lbV9pbnB1dF9wcm9ncmFtX3N1 cmZhY2VfZmxpcF9hbmRfYWRkcigpCj4+Cj4+IFNpZ25lZC1vZmYtYnk6IFRvbSBTdCBEZW5pcyA8 dG9tLnN0ZGVuaXNAYW1kLmNvbT4KPiAKPiBQYXRjaGVzIGFyZSBBY2tlZC1ieTogQWxleCBEZXVj aGVyIDxhbGV4YW5kZXIuZGV1Y2hlckBhbWQuY29tPgo+IAo+IElmIEhhcnJ5IGlzIG9rIHdpdGgg dGhlbSwgcGxlYXNlIGNvb3JkaW5hdGUgdG8gcHVsbCB0aGVtIHRocm91Z2ggdGhlIGRhbCB0cmVl Lgo+IAoKVGhhbmtzLCBBbGV4LgoKQWxyZWFkeSBwYXJ0IG9mIHRoZSBpbnRlcm5hbCBkYWwgdHJl ZSBhbmQgb24gdGhlIHdheSBmb3IgYW1kLXN0YWdpbmctNC45IAphcyBwYXJ0IG9mIHRvZGF5J3Mg c2V0IG9mIERDIHBhdGNoZXMuCgpIYXJyeQoKCj4gQWxleAo+IAo+PiAtLS0KPj4gICAuLi4vZHJt L2FtZC9kaXNwbGF5L2RjL2RjZTEyMC9kY2UxMjBfbWVtX2lucHV0LmMgICB8IDI3ICsrKysrKysr LS0tLS0tLQo+PiAtLS0tLS0tCj4+ICAgMSBmaWxlIGNoYW5nZWQsIDkgaW5zZXJ0aW9ucygrKSwg MTggZGVsZXRpb25zKC0pCj4+Cj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2Rp c3BsYXkvZGMvZGNlMTIwL2RjZTEyMF9tZW1faW5wdXQuYwo+PiBiL2RyaXZlcnMvZ3B1L2RybS9h bWQvZGlzcGxheS9kYy9kY2UxMjAvZGNlMTIwX21lbV9pbnB1dC5jCj4+IGluZGV4IGMwNjc3MjEx YmQ5My4uNWE3ZWRmZDhmYmY3IDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2Rp c3BsYXkvZGMvZGNlMTIwL2RjZTEyMF9tZW1faW5wdXQuYwo+PiArKysgYi9kcml2ZXJzL2dwdS9k cm0vYW1kL2Rpc3BsYXkvZGMvZGNlMTIwL2RjZTEyMF9tZW1faW5wdXQuYwo+PiBAQCAtMTk1LDIw ICsxOTUsMTIgQEAgc3RhdGljIGJvb2wKPj4gbWVtX2lucHV0X3Byb2dyYW1fc3VyZmFjZV9mbGlw X2FuZF9hZGRyKAo+PiAgIAkgKiBub24tWERNQSBNb2RlOiBHUlBIX1NVUkZBQ0VfVVBEQVRFX0lN TUVESUFURV9FTiA9IDEKPj4gICAJICogWERNQSBNb2RlOiBHUlBIX1NVUkZBQ0VfVVBEQVRFX0hf UkVUUkFDRV9FTiA9IDEKPj4gICAJICovCj4+IC0JRENQX1JFR19VUERBVEUoRENQMF9HUlBIX1VQ REFURSwKPj4gLQkJCUdSUEhfVVBEQVRFX0xPQ0ssIDEpOwo+PiAtCj4+IC0JaWYgKGZsaXBfaW1t ZWRpYXRlKSB7Cj4+IC0JCURDUF9SRUdfVVBEQVRFXzIoCj4+IC0JCQlEQ1AwX0dSUEhfRkxJUF9D T05UUk9MLAo+PiAtCQkJR1JQSF9TVVJGQUNFX1VQREFURV9JTU1FRElBVEVfRU4sIDAsCj4+IC0J CQlHUlBIX1NVUkZBQ0VfVVBEQVRFX0hfUkVUUkFDRV9FTiwgMSk7Cj4+IC0JfSBlbHNlIHsKPj4g LQkJRENQX1JFR19VUERBVEVfMigKPj4gLQkJCURDUDBfR1JQSF9GTElQX0NPTlRST0wsCj4+IC0J CQlHUlBIX1NVUkZBQ0VfVVBEQVRFX0lNTUVESUFURV9FTiwgMCwKPj4gLQkJCUdSUEhfU1VSRkFD RV9VUERBVEVfSF9SRVRSQUNFX0VOLCAwKTsKPj4gLQl9Cj4+ICsJRENQX1JFR19VUERBVEUoRENQ MF9HUlBIX1VQREFURSwgR1JQSF9VUERBVEVfTE9DSywgMSk7Cj4+ICsKPj4gKwlEQ1BfUkVHX1VQ REFURV8yKAo+PiArCQlEQ1AwX0dSUEhfRkxJUF9DT05UUk9MLAo+PiArCQlHUlBIX1NVUkZBQ0Vf VVBEQVRFX0lNTUVESUFURV9FTiwgMCwKPj4gKwkJR1JQSF9TVVJGQUNFX1VQREFURV9IX1JFVFJB Q0VfRU4sIGZsaXBfaW1tZWRpYXRlID8KPj4gMSA6IDApOwo+Pgo+PiAgIAlzd2l0Y2ggKGFkZHJl c3MtPnR5cGUpIHsKPj4gICAJY2FzZSBQTE5fQUREUl9UWVBFX0dSQVBISUNTOgo+PiBAQCAtMjE3 LDggKzIwOSw4IEBAIHN0YXRpYyBib29sCj4+IG1lbV9pbnB1dF9wcm9ncmFtX3N1cmZhY2VfZmxp cF9hbmRfYWRkcigKPj4gICAJCXByb2dyYW1fcHJpX2FkZHIobWVtX2lucHV0MTEwLCBhZGRyZXNz LT5ncnBoLmFkZHIpOwo+PiAgIAkJYnJlYWs7Cj4+ICAgCWNhc2UgUExOX0FERFJfVFlQRV9HUlBI X1NURVJFTzoKPj4gLQkJaWYgKGFkZHJlc3MtPmdycGhfc3RlcmVvLmxlZnRfYWRkci5xdWFkX3Bh cnQgPT0gMAo+PiAtCQkJfHwgYWRkcmVzcy0+Z3JwaF9zdGVyZW8ucmlnaHRfYWRkci5xdWFkX3Bh cnQgPT0gMCkKPj4gKwkJaWYgKGFkZHJlc3MtPmdycGhfc3RlcmVvLmxlZnRfYWRkci5xdWFkX3Bh cnQgPT0gMCB8fAo+PiArCQkgICAgYWRkcmVzcy0+Z3JwaF9zdGVyZW8ucmlnaHRfYWRkci5xdWFk X3BhcnQgPT0gMCkKPj4gICAJCQlicmVhazsKPj4gICAJCXByb2dyYW1fcHJpX2FkZHIobWVtX2lu cHV0MTEwLCBhZGRyZXNzLQo+Pj4gZ3JwaF9zdGVyZW8ubGVmdF9hZGRyKTsKPj4gICAJCXByb2dy YW1fc2VjX2FkZHIobWVtX2lucHV0MTEwLCBhZGRyZXNzLQo+Pj4gZ3JwaF9zdGVyZW8ucmlnaHRf YWRkcik7Cj4+IEBAIC0yMzQsOCArMjI2LDcgQEAgc3RhdGljIGJvb2wKPj4gbWVtX2lucHV0X3By b2dyYW1fc3VyZmFjZV9mbGlwX2FuZF9hZGRyKAo+PiAgIAlpZiAoZmxpcF9pbW1lZGlhdGUpCj4+ ICAgCQltZW1faW5wdXQtPmN1cnJlbnRfYWRkcmVzcyA9ICphZGRyZXNzOwo+Pgo+PiAtCURDUF9S RUdfVVBEQVRFKERDUDBfR1JQSF9VUERBVEUsCj4+IC0JCQlHUlBIX1VQREFURV9MT0NLLCAwKTsK Pj4gKwlEQ1BfUkVHX1VQREFURShEQ1AwX0dSUEhfVVBEQVRFLCBHUlBIX1VQREFURV9MT0NLLCAw KTsKPj4KPj4gICAJcmV0dXJuIHRydWU7Cj4+ICAgfQo+PiAtLQo+PiAyLjEyLjAKPj4KPj4gX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPj4gYW1kLWdmeCBt YWlsaW5nIGxpc3QKPj4gYW1kLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPj4gaHR0cHM6Ly9s aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbWQtZ2Z4Cj4gX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBhbWQtZ2Z4IG1haWxpbmcg bGlzdAo+IGFtZC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cHM6Ly9saXN0cy5mcmVl ZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbWQtZ2Z4Cj4gCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmFtZC1nZnggbWFpbGluZyBsaXN0CmFtZC1n ZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h aWxtYW4vbGlzdGluZm8vYW1kLWdmeAo=