Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 61DABC678D5 for ; Wed, 8 Mar 2023 21:12:44 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 66A1985EA2; Wed, 8 Mar 2023 22:12:41 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=ibm.com header.i=@ibm.com header.b="a9A5Z4PS"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id ED31685EA5; Wed, 8 Mar 2023 22:12:37 +0100 (CET) Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 09AD285925 for ; Wed, 8 Mar 2023 22:12:32 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=eajames@linux.ibm.com Received: from pps.filterd (m0098420.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 328KN4TY029678; Wed, 8 Mar 2023 21:12:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pp1; bh=iM8t4HCHButgRNkLQNHuviT5nPHH5KLEUIb2FsWPTY8=; b=a9A5Z4PScL+wvMIm6VX09htoHE8OqBMwRmjnyl9vaHRyqygZzdqXZpaTZ3/TrLq2Qo+G MshN9CvTS5UAQEPuGteRa9hhDbkrlljbMbdV4b/NvdLlJdZX3Y17jyMpF9sGOIktxRQN jAyN9RCYBBY1KlLbE4yuCiLoEsnvpCOOzL6g8mXu99mBbi/QQYlcwkxxEww94AI7Y689 qKEwqf0LzsgxKvBvwUASwfEQQOMLhxEaD6maC2z6LN3acQmenyZwGglrQ0x5mNywuOvK wlA0yUgGNgGIkkwge+4fPJnDh8Z1YBbzhZD4DcqUUb8vtPrmmVZLxkSyyEXs1MIbKuHE eg== Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com (PPS) with ESMTPS id 3p6t3b597r-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 08 Mar 2023 21:12:26 +0000 Received: from m0098420.ppops.net (m0098420.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 328KouCH010766; Wed, 8 Mar 2023 21:12:26 GMT Received: from ppma01dal.us.ibm.com (83.d6.3fa9.ip4.static.sl-reverse.com [169.63.214.131]) by mx0b-001b2d01.pphosted.com (PPS) with ESMTPS id 3p6t3b597k-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 08 Mar 2023 21:12:26 +0000 Received: from pps.filterd (ppma01dal.us.ibm.com [127.0.0.1]) by ppma01dal.us.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 328ItV3Q022236; Wed, 8 Mar 2023 21:12:25 GMT Received: from smtprelay06.wdc07v.mail.ibm.com ([9.208.129.118]) by ppma01dal.us.ibm.com (PPS) with ESMTPS id 3p6fhhpvfd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 08 Mar 2023 21:12:25 +0000 Received: from smtpav04.dal12v.mail.ibm.com (smtpav04.dal12v.mail.ibm.com [10.241.53.103]) by smtprelay06.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 328LCNUH60228084 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 8 Mar 2023 21:12:23 GMT Received: from smtpav04.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9B0FD58056; Wed, 8 Mar 2023 21:12:23 +0000 (GMT) Received: from smtpav04.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id ED95F58052; Wed, 8 Mar 2023 21:12:22 +0000 (GMT) Received: from [9.160.23.141] (unknown [9.160.23.141]) by smtpav04.dal12v.mail.ibm.com (Postfix) with ESMTP; Wed, 8 Mar 2023 21:12:22 +0000 (GMT) Message-ID: Date: Wed, 8 Mar 2023 15:12:22 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v8 0/6] tpm: Support boot measurements To: Ilias Apalodimas Cc: u-boot@lists.denx.de, sjg@chromium.org, xypron.glpk@gmx.de, joel@jms.id.au References: <20230303192506.1368538-1-eajames@linux.ibm.com> Content-Language: en-US From: Eddie James In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed X-TM-AS-GCONF: 00 X-Proofpoint-GUID: SSo5d6BgD5yFqn9KiU5RYgQNWQ6I0kf6 X-Proofpoint-ORIG-GUID: zFQPnLgIdp3Moj76qzpZcksXsGJB0vw5 Content-Transfer-Encoding: 7bit X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-03-08_15,2023-03-08_03,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 adultscore=0 malwarescore=0 bulkscore=0 mlxlogscore=999 spamscore=0 priorityscore=1501 lowpriorityscore=0 clxscore=1015 impostorscore=0 phishscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2303080178 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On 3/6/23 00:58, Ilias Apalodimas wrote: > Hi Eddie, > > This has a few failures on the CI [0]. > Please have a look and let me know if you can't understand the failures Hi, I think I have fixed the sandbox ones for v9. I'm unsure about the EFI selftest one in qemu targets... Thanks, Eddie > > [0] https://source.denx.de/u-boot/custodians/u-boot-tpm/-/pipelines/15471 > > Regards > /Ilias > On Fri, Mar 03, 2023 at 01:25:00PM -0600, Eddie James wrote: >> This series adds support for measuring the boot images more generically >> than the existing EFI support. Several EFI functions have been moved to >> the TPM layer. The series includes optional measurement from the bootm >> command. >> A new test case has been added for the bootm measurement to test the new >> path, and the sandbox TPM2 driver has been updated to support this use >> case. >> This series is based on Ilias' auto-startup series and Simon's additions. >> >> Changes since v7: >> - Change name of tcg2_init_log and add more documentation >> - Add a check, when parsing the event log header, to ensure that the >> previous stage bootloader used all the active PCRs. >> - Change name of tcg2_log_find_end >> - Fix the greater than or equal to check to exit the log parsing >> - Make sure log_position is 0 if there is any error discovering the log >> - Return errors parsing the log if the data is corrupt so that we don't >> end up with half a log >> >> Changes since v6: >> - Added comment for bootm_measure >> - Fixed line length in bootm_measure >> - Added Linaro copyright for all the EFI moved code >> - Changed tcg2_init_log (and by extension, tcg2_measurement_init) to >> copy any discovered event log to the user's log if passed in. >> >> Changes since v5: >> - Re-ordered the patches to put the sandbox TPM driver patch second >> - Remove unused platform_get_eventlog in efi_tcg2.c >> - First look for tpm_event_log_* properties instead of linux,sml-* >> - Fix efi_tcg2.c compilation >> - Select SHA* configs >> - Remove the !SANDBOX dependency for EFI TCG2 >> - Only compile in the measurement u-boot command when CONFIG_MEASURED_BOOT >> is enabled >> >> Changes since v4: >> - Remove tcg2_measure_event function and check for NULL data in >> tcg2_measure_data >> - Use tpm_auto_startup >> - Fix efi_tcg2.c compilation for removing tcg2_pcr_read function >> - Change PCR indexes for initrd and dtb >> - Drop u8 casting in measurement test >> - Use bullets in documentation >> >> Changes since v3: >> - Reordered headers >> - Refactored more of EFI code into common code >> Removed digest_info structure and instead used the common alg_to_mask >> and alg_to_len >> Improved event log parsing in common code to get it equivalent to EFI >> Common code now extends PCR if previous bootloader stage couldn't >> No need to allocate memory in the common code, so EFI copies the >> discovered buffer like it did before >> Rename efi measure_event function >> >> Changes since v2: >> - Add documentation. >> - Changed reserved memory address to the top of the RAM for sandbox dts. >> - Add measure state to booti and bootz. >> - Skip measurement for EFI images that should be measured >> >> Changes since v1: >> - Refactor TPM layer functions to allow EFI system to use them, and >> remove duplicate EFI functions. >> - Add test case >> - Drop #ifdefs for bootm >> - Add devicetree measurement config option >> - Update sandbox TPM driver >> >> Eddie James (6): >> tpm: Fix spelling for tpmu_ha union >> tpm: sandbox: Update for needed TPM2 capabilities >> tpm: Support boot measurements >> bootm: Support boot measurement >> test: Add sandbox TPM boot measurement >> doc: Add measured boot documentation >> >> arch/sandbox/dts/sandbox.dtsi | 13 + >> arch/sandbox/dts/test.dts | 13 + >> boot/Kconfig | 23 + >> boot/bootm.c | 72 +++ >> cmd/booti.c | 1 + >> cmd/bootm.c | 2 + >> cmd/bootz.c | 1 + >> configs/sandbox_defconfig | 1 + >> doc/usage/index.rst | 1 + >> doc/usage/measured_boot.rst | 23 + >> drivers/tpm/tpm2_tis_sandbox.c | 100 ++- >> include/bootm.h | 11 + >> include/efi_tcg2.h | 44 -- >> include/image.h | 1 + >> include/test/suites.h | 1 + >> include/tpm-v2.h | 255 +++++++- >> lib/Kconfig | 4 + >> lib/efi_loader/Kconfig | 2 - >> lib/efi_loader/efi_tcg2.c | 1054 +++----------------------------- >> lib/tpm-v2.c | 815 ++++++++++++++++++++++++ >> test/boot/Makefile | 1 + >> test/boot/measurement.c | 66 ++ >> test/cmd_ut.c | 4 + >> 23 files changed, 1455 insertions(+), 1053 deletions(-) >> create mode 100644 doc/usage/measured_boot.rst >> create mode 100644 test/boot/measurement.c >> >> -- >> 2.31.1 >>