Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49E8DC83000 for ; Tue, 28 Apr 2020 12:19:10 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1E6412072A for ; Tue, 28 Apr 2020 12:19:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1E6412072A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jTPCB-0001gk-K0; Tue, 28 Apr 2020 12:18:39 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jTPC9-0001gf-ST for xen-devel@lists.xenproject.org; Tue, 28 Apr 2020 12:18:37 +0000 X-Inumbo-ID: 62d50170-894a-11ea-b07b-bc764e2007e4 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 62d50170-894a-11ea-b07b-bc764e2007e4; Tue, 28 Apr 2020 12:18:37 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 50CE4AC5F; Tue, 28 Apr 2020 12:18:35 +0000 (UTC) Subject: Re: [PATCH v4] x86: irq: Do not BUG_ON multiple unbind calls for shared pirqs To: vrd@amazon.com References: <20200306160254.8465-1-paul@xen.org> <58f00871-2fff-be69-299e-e2b9911e0723@suse.com> <000301d5f63a$df5f04a0$9e1d0de0$@xen.org> <0648e7ac-f5d7-4207-e2c6-8418681cca13@suse.com> <8bcd4d23-cb03-bb3e-360e-4213cd2d7b49@amazon.com> From: Jan Beulich Message-ID: Date: Tue, 28 Apr 2020 14:18:34 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <8bcd4d23-cb03-bb3e-360e-4213cd2d7b49@amazon.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: 'Julien Grall' , paul@xen.org, 'Andrew Cooper' , 'Varad Gautam' , xen-devel@lists.xenproject.org, =?UTF-8?B?J1JvZ2VyIFBhdSBNb25uw6kn?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 28.04.2020 13:58, vrd@amazon.com wrote: > On 3/10/20 3:19 PM, Jan Beulich wrote: >> On 09.03.2020 18:47, Paul Durrant wrote: >>> Please suggest code if you think it ought to be done differentely. I tried. >> How about this? It's admittedly more code, but imo less ad hoc. >> I've smoke tested it, but I depend on you or Varad to check that >> it actually addresses the reported issue. >> >> Jan >> >> x86/pass-through: avoid double IRQ unbind during domain cleanup > > > I have tested that this patch prevents __pirq_guest_unbind on an already-unbound pirq > during the continuation call for domain_kill -ERESTART, by using a modified xen that > forces an -ERESTART from pirq_guest_unbind to create the continuation. It fixes the > underlying issue. > > Tested-by: Varad Gautam Thanks much; I'll formally submit the patch then. Jan