Received: from eggs.gnu.org ([209.51.188.92]:50701) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gw8OS-000541-HY for qemu-devel@nongnu.org; Tue, 19 Feb 2019 11:37:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gw8OR-00043F-Ve for qemu-devel@nongnu.org; Tue, 19 Feb 2019 11:37:16 -0500 References: <20190219161321.15012-1-berrange@redhat.com> <20190219161321.15012-3-berrange@redhat.com> <20190219162114.GQ7154@redhat.com> From: Eric Blake Message-ID: Date: Tue, 19 Feb 2019 10:37:05 -0600 MIME-Version: 1.0 In-Reply-To: <20190219162114.GQ7154@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 2/2] iotests: avoid broken pipe with certtool List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= , Thomas Huth Cc: Kevin Wolf , qemu-devel@nongnu.org, qemu-block@nongnu.org, Max Reitz On 2/19/19 10:21 AM, Daniel P. Berrang=C3=A9 wrote: >>> +tls_certtool() >>> +{ >>> + certtool "$@" 1>certtool.log 2>&1 >>> + if test "$?" =3D 0; then >>> + head -1 certtool.log >>> + else >>> + cat certtool.log >>> + fi >>> + rm -f certtool.log >>> +} >> >> I assume this is running in a unique directory so that there can not b= e >> a clash with a test running in parallel? Otherwise I'd recommend an >> mktemp file name here... >=20 > Hmm, could be a problem. Whatever happened to the plan to make every > iotests run in a private directory ? Did that ever get done ? Nope, still not done :( Jeff left Red Hat, and so far no one else has revived his series. Volunteers? --=20 Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org