Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2440C43461 for ; Tue, 8 Sep 2020 12:04:38 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0E77221D81 for ; Tue, 8 Sep 2020 12:04:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="pXNwTtF8"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ti.com header.i=@ti.com header.b="ia2HCvqT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0E77221D81 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 97932174F; Tue, 8 Sep 2020 14:03:46 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 97932174F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1599566676; bh=q2QxXkEBBSwufOXUF4prFgslxCzFvzOU3WELUM8zvAw=; h=Subject:From:To:References:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=pXNwTtF8pk1GuKe0K4Wn7Ug1OcQgJSywskjZieZnSDOKuOnm/2W+TNCN8wZfeOid+ dg9Pd/pDr2Iz5zDwnh/puYgksmMjokdXnoNxAUWzq1/0RNXTO0d6J0E0fzLAT4V8ti bx7E5mXof8a0H/BNBz4ITsaPu/IyQxIt9YC1jS5k= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 1B0A6F801F2; Tue, 8 Sep 2020 14:03:46 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id B99B7F80264; Tue, 8 Sep 2020 14:03:43 +0200 (CEST) Received: from fllv0016.ext.ti.com (fllv0016.ext.ti.com [198.47.19.142]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 77BDEF800FD for ; Tue, 8 Sep 2020 14:03:32 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 77BDEF800FD Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="ia2HCvqT" Received: from fllv0034.itg.ti.com ([10.64.40.246]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 088C3VsW004198; Tue, 8 Sep 2020 07:03:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1599566611; bh=nsqPY6o4grvE2pz2lannxuY5WsjPIahg4+RoCYp/mc4=; h=Subject:From:To:CC:References:Date:In-Reply-To; b=ia2HCvqTdT2aSCL0/porgUy55z/i+UNq4fGm51IBwnjCi49OkizTxLE8QrQf5pLhG tNYc8imMXyJknGPW8h8Bjtcf/u01AeRfbs9KUtXdyT/+siXEYWnKXnxY9GGFMd0Cgj bZSQ1blN0Ra3RX6g1cY8xR/cDa84TcLT/G/RdfnA= Received: from DFLE115.ent.ti.com (dfle115.ent.ti.com [10.64.6.36]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 088C3V75118701 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 8 Sep 2020 07:03:31 -0500 Received: from DFLE110.ent.ti.com (10.64.6.31) by DFLE115.ent.ti.com (10.64.6.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Tue, 8 Sep 2020 07:03:31 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DFLE110.ent.ti.com (10.64.6.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Tue, 8 Sep 2020 07:03:31 -0500 Received: from [192.168.2.6] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 088C3SxG114548; Tue, 8 Sep 2020 07:03:29 -0500 Subject: Re: [PATCH 1/2] ASoC: tlv320adcx140: Avoid accessing invalid gpio_reset From: Peter Ujfalusi To: Camel Guo , , , , References: <20200908083521.14105-1-camel.guo@axis.com> <7bb93489-dbd5-d1a5-5df6-e62470bd2252@ti.com> X-Pep-Version: 2.0 Message-ID: Date: Tue, 8 Sep 2020 15:03:28 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <7bb93489-dbd5-d1a5-5df6-e62470bd2252@ti.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Cc: alsa-devel@alsa-project.org, kernel@axis.com, linux-kernel@vger.kernel.org, Camel Guo X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Hi, On 08/09/2020 14.59, Peter Ujfalusi wrote: >=20 >=20 > On 08/09/2020 11.35, Camel Guo wrote: >> From: Camel Guo >> >> When gpio_reset is not well defined in devicetree, the >> adcx140->gpio_reset is an error code instead of NULL. In this case, >> adcx140->gpio_reset should not be used by adcx140_reset. This commit >> sets it NULL to avoid accessing an invalid variable. >> >> Signed-off-by: Camel Guo >> --- >> sound/soc/codecs/tlv320adcx140.c | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/sound/soc/codecs/tlv320adcx140.c b/sound/soc/codecs/tlv32= 0adcx140.c >> index 7ae6ec374be3..597dd1062943 100644 >> --- a/sound/soc/codecs/tlv320adcx140.c >> +++ b/sound/soc/codecs/tlv320adcx140.c >> @@ -984,8 +984,10 @@ static int adcx140_i2c_probe(struct i2c_client *i= 2c, >> =20 >> adcx140->gpio_reset =3D devm_gpiod_get_optional(adcx140->dev, >> "reset", GPIOD_OUT_LOW); >> - if (IS_ERR(adcx140->gpio_reset)) >> + if (IS_ERR(adcx140->gpio_reset) || adcx140->gpio_reset =3D=3D NULL) = { >> dev_info(&i2c->dev, "Reset GPIO not defined\n"); >> + adcx140->gpio_reset =3D NULL; >=20 > the correct fix is to: > dev_err(&i2c->dev, "Reset GPIO not defined\n"); no need to print, I think gpio core will do that. > return PTR_ERR(adcx140->gpio_reset); >=20 > If the reset GPIO is specified and you get error when requesting it as > optional, there is a reason for that. > For example deferred probing. >=20 >> + } >> =20 >> adcx140->supply_areg =3D devm_regulator_get_optional(adcx140->dev, >> "areg"); >> >=20 > - P=C3=A9ter >=20 > Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. > Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki >=20 - P=C3=A9ter Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki