From: "selvanair (Code Review)" Date: Wed, 1 Apr 2026 11:59:38 +0000 In-Reply-To: References: Reply-To: selva.nair@...277..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="sKCwfyZeFIw="; charset=UTF-8 Subject: [Openvpn-devel] [S] Change in openvpn[master]: Add unit tests for 'auth-user-pass username-only' List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos Cc: openvpn-devel --sKCwfyZeFIw= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/1602?usp=3Demail to look at the new patch set (#2). Change subject: Add unit tests for 'auth-user-pass username-only' ...................................................................... Add unit tests for 'auth-user-pass username-only' Input from stdin is tested. Change-Id: I1c18b3cf4a454444a61941d88a702a140b0ac23d Signed-off-by: Selva Nair --- M tests/unit_tests/openvpn/test_user_pass.c 1 file changed, 11 insertions(+), 0 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/02/1602/2 diff --git a/tests/unit_tests/openvpn/test_user_pass.c b/tests/unit_tests/o= penvpn/test_user_pass.c index 16e0535..c0a0866 100644 --- a/tests/unit_tests/openvpn/test_user_pass.c +++ b/tests/unit_tests/openvpn/test_user_pass.c @@ -282,6 +282,17 @@ assert_true(up.defined); assert_string_equal(up.username, "user"); assert_string_equal(up.password, ""); + + reset_user_pass(&up); + + flags =3D GET_USER_PASS_USERNAME_ONLY; + expect_string(query_user_exec_builtin, query_user[i].prompt, "Enter UT= Username:"); + will_return(query_user_exec_builtin, "cuser"); + will_return(query_user_exec_builtin, true); + assert_true(get_user_pass_cr(&up, "stdin", "UT", flags, NULL)); + assert_true(up.defined); + assert_string_equal(up.username, "cuser"); + assert_string_equal(up.password, "[[BLANK]]"); } /* NOTE: expect_assert_failure does not seem to work with MSVC */ -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1602?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings?usp=3Demail Gerrit-MessageType: newpatchset Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I1c18b3cf4a454444a61941d88a702a140b0ac23d Gerrit-Change-Number: 1602 Gerrit-PatchSet: 2 Gerrit-Owner: selvanair Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos --sKCwfyZeFIw= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is cur= rently required from: plaisthos.

selvanair uploaded patch set #2 to this change.

<= a href=3D"http://gerrit.openvpn.net/c/openvpn/+/1602?usp=3Demail">View Chan= ge

Add unit tests for 'auth-user-pass username-onl=
y'

Input from stdin is tested.

Change-Id: I1c18b3cf4a4544= 44a61941d88a702a140b0ac23d
Signed-off-by: Selva Nair <selva.nair@...1665...= 77...>
---
M tests/unit_tests/openvpn/test_user_pass.c
1 file c= hanged, 11 insertions(+), 0 deletions(-)

git pul=
l ssh://gerrit.openvpn.net:29418/openvpn refs/changes/02/1602/2
dif=
f --git a/tests/unit_tests/openvpn/test_user_pass.c b/tests/unit_tests/open=
vpn/test_user_pass.c
index 16e0535..c0a0866 100644--- a/tests/unit_tests/openvpn/test_user_pass.c
+++= b/tests/unit_tests/openvpn/test_user_pass.c
@@ -282,6 +282= ,17 @@
assert_true(up.defined);
a= ssert_string_equal(up.username, "user");
ass= ert_string_equal(up.password, "");
+
+ reset_user_pass(&up);
+
+ = flags =3D GET_USER_PASS_USERNAME_ONLY;
+ expect_string(query_user_exec_builtin, query_user[i= ].prompt, "Enter UT Username:");
+ will_return(query_user_exec_builtin, "cuser= ");
+ will_re= turn(query_user_exec_builtin, true);
+ assert_true(get_user_pass_cr(&up, "stdin"= ;, "UT", flags, NULL));
+ assert_true(up.defined);
+ assert_string_equal(up.username, "cuser&quo= t;);
+ assert_stri= ng_equal(up.password, "[[BLANK]]");
}
=
/* NOTE: expect_assert_failure does not seem to wo= rk with MSVC */

To view, visit change 1602= . To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: newpatchset
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I1c18b3cf4a454444a61941d88a7= 02a140b0ac23d
Gerrit-Change-Number: 1602
Gerrit-PatchSet: 2
Gerrit-Owner: selvanair <selva.nair@...1354...= ..>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
= --sKCwfyZeFIw=--