From: "cron2 (Code Review)" Date: Wed, 6 Dec 2023 12:57:27 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="uqJwDO7NezA="; charset=UTF-8 Subject: [Openvpn-devel] [M] Change in openvpn[master]: Implement the --export-peer-cert feature List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos Cc: flichtenheld , openvpn-devel --uqJwDO7NezA= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/ope= nvpn/+/466?usp=3Demail ) Change subject: Implement the --export-peer-cert feature ...................................................................... Patch Set 1: (1 comment) File doc/man-sections/script-options.rst: http://gerrit.openvpn.net/c/openvpn/+/466/comment/3f968f88_17232d6f : PS1, Line 426: --export-peer-cert-path dir so this is a new option, which is incompatible and will break people's conf= ig (if they use the old option). So we should go for the same option name = "--tls-export-cert" - or alternatively provide a Changes.rst explaining the= reasons. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/466?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ia9b3f1813d2d0d492d17c87348b4cebd0bf19ce2 Gerrit-Change-Number: 466 Gerrit-PatchSet: 1 Gerrit-Owner: plaisthos Gerrit-Reviewer: flichtenheld Gerrit-CC: cron2 Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: flichtenheld Gerrit-Comment-Date: Wed, 06 Dec 2023 12:57:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment --uqJwDO7NezA= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: flichtenheld, plaisthos.

View C= hange

1 comment:

    <= li style=3D"margin: 0; padding: 0;">

    File doc/man-sections/script-options= .rst:

    • Patch Set #1,= Line 426: --export-pee= r-cert-path dir

      so this is a new option, which is incompatible and will break peo= ple's config (if they use the old option). So we should go for the sam= e option name "--tls-export-cert" - or alternatively provide a Ch= anges.rst explaining the reasons.

To view, visit = change 46= 6. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ia9b3f1813d2d0d492d17c87348b= 4cebd0bf19ce2
Gerrit-Change-Number: 466
Gerrit-PatchSet: 1
Gerrit-Owner: plaisthos <arne-openvpn@...1711...= 27...>
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-CC: cron2 <gert@...1296...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-Comment-Date: Wed, 06 Dec 2023 12:57:27= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
--uqJwDO7NezA=--