Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39C44CDB46E for ; Thu, 12 Oct 2023 09:28:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B4E748D011C; Thu, 12 Oct 2023 05:28:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AFE468D0002; Thu, 12 Oct 2023 05:28:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9ED518D011C; Thu, 12 Oct 2023 05:28:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 8F26B8D0002 for ; Thu, 12 Oct 2023 05:28:42 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 569BF14055B for ; Thu, 12 Oct 2023 09:28:42 +0000 (UTC) X-FDA: 81336284484.21.6EA9A48 Received: from out-197.mta1.migadu.com (out-197.mta1.migadu.com [95.215.58.197]) by imf21.hostedemail.com (Postfix) with ESMTP id 460271C0024 for ; Thu, 12 Oct 2023 09:28:40 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=ubV27hWn; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf21.hostedemail.com: domain of yajun.deng@linux.dev designates 95.215.58.197 as permitted sender) smtp.mailfrom=yajun.deng@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697102920; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=w+ZbiEKpKR/7IxtLp0s4sFhIE2lb5aqqkwzkmrZpvEk=; b=GPhpS+EOC5ZJj0aDpPW1JxWBzYu1X9LJ8d4rl9CoDeZMbAl946bCLd7zLKwmNx3ld9slSN LWP/uog7qk7jVD56RPMPfzL0Qi9pAl9E6qr9lcDXp8vSYcdw0lV0KkoIJOPg1LH/ltwBXQ 6tYrmKEbX1LOJTI2VK89BHYWsVXsZwk= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=ubV27hWn; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf21.hostedemail.com: domain of yajun.deng@linux.dev designates 95.215.58.197 as permitted sender) smtp.mailfrom=yajun.deng@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697102920; a=rsa-sha256; cv=none; b=rV3H3PP5GYHO4PTBjnLD9wpDjwtGUyCqVi565XpRSutX3vsoMXzULn7p1iu0Dj6az72fGQ 6JzCNs+ciev5Ax/83egDxJgqZkgwil4+5QlGilPClcPqg9caTU+WjR9bc6MMv0L2nCl/aU vABI27EsaagjRsVe6H+DIJbPPrrp8ME= Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1697102917; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=w+ZbiEKpKR/7IxtLp0s4sFhIE2lb5aqqkwzkmrZpvEk=; b=ubV27hWnZTTjqrXaHxG3aEtMO+m3O0kZ/+VmufEJ0CJrzJ42r4bV49IOELKyM/FLxAOXsT eHISFxZ6AEbGforatfopFagl5KX6XOLIUjSl2961O7yOSMLcQbQ1t65ekzkktm6kTwUVx0 kqMjA7nbmvwCu55EzQxkS3EvjxObxCU= Date: Thu, 12 Oct 2023 17:28:31 +0800 MIME-Version: 1.0 Subject: Re: [PATCH v3] memblock: don't run loop in memblock_add_range() twice Content-Language: en-US To: Mike Rapoport Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20231003163045.191184-1-yajun.deng@linux.dev> <20231005051959.GC3303@kernel.org> <20231012092442.GR3303@kernel.org> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Yajun Deng In-Reply-To: <20231012092442.GR3303@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 460271C0024 X-Stat-Signature: 3m3qkhqf7znkm3rnbkkx8np43xr974nd X-HE-Tag: 1697102920-270257 X-HE-Meta: U2FsdGVkX1/BhHxW1+xZ3Ti4E42KYiXRPUW/X8DQDsPfrjTi8RU/91UXFmzp9xHGfp9FO7j7m5VJ33PEUi04Qnvp4KsQgtE6WqmG59GA+0f00EFmAfjcQ9wiy4R+cRMJ6Frs+tFX7GegjeGnwLpNsaHhL5F5qzG3PXS11z57VlfJ/SZ8zQQd0Nz/0pkN8m+CdzJkonVKZqJhCnkwDLvxO4Miho6ifpIlVeGJ21mZ63vGLTZcCeQQd/wkNMvGLXI8paIa1XUdo1fsZYhNN11ugI6sLY7aL1eV2BthREWMt1ztsJEg1My0+Ldo02UhxSGPz9atKDWyrPUKohzpV4iYBJCHvJznACbpvlMK4wKD1IOUxkmk9AnDh3lE6wZRhNvDzzwAqkPLekPg9xyZZtrBOCVVgQHQvHc4HDKf3mfiL24yVMnbzzuf0bACb/mHKZHiVzeGO6K9F9cj9xVnScO/GnRisN9DbK6OitKB+BAMTMKaDqBbVBl71f6GY4l8hLE8ECY52aN86bteBzXNgecI26rilurKPIK8ZIyjPG21PhtaVN6krcWT1YX+aL/4W/shTmcKNf0bocHK+XRWsOiQZUh2DXqZPSLaN4LT2h+psspmaTqQi1nIPO528hU0vdVGPYNDr4ul5Bthtg9zD7JmLxDo8zqf63g6ulZHZoAW56gedugWHNK/A+gkvggpdQuFXaUeozQQI4vRC8qg+qTjj3vKmNtclrwq2fGZD6wLiBnL6+pAG2vHx4DNixBbSP+9vxYaRzG0cxPdW3NpWgf5mPT6C6+A3uiACcqy3YKQUHTphW6L4t8svIJHJcQrVn/TKFXfWhC90eeZiHw3hMuXlpZ5wIoBKjpzcTP2JgxWqMohD7tJDzkjQc92gUdb4tSlgZTF/6Gvjkml8390BnaDfebkyLJpuqAlQDc7JLhr3g2og6smxIlMVyS3XxAfc13DVlR1PLm/UXSIIwrjqKE UFupmi1Z 1p4cHeAKdNlm8Io3LPMblHC1kHWAqAIwfWOpzi5v8l/BXwTl5eY/21PHbxnRljdzauQv8Nakxb7WZ1AqJqq2CG6Eb8ZXllzxTghYnBejJWgp5x8Sk93SDcrHLxr6hGtE069l7 X-Bogosity: Ham, tests=bogofilter, spamicity=0.016442, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/10/12 17:24, Mike Rapoport wrote: > On Thu, Oct 05, 2023 at 11:20:19PM +0800, Yajun Deng wrote: >> On 2023/10/5 13:19, Mike Rapoport wrote: >> >>> I don't see this micro-optimization is worth the churn and potential bugs. >>> NAK. >> There are many handouts that tell people it needs to run twice in >> memblock_add_range(). >> >> I think it's time to change this. I'm trying to tell people that running >> twice is unnecessary. > It might be unnecessary, but it's still simpler than the solutions you > proposed. And, again, removing the second loop is not worth the churn and > potential bugs. > Okay, I got it. Thanks.