From: Michel Thierry Subject: Re: [PATCH v3 01/22] drm/i915: Use a mask when applying WaProgramL3SqcReg1Default Date: Fri, 13 Oct 2017 17:26:38 -0700 Message-ID: References: <1507928056-6966-1-git-send-email-oscar.mateo@intel.com> <1507928056-6966-2-git-send-email-oscar.mateo@intel.com> <150793012702.3226.7625682154009911031@mail.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id EAE0B6EBF5 for ; Sat, 14 Oct 2017 00:26:39 +0000 (UTC) In-Reply-To: <150793012702.3226.7625682154009911031@mail.alporthouse.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , "Mateo Lozano, Oscar" , "intel-gfx@lists.freedesktop.org" Cc: "Oscar@freedesktop.org" List-Id: intel-gfx@lists.freedesktop.org T24gMTAvMTMvMjAxNyAyOjI4IFBNLCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4gUXVvdGluZyBPc2Nh ciBNYXRlbyAoMjAxNy0xMC0xMyAyMTo1Mzo1NSkKPj4gT3RoZXJ3aXNlIHdlIGFyZSBibGFzdGlu ZyBvdGhlciBiaXRzIGluIEdFTjhfTDNTUUNSRUcxIHRoYXQgbWlnaHQgYmUgaW1wb3J0YW50Cj4+ IChhbHRob3VnaCB3ZSBwcm9iYWJseSBhcmVuJ3QgYXQgdGhlIG1vbWVudCBiZWNhdXNlIDAgc2Vl bXMgdG8gYmUgdGhlIGRlZmF1bHQKPj4gZm9yIGFsbCB0aGUgb3RoZXIgYml0cykuCj4+Cj4+IEZp eGVzOiAwNTBmYzQ2ICgiZHJtL2k5MTU6Ynh0OiBpbXBsZW1lbnQgV2FQcm9ncmFtTDNTcWNSZWcx RGVmYXVsdEZvclBlcmYiKQo+PiBGaXhlczogNDUwMTc0ZiAoImRybS9pOTE1L2NodjogVHVuZSBM MyBTUUMgY3JlZGl0cyBiYXNlZCBvbiBhY3R1YWwgbGF0ZW5jaWVzIikKPj4gU2lnbmVkLW9mZi1i eTogT3NjYXIgTWF0ZW8gPG9zY2FyLm1hdGVvQGludGVsLmNvbT4KPj4gQ2M6IENocmlzIFdpbHNv biA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+PiBDYzogTWlrYSBLdW9wcGFsYSA8bWlrYS5r dW9wcGFsYUBsaW51eC5pbnRlbC5jb20+Cj4+IENjOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5 cmphbGFAbGludXguaW50ZWwuY29tPgo+PiBDYzogSW1yZSBEZWFrIDxpbXJlLmRlYWtAaW50ZWwu Y29tPgo+PiBDYzogTWljaGVsIFRoaWVycnkgPG1pY2hlbC50aGllcnJ5QGludGVsLmNvbT4KPiAK PiBJZiB0aGlzIGdldHMgbG9zdCBpbiB0aGUgc2VyaWVzLCBwbGVhc2Ugc2VuZCBzZXBhcmF0ZWx5 IHRvIGJyaW5nCj4gYXR0ZW50aW9uIHRvIHRoZSBidWdmaXguIEhvcGVmdWxseSByLWIncyB3aWxs IGJlIHByb21wdC4uLgo+IAoKVGhpcyBpcyB3aGF0IGhhcHBlbnMgd2hlbiBzb21lb25lIGNvcGll cyB3b3JrYXJvdW5kcyBmcm9tIGFub3RoZXIgZHJpdmVyIAp2ZXJiYXRpbSA6UwoKTHVja2lseSBh bGwgdGhlIG90aGVyIGZpZWxkcyBzaG91bGQgYmUgMCdzLgoKPj4gLS0tCj4+ICAgZHJpdmVycy9n cHUvZHJtL2k5MTUvaTkxNV9yZWcuaCAgICAgICAgfCAxICsKPj4gICBkcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9lbmdpbmVfY3MuYyB8IDkgKysrKysrLS0tCj4+ICAgZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfcG0uYyAgICAgICAgfCA5ICsrKysrKy0tLQo+PiAgIDMgZmlsZXMgY2hhbmdl ZCwgMTMgaW5zZXJ0aW9ucygrKSwgNiBkZWxldGlvbnMoLSkKPj4KPj4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVnLmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1 X3JlZy5oCj4+IGluZGV4IGQyZDBhODMuLjU4NThmNWYgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2k5MTVfcmVnLmgKPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkx NV9yZWcuaAo+PiBAQCAtNzA0MSw2ICs3MDQxLDcgQEAgZW51bSB7Cj4+ICAgICovCj4+ICAgI2Rl ZmluZSAgTDNfR0VORVJBTF9QUklPX0NSRURJVFMoeCkgICAgICAgICAgICAoKCh4KSA+PiAxKSA8 PCAxOSkKPj4gICAjZGVmaW5lICBMM19ISUdIX1BSSU9fQ1JFRElUUyh4KSAgICAgICAgICAgICAg ICgoKHgpID4+IDEpIDw8IDE0KQo+PiArI2RlZmluZSAgTDNfUFJJT19DUkVESVRTX01BU0sgICAg ICAgICAgICAgICAgICAoMHgxZiA8PCAxOSkgfCAoMHgxZiA8PCAxNCkKCmNoZWNrcGF0Y2gucGwg aXMgYXNraW5nIHRvIGVuY2xvc2UgdGhpcyBtYWNyb15eXiBpbiBwYXJlbnRoZXNlcywKCisjZGVm aW5lICBMM19QUklPX0NSRURJVFNfTUFTSyAgICAgICAgICAgICAoKDB4MWYgPDwgMTkpIHwgKDB4 MWYgPDwgMTQpKQoKV2l0aCB0aGF0LAoKUmV2aWV3ZWQtYnk6IE1pY2hlbCBUaGllcnJ5IDxtaWNo ZWwudGhpZXJyeUBpbnRlbC5jb20+Cgo+Pgo+PiAgICNkZWZpbmUgR0VON19MM0NOVExSRUcxICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBfTU1JTygweEIwMUMpCj4+ICAgI2RlZmluZSAg R0VON19XQV9GT1JfR0VON19MM19DT05UUk9MICAgICAgICAgICAgICAgICAgIDB4M0M0N0ZGOEMK Pj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2VuZ2luZV9jcy5jIGIv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZW5naW5lX2NzLmMKPj4gaW5kZXggYTU5YjJhMy4u NDBlNDM5YyAxMDA2NDQKPj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZW5naW5l X2NzLmMKPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZW5naW5lX2NzLmMKPj4g QEAgLTEyNTIsOSArMTI1MiwxMiBAQCBzdGF0aWMgaW50IGJ4dF9pbml0X3dvcmthcm91bmRzKHN0 cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSkKPj4gICAgICAgICAgfQo+Pgo+PiAgICAgICAg ICAvKiBXYVByb2dyYW1MM1NxY1JlZzFEZWZhdWx0Rm9yUGVyZjpieHQgKi8KPj4gLSAgICAgICBp ZiAoSVNfQlhUX1JFVklEKGRldl9wcml2LCBCWFRfUkVWSURfQjAsIFJFVklEX0ZPUkVWRVIpKQo+ PiAtICAgICAgICAgICAgICAgSTkxNV9XUklURShHRU44X0wzU1FDUkVHMSwgTDNfR0VORVJBTF9Q UklPX0NSRURJVFMoNjIpIHwKPj4gLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIEwzX0hJR0hfUFJJT19DUkVESVRTKDIpKTsKPj4gKyAgICAgICBpZiAoSVNfQlhUX1JF VklEKGRldl9wcml2LCBCWFRfUkVWSURfQjAsIFJFVklEX0ZPUkVWRVIpKSB7Cj4+ICsgICAgICAg ICAgICAgICB1MzIgdmFsID0gSTkxNV9SRUFEKEdFTjhfTDNTUUNSRUcxKTsKPj4gKyAgICAgICAg ICAgICAgIHZhbCAmPSB+TDNfUFJJT19DUkVESVRTX01BU0s7Cj4+ICsgICAgICAgICAgICAgICB2 YWwgfD0gTDNfR0VORVJBTF9QUklPX0NSRURJVFMoNjIpIHwgTDNfSElHSF9QUklPX0NSRURJVFMo Mik7Cj4+ICsgICAgICAgICAgICAgICBJOTE1X1dSSVRFKEdFTjhfTDNTUUNSRUcxLCB2YWwpOwo+ PiArICAgICAgIH0KPj4KPj4gICAgICAgICAgLyogV2FUb0VuYWJsZUh3Rml4Rm9yUHVzaENvbnN0 SFdCdWc6Ynh0ICovCj4+ICAgICAgICAgIGlmIChJU19CWFRfUkVWSUQoZGV2X3ByaXYsIEJYVF9S RVZJRF9DMCwgUkVWSURfRk9SRVZFUikpCj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9wbS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcG0uYwo+PiBpbmRl eCAyZmNmZjk3Li42YzJjOGQ4IDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9wbS5jCj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BtLmMKPj4gQEAg LTg0NzYsMTUgKzg0NzYsMTggQEAgc3RhdGljIHZvaWQgZ2VuOF9zZXRfbDNzcWNfY3JlZGl0cyhz dHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4+ICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIGludCBnZW5lcmFsX3ByaW9fY3JlZGl0cywKPj4gICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgaW50IGhpZ2hfcHJpb19jcmVkaXRzKQo+PiAgIHsKPj4g KyAgICAgICB1MzIgdmFsOwo+PiAgICAgICAgICB1MzIgbWlzY2NwY3RsOwo+Pgo+PiAgICAgICAg ICAvKiBXYVRlbXBEaXNhYmxlRE9QQ2xrR2F0aW5nOmJkdyAqLwo+PiAgICAgICAgICBtaXNjY3Bj dGwgPSBJOTE1X1JFQUQoR0VON19NSVNDQ1BDVEwpOwo+PiAgICAgICAgICBJOTE1X1dSSVRFKEdF TjdfTUlTQ0NQQ1RMLCBtaXNjY3BjdGwgJiB+R0VON19ET1BfQ0xPQ0tfR0FURV9FTkFCTEUpOwo+ Pgo+PiAtICAgICAgIEk5MTVfV1JJVEUoR0VOOF9MM1NRQ1JFRzEsCj4+IC0gICAgICAgICAgICAg ICAgICBMM19HRU5FUkFMX1BSSU9fQ1JFRElUUyhnZW5lcmFsX3ByaW9fY3JlZGl0cykgfAo+PiAt ICAgICAgICAgICAgICAgICAgTDNfSElHSF9QUklPX0NSRURJVFMoaGlnaF9wcmlvX2NyZWRpdHMp KTsKPj4gKyAgICAgICB2YWwgPSBJOTE1X1JFQUQoR0VOOF9MM1NRQ1JFRzEpOwo+PiArICAgICAg IHZhbCAmPSB+TDNfUFJJT19DUkVESVRTX01BU0s7Cj4+ICsgICAgICAgdmFsIHw9IEwzX0dFTkVS QUxfUFJJT19DUkVESVRTKGdlbmVyYWxfcHJpb19jcmVkaXRzKTsKPj4gKyAgICAgICB2YWwgfD0g TDNfSElHSF9QUklPX0NSRURJVFMoaGlnaF9wcmlvX2NyZWRpdHMpOwo+PiArICAgICAgIEk5MTVf V1JJVEUoR0VOOF9MM1NRQ1JFRzEsIHZhbCk7Cj4+Cj4+ICAgICAgICAgIC8qCj4+ICAgICAgICAg ICAqIFdhaXQgYXQgbGVhc3QgMTAwIGNsb2NrcyBiZWZvcmUgcmUtZW5hYmxpbmcgY2xvY2sgZ2F0 aW5nLgo+PiAtLQo+PiAxLjkuMQo+Pgo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCj4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+IEludGVsLWdmeEBsaXN0 cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2ludGVsLWdmeAo+IApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5m by9pbnRlbC1nZngK