Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D9EEAD13C2F for ; Mon, 26 Jan 2026 15:12:42 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vkOGa-00069z-Tm; Mon, 26 Jan 2026 10:12:36 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vkOGV-0005l4-UY for qemu-arm@nongnu.org; Mon, 26 Jan 2026 10:12:32 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vkOGU-0004tN-Io for qemu-arm@nongnu.org; Mon, 26 Jan 2026 10:12:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1769440349; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=NLuDrpnLGk4fWT1M5aZGriu0wX7dz7elXXhxjAzk0b4=; b=be1v1MQ062pmgYt+38y2D4iXbCMsyc54wsry/GSxadrSjL7KnwIdlLPwOGppjdKP2TxMIW yUPRoRrBN9tu1y9hIim9QbnQLF1TeaUCpOSkdox9NPOfa0c1fLIu61FfjXbAk9AgRrEbf/ qkSgonHOBmc55eHienvbNYHMKg5dFS8= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-501-wIR7MaXkNiK3kw8iye2zMw-1; Mon, 26 Jan 2026 10:12:22 -0500 X-MC-Unique: wIR7MaXkNiK3kw8iye2zMw-1 X-Mimecast-MFC-AGG-ID: wIR7MaXkNiK3kw8iye2zMw_1769440341 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-47ee3dd7fc8so49618245e9.3 for ; Mon, 26 Jan 2026 07:12:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769440341; x=1770045141; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=NLuDrpnLGk4fWT1M5aZGriu0wX7dz7elXXhxjAzk0b4=; b=pxYsaHOmHymTmBOo5m1jO0Am+tmitUUckAHjo/jcim77uWtxF0cBxWQ7FMTSylGBWf 7gifhJrVsjBGpgFYAsxiU2mWVMXF/pJmH8fpyAmDXe+fHn+dSO27MLSlPxsg9B53l//N FWq3HBgIqNxilH71hlfZevZfG5Kvk/B8bg2ZzLxxgY8cBFijWIIr+7rGOh3tIfFCDVpq aN3iLf4BEh4djwZjzrA9cvg8lVWCAZ7OK6XcXsTbYYgCjh0I2dnKt0gyCdYV45+/109w wKtXUp/JsUKLxtnFYf4D8wRyeBcOeqcIVJn9CLlUYNI8ogXsPCbaAUd7XsBCK1m/3hX3 KvMg== X-Forwarded-Encrypted: i=1; AJvYcCUkjWIb/+Y4/w6pZidBIfXF1ug/umzKUmifZwaH78EHWYssypl5XzJ600ehumv7Of1LXc8BAo949w==@nongnu.org X-Gm-Message-State: AOJu0Yx3BoIw/fe159V3FKNXDRtlf91E/SETTxaTcrvQnLpZQL14p+HN j4U2ibKguFiokpPES/bvNs6M/dUlcORGHzg6etxbMsElHHLGxrbaGchk7LAkNIHN4bJ/D50eOmE nG0+2yMlUypHDEh6q9sVB1KDi94CFTVlMtjaYWq0cU/h4yqO6tj+dr+de1mMiHA== X-Gm-Gg: AZuq6aJTs5Pm3dzRkmJLI/Lt1EfBncxZNUKOAlxrVOEjjbgVEbB8LyrTvGDZtp+pqYD 5DGRV2AIT4mUjgYbaVDkvOTpLUpo2Sv16V31d4XFFt3tKkJlw1xvrHpkQySK8nfBnQNz+Rbf5uf Q7DPdutlRqXClWqGmpSstI9ERYMlGs9zURxWGWHdOXQuf35xojIgeofA+6oBQvWSM3GvFBEgucC 24at+FzQpKoVXuD9DQXge8XeT6RAIZU/RfpQ2JGSGBhQdCmKR3VtIPQh3pN32h5h34i+ytT45Qd BRq8eFxaZfh8UP1PjcwTiSAQbJiBuWjFF4cC49TkdINnZxlPr9ZBrHZm1+SgoOR6+nuT3OyqRUy PE5qy+fi+cLp55tii8ct4x2yha6U5QCgGvYJA78f9YtNKpoGy X-Received: by 2002:a05:600c:8b55:b0:47a:814c:ee95 with SMTP id 5b1f17b1804b1-4805ce3f9bdmr76997565e9.12.1769440340827; Mon, 26 Jan 2026 07:12:20 -0800 (PST) X-Received: by 2002:a05:600c:8b55:b0:47a:814c:ee95 with SMTP id 5b1f17b1804b1-4805ce3f9bdmr76997215e9.12.1769440340429; Mon, 26 Jan 2026 07:12:20 -0800 (PST) Received: from ?IPV6:2a01:e0a:280:24f0:576b:abc6:6396:ed4a? ([2a01:e0a:280:24f0:576b:abc6:6396:ed4a]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4804dbc8424sm107447445e9.7.2026.01.26.07.12.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Jan 2026 07:12:19 -0800 (PST) Message-ID: Date: Mon, 26 Jan 2026 16:12:18 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] hw/adc: Fix out-of-bounds write in Aspeed ADC model To: Peter Maydell Cc: qemu-devel@nongnu.org, qemu-arm@nongnu.org, Steven Lee , Troy Lee , Jamin Lin , Andrew Jeffery , Joel Stanley , Elhrj Saad , Michael Tokarev References: <20260126141820.719492-1-clg@redhat.com> From: =?UTF-8?Q?C=C3=A9dric_Le_Goater?= Autocrypt: addr=clg@redhat.com; keydata= xsFNBFu8o3UBEADP+oJVJaWm5vzZa/iLgpBAuzxSmNYhURZH+guITvSySk30YWfLYGBWQgeo 8NzNXBY3cH7JX3/a0jzmhDc0U61qFxVgrPqs1PQOjp7yRSFuDAnjtRqNvWkvlnRWLFq4+U5t yzYe4SFMjFb6Oc0xkQmaK2flmiJNnnxPttYwKBPd98WfXMmjwAv7QfwW+OL3VlTPADgzkcqj 53bfZ4VblAQrq6Ctbtu7JuUGAxSIL3XqeQlAwwLTfFGrmpY7MroE7n9Rl+hy/kuIrb/TO8n0 ZxYXvvhT7OmRKvbYuc5Jze6o7op/bJHlufY+AquYQ4dPxjPPVUT/DLiUYJ3oVBWFYNbzfOrV RxEwNuRbycttMiZWxgflsQoHF06q/2l4ttS3zsV4TDZudMq0TbCH/uJFPFsbHUN91qwwaN/+ gy1j7o6aWMz+Ib3O9dK2M/j/O/Ube95mdCqN4N/uSnDlca3YDEWrV9jO1mUS/ndOkjxa34ia 70FjwiSQAsyIwqbRO3CGmiOJqDa9qNvd2TJgAaS2WCw/TlBALjVQ7AyoPEoBPj31K74Wc4GS Rm+FSch32ei61yFu6ACdZ12i5Edt+To+hkElzjt6db/UgRUeKfzlMB7PodK7o8NBD8outJGS tsL2GRX24QvvBuusJdMiLGpNz3uqyqwzC5w0Fd34E6G94806fwARAQABzSJDw6lkcmljIExl IEdvYXRlciA8Y2xnQHJlZGhhdC5jb20+wsGRBBMBCAA7FiEEoPZlSPBIlev+awtgUaNDx8/7 7KEFAmTLlVECGwMFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgkQUaNDx8/77KG0eg// S0zIzTcxkrwJ/9XgdcvVTnXLVF9V4/tZPfB7sCp8rpDCEseU6O0TkOVFoGWM39sEMiQBSvyY lHrP7p7E/JYQNNLh441MfaX8RJ5Ul3btluLapm8oHp/vbHKV2IhLcpNCfAqaQKdfk8yazYhh EdxTBlzxPcu+78uE5fF4wusmtutK0JG0sAgq0mHFZX7qKG6LIbdLdaQalZ8CCFMKUhLptW71 xe+aNrn7hScBoOj2kTDRgf9CE7svmjGToJzUxgeh9mIkxAxTu7XU+8lmL28j2L5uNuDOq9vl hM30OT+pfHmyPLtLK8+GXfFDxjea5hZLF+2yolE/ATQFt9AmOmXC+YayrcO2ZvdnKExZS1o8 VUKpZgRnkwMUUReaF/mTauRQGLuS4lDcI4DrARPyLGNbvYlpmJWnGRWCDguQ/LBPpbG7djoy k3NlvoeA757c4DgCzggViqLm0Bae320qEc6z9o0X0ePqSU2f7vcuWN49Uhox5kM5L86DzjEQ RHXndoJkeL8LmHx8DM+kx4aZt0zVfCHwmKTkSTQoAQakLpLte7tWXIio9ZKhUGPv/eHxXEoS 0rOOAZ6np1U/xNR82QbF9qr9TrTVI3GtVe7Vxmff+qoSAxJiZQCo5kt0YlWwti2fFI4xvkOi V7lyhOA3+/3oRKpZYQ86Frlo61HU3r6d9wzOwU0EW7yjdQEQALyDNNMw/08/fsyWEWjfqVhW pOOrX2h+z4q0lOHkjxi/FRIRLfXeZjFfNQNLSoL8j1y2rQOs1j1g+NV3K5hrZYYcMs0xhmrZ KXAHjjDx7FW3sG3jcGjFW5Xk4olTrZwFsZVUcP8XZlArLmkAX3UyrrXEWPSBJCXxDIW1hzwp bV/nVbo/K9XBptT/wPd+RPiOTIIRptjypGY+S23HYBDND3mtfTz/uY0Jytaio9GETj+fFis6 TxFjjbZNUxKpwftu/4RimZ7qL+uM1rG1lLWc9SPtFxRQ8uLvLOUFB1AqHixBcx7LIXSKZEFU CSLB2AE4wXQkJbApye48qnZ09zc929df5gU6hjgqV9Gk1rIfHxvTsYltA1jWalySEScmr0iS YBZjw8Nbd7SxeomAxzBv2l1Fk8fPzR7M616dtb3Z3HLjyvwAwxtfGD7VnvINPbzyibbe9c6g LxYCr23c2Ry0UfFXh6UKD83d5ybqnXrEJ5n/t1+TLGCYGzF2erVYGkQrReJe8Mld3iGVldB7 JhuAU1+d88NS3aBpNF6TbGXqlXGF6Yua6n1cOY2Yb4lO/mDKgjXd3aviqlwVlodC8AwI0Sdu jWryzL5/AGEU2sIDQCHuv1QgzmKwhE58d475KdVX/3Vt5I9kTXpvEpfW18TjlFkdHGESM/Jx IqVsqvhAJkalABEBAAHCwV8EGAECAAkFAlu8o3UCGwwACgkQUaNDx8/77KEhwg//WqVopd5k 8hQb9VVdk6RQOCTfo6wHhEqgjbXQGlaxKHoXywEQBi8eULbeMQf5l4+tHJWBxswQ93IHBQjK yKyNr4FXseUI5O20XVNYDJZUrhA4yn0e/Af0IX25d94HXQ5sMTWr1qlSK6Zu79lbH3R57w9j hQm9emQEp785ui3A5U2Lqp6nWYWXz0eUZ0Tad2zC71Gg9VazU9MXyWn749s0nXbVLcLS0yop s302Gf3ZmtgfXTX/W+M25hiVRRKCH88yr6it+OMJBUndQVAA/fE9hYom6t/zqA248j0QAV/p LHH3hSirE1mv+7jpQnhMvatrwUpeXrOiEw1nHzWCqOJUZ4SY+HmGFW0YirWV2mYKoaGO2YBU wYF7O9TI3GEEgRMBIRT98fHa0NPwtlTktVISl73LpgVscdW8yg9Gc82oe8FzU1uHjU8b10lU XOMHpqDDEV9//r4ZhkKZ9C4O+YZcTFu+mvAY3GlqivBNkmYsHYSlFsbxc37E1HpTEaSWsGfA HQoPn9qrDJgsgcbBVc1gkUT6hnxShKPp4PlsZVMNjvPAnr5TEBgHkk54HQRhhwcYv1T2QumQ izDiU6iOrUzBThaMhZO3i927SG2DwWDVzZltKrCMD1aMPvb3NU8FOYRhNmIFR3fcalYr+9gD uVKe8BVz4atMOoktmt0GWTOC8P4= In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: JYsseMAaM3MVkPPAWk_kbD7WsagGVA5Nx1l8VOARDQ0_1769440341 X-Mimecast-Originator: redhat.com Content-Language: en-US, fr Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.129.124; envelope-from=clg@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org Sender: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org On 1/26/26 15:30, Peter Maydell wrote: > On Mon, 26 Jan 2026 at 14:18, Cédric Le Goater wrote: >> >> The 'regs' array has ASPEED_ADC_NR_REGS (52) elements, while the >> memory region covers offsets 0x00-0xFC. The aspeed_adc_engine_write() >> function has an out-of-bounds write vulnerability when accessing >> unimplemented registers. >> >> Fix this by using 'return' instead of 'break' in the default case, >> which prevents execution from reaching the s->regs[reg] assignment for >> unimplemented registers. >> >> Reported-by: Elhrj Saad >> Fixes: 5857974d5d11 ("hw/adc: Add basic Aspeed ADC model") >> Signed-off-by: Cédric Le Goater > > Seems like a good candidate for Cc: qemu-stable@nongnu.org ? Yes. Cc: qemu-stable@nongnu.org Thanks, C.