From: =?UTF-8?Q?Christian_K=c3=b6nig?= Subject: Re: [PATCH 3/3] drm/amdgpu: move cache window setup after power and clock resume Date: Tue, 10 Jul 2018 09:13:31 +0200 Message-ID: References: <20180709161138.5319-1-leo.liu@amd.com> <20180709161138.5319-3-leo.liu@amd.com> Reply-To: christian.koenig-5C7GfCeVMHo@public.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1863935375==" Return-path: In-Reply-To: Content-Language: en-US List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: "Deucher, Alexander" , "Liu, Leo" , "amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" This is a multi-part message in MIME format. --===============1863935375== Content-Type: multipart/alternative; boundary="------------85FBE5D61700115AF1D275B5" Content-Language: en-US This is a multi-part message in MIME format. --------------85FBE5D61700115AF1D275B5 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit Looks like the patches should be reordered, e.g. patch #2 should be the last. Apart from that Reviewed-by: Christian König . Regards, Christian. Am 09.07.2018 um 18:54 schrieb Deucher, Alexander: > > Series is: > > Reviewed-by: Alex Deucher > > ------------------------------------------------------------------------ > *From:* amd-gfx on behalf of > Leo Liu > *Sent:* Monday, July 9, 2018 12:11:38 PM > *To:* amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org > *Cc:* Liu, Leo > *Subject:* [PATCH 3/3] drm/amdgpu: move cache window setup after power > and clock resume > To make register read/write reliable. Along with the previous patch, > VCN will work with dpm disabled case. > > Signed-off-by: Leo Liu > --- >  drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c | 4 ++-- >  1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c > b/drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c > index b82c92084b6f..ca4265bc10b9 100644 > --- a/drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c > +++ b/drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c > @@ -600,12 +600,12 @@ static int vcn_v1_0_start(struct amdgpu_device > *adev) >          /* disable byte swapping */ >          lmi_swap_cntl = 0; > > -       vcn_v1_0_mc_resume(adev); > - >          vcn_1_0_disable_static_power_gating(adev); >          /* disable clock gating */ >          vcn_v1_0_disable_clock_gating(adev); > > +       vcn_v1_0_mc_resume(adev); > + >          /* disable interupt */ >          WREG32_P(SOC15_REG_OFFSET(UVD, 0, mmUVD_MASTINT_EN), 0, >                          ~UVD_MASTINT_EN__VCPU_EN_MASK); > -- > 2.17.1 > > _______________________________________________ > amd-gfx mailing list > amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx > > > _______________________________________________ > amd-gfx mailing list > amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx --------------85FBE5D61700115AF1D275B5 Content-Type: text/html; charset=windows-1252 Content-Transfer-Encoding: 8bit
Looks like the patches should be reordered, e.g. patch #2 should be the last.

Apart from that Reviewed-by: Christian König <christian.koenig-5C7GfCeVMHo@public.gmane.org>.

Regards,
Christian.

Am 09.07.2018 um 18:54 schrieb Deucher, Alexander:

Series is:

Reviewed-by: Alex Deucher <alexander.deucher-5C7GfCeVMHo@public.gmane.org>


From: amd-gfx <amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org> on behalf of Leo Liu <leo.liu-5C7GfCeVMHo@public.gmane.org>
Sent: Monday, July 9, 2018 12:11:38 PM
To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Cc: Liu, Leo
Subject: [PATCH 3/3] drm/amdgpu: move cache window setup after power and clock resume
 
To make register read/write reliable. Along with the previous patch,
VCN will work with dpm disabled case.

Signed-off-by: Leo Liu <leo.liu-5C7GfCeVMHo@public.gmane.org>
---
 drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c b/drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c
index b82c92084b6f..ca4265bc10b9 100644
--- a/drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c
@@ -600,12 +600,12 @@ static int vcn_v1_0_start(struct amdgpu_device *adev)
         /* disable byte swapping */
         lmi_swap_cntl = 0;
 
-       vcn_v1_0_mc_resume(adev);
-
         vcn_1_0_disable_static_power_gating(adev);
         /* disable clock gating */
         vcn_v1_0_disable_clock_gating(adev);
 
+       vcn_v1_0_mc_resume(adev);
+
         /* disable interupt */
         WREG32_P(SOC15_REG_OFFSET(UVD, 0, mmUVD_MASTINT_EN), 0,
                         ~UVD_MASTINT_EN__VCPU_EN_MASK);
--
2.17.1

_______________________________________________
amd-gfx mailing list
amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx


_______________________________________________
amd-gfx mailing list
amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

--------------85FBE5D61700115AF1D275B5-- --===============1863935375== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KYW1kLWdmeCBt YWlsaW5nIGxpc3QKYW1kLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbWQtZ2Z4Cg== --===============1863935375==--