Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A014FC433E1 for ; Sat, 15 Aug 2020 11:18:50 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 77ACC22EBF for ; Sat, 15 Aug 2020 11:18:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 77ACC22EBF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k6uCr-0005hl-Ax; Sat, 15 Aug 2020 11:18:37 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k6uCq-0005hg-8b for xen-devel@lists.xenproject.org; Sat, 15 Aug 2020 11:18:36 +0000 X-Inumbo-ID: 731642b2-9085-4a05-bce2-da9a39a88943 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 731642b2-9085-4a05-bce2-da9a39a88943; Sat, 15 Aug 2020 11:18:35 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id E8160B73B; Sat, 15 Aug 2020 11:18:57 +0000 (UTC) Subject: Re: [PATCH] qemu-trad: remove Xen path dependencies To: xen-devel@lists.xenproject.org Cc: ian.jackson@eu.citrix.com References: <20200715090140.7590-1-jgross@suse.com> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: Date: Sat, 15 Aug 2020 13:18:33 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200715090140.7590-1-jgross@suse.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 15.07.20 11:01, Juergen Gross wrote: > xen-hhoks.mak contains hard wired paths for the used libraries of > qemu-trad. Replace those by the make variables from Xen's Rules.mk, > which is already included. > > This in turn removes the need to add the runtime link paths of the > libraries the directly used libraries depend on. > > Signed-off-by: Juergen Gross Ping? Juergen > --- > xen-hooks.mak | 18 ++++-------------- > 1 file changed, 4 insertions(+), 14 deletions(-) > > diff --git a/xen-hooks.mak b/xen-hooks.mak > index a68eba3c..2689db0f 100644 > --- a/xen-hooks.mak > +++ b/xen-hooks.mak > @@ -1,10 +1,8 @@ > -CPPFLAGS+= -I$(XEN_ROOT)/tools/libs/toollog/include > -CPPFLAGS+= -I$(XEN_ROOT)/tools/libs/evtchn/include > -CPPFLAGS+= -I$(XEN_ROOT)/tools/libs/gnttab/include > +XEN_LIBS = evtchn gnttab ctrl guest store > + > CPPFLAGS+= -DXC_WANT_COMPAT_MAP_FOREIGN_API > CPPFLAGS+= -DXC_WANT_COMPAT_DEVICEMODEL_API > -CPPFLAGS+= -I$(XEN_ROOT)/tools/libxc/include > -CPPFLAGS+= -I$(XEN_ROOT)/tools/xenstore/include > +CPPFLAGS += $(foreach lib,$(XEN_LIBS),$(CFLAGS_libxen$(lib))) > CPPFLAGS+= -I$(XEN_ROOT)/tools/include > > SSE2 := $(call cc-option,-msse2,) > @@ -22,15 +20,7 @@ endif > > CFLAGS += $(CMDLINE_CFLAGS) > > -LIBS += -L$(XEN_ROOT)/tools/libs/evtchn -lxenevtchn > -LIBS += -L$(XEN_ROOT)/tools/libs/gnttab -lxengnttab > -LIBS += -L$(XEN_ROOT)/tools/libxc -lxenctrl -lxenguest > -LIBS += -L$(XEN_ROOT)/tools/xenstore -lxenstore > -LIBS += -Wl,-rpath-link=$(XEN_ROOT)/tools/libs/toollog > -LIBS += -Wl,-rpath-link=$(XEN_ROOT)/tools/libs/toolcore > -LIBS += -Wl,-rpath-link=$(XEN_ROOT)/tools/libs/call > -LIBS += -Wl,-rpath-link=$(XEN_ROOT)/tools/libs/foreignmemory > -LIBS += -Wl,-rpath-link=$(XEN_ROOT)/tools/libs/devicemodel > +LIBS += $(foreach lib,$(XEN_LIBS),$(LDLIBS_libxen$(lib))) > > LDFLAGS := $(CFLAGS) $(LDFLAGS) > >