From: "cron2 (Code Review)" Date: Mon, 30 Jun 2025 17:01:57 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="A3ec7BOYzGE="; charset=UTF-8 Subject: [Openvpn-devel] [XS] Change in openvpn[master]: packet_id: Fix build with --disable-debug List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: flichtenheld , plaisthos Cc: openvpn-devel --A3ec7BOYzGE= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable cron2 has uploaded a new patch set (#2) to the change originally created by= flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1071?usp=3Demail ) The following approvals got outdated and were removed: Code-Review+2 by cron2 Change subject: packet_id: Fix build with --disable-debug ...................................................................... packet_id: Fix build with --disable-debug Broken since commit bc62a9a02cb7365a678bcd3f2faf537a420cc5a0 "Add methods to read/write packet ids for epoch data" Change-Id: I3bed9c7aafee8e62ddae14c0d3e21cf4c146a37c Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering Message-Id: <20250630164207.10477-1-gert@...1296...> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg32= 013.html Signed-off-by: Gert Doering --- M src/openvpn/packet_id.c 1 file changed, 2 insertions(+), 3 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/71/1071/2 diff --git a/src/openvpn/packet_id.c b/src/openvpn/packet_id.c index c8dae32..76a81c6 100644 --- a/src/openvpn/packet_id.c +++ b/src/openvpn/packet_id.c @@ -673,6 +673,8 @@ gc_free(&gc); } +#endif /* ifdef ENABLE_DEBUG */ + uint16_t packet_id_read_epoch(struct packet_id_net *pin, struct buffer *buf) { @@ -711,6 +713,3 @@ return buf_write(buf, &net_id, sizeof(net_id)); } - - -#endif /* ifdef ENABLE_DEBUG */ -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1071?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I3bed9c7aafee8e62ddae14c0d3e21cf4c146a37c Gerrit-Change-Number: 1071 Gerrit-PatchSet: 2 Gerrit-Owner: flichtenheld Gerrit-Reviewer: cron2 Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-MessageType: newpatchset --A3ec7BOYzGE= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

cron2 uploaded patch set #2 to the change originally cr= eated by flichtenheld.

View Change

The following approvals got outd= ated and were removed: Code-Review+2 by cron2

packet_id: Fix build with --disable-debug

Bro= ken since commit
bc62a9a02cb7365a678bcd3f2faf537a420cc5a0
"Add m= ethods to read/write packet ids for epoch data"

Change-Id: I3be= d9c7aafee8e62ddae14c0d3e21cf4c146a37c
Signed-off-by: Frank Lichtenheld &= lt;frank@...2641...>
Acked-by: Gert Doering <gert@...1296...>Message-Id: <20250630164207.10477-1-gert@...1296...>
URL: https:= //www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg32013.htmlSigned-off-by: Gert Doering <gert@...1296...>
---
M src/openvp= n/packet_id.c
1 file changed, 2 insertions(+), 3 deletions(-)

=
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/71/1071/2
diff --git a/src/openvpn/packet_id.c b/src/openvpn/packet_id.cindex c8dae32..76a81c6 100644
--- a/src/openvpn/pac= ket_id.c
+++ b/src/openvpn/packet_id.c
@@ -= 673,6 +673,8 @@
gc_free(&gc);
}

+#en= dif /* ifdef ENABLE_DEBUG */
+
uint16_t
packet_id_read_epoch(s= truct packet_id_net *pin, struct buffer *buf)
{
= @@ -711,6 +713,3 @@

return buf= _write(buf, &net_id, sizeof(net_id));
}
-

-
-#en= dif /* ifdef ENABLE_DEBUG */

To view, v= isit cha= nge 1071. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I3bed9c7aafee8e62ddae14c0d3e= 21cf4c146a37c
Gerrit-Change-Number: 1071
Gerrit-PatchSet: 2
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-MessageType: newpatchset
--A3ec7BOYzGE=--