Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3B042C0015E for ; Tue, 15 Aug 2023 12:08:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sp6CsQz1xeMy1VcH+UhG5sIR7Iqo7ufY0qjBSrtPCYw=; b=lJHym/ysUUcrpS Y4FJVtpbDDwvw2EfGHyZFBNA0ClgtEjgYdDvDNQL5GHwwguBnvO9BdBTUkRGwn8dZHMmzKJu5Xvn+ FWc5/5BFkXJrFmmG1O4dx1EjPxKuHPYBkEmfsK9XSaunIIbRmu2AnmagjAuVmpl8j4F6eAFq4lAdt wnElULoSDhyVW0B6711Sy+BiTOFe+E73lyIfGdPkc80B4/mgLfl4at1wF0ZkJLiHB0sCc5JoHeSdF MNNoQ47gMxTL+ExeqTGsP6F8JjQlP+JW5HlFiqtGCO5GTo9Din3ScgcKLyzI67KW9XxwDTTGIP5cm isRwVaBEcibxLyftUjeA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qVsqK-001a2e-1p; Tue, 15 Aug 2023 12:08:12 +0000 Received: from mgamail.intel.com ([192.55.52.151]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qVsqH-001a2A-0s for linux-arm-kernel@lists.infradead.org; Tue, 15 Aug 2023 12:08:10 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1692101289; x=1723637289; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=ymu5KxOsSMsv+0OCO8Cv1JjkgOfyo4Mp0q+oXVdwK5U=; b=V3bh0BRBTM7OpGIQnztpBNHY4fVxU8bRMUr4OJNF1wA49y89UeodbONs /A8hGpBt6AVXVNqMhvqMtdShtbpR1I3rq9yUy3GY++kQM2ThdtODBEBmR wW7DqRRwMDu2cs2W3126z+2rkOZ/mrJZKqOLScIlIaJt95BhX0vcp8KRE 8QL/Ns9DrI2h1vEqla9jyeEYjUx+YGuHAc2p0zkvVH6pwAeAT3CJ7l8Ot JmLZIpliqDi9nOxnZxrGnfca9ye8zvsVPuzwgSt5BhG8JUdiTz7eU4jf/ V11HwIddMXDyHajQ8Rw9gwKTQKnvrZs9DLSxVALOdlDsRpbT2jHy2Gb7p w==; X-IronPort-AV: E=McAfee;i="6600,9927,10803"; a="352588579" X-IronPort-AV: E=Sophos;i="6.01,174,1684825200"; d="scan'208";a="352588579" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Aug 2023 05:08:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10803"; a="733820899" X-IronPort-AV: E=Sophos;i="6.01,174,1684825200"; d="scan'208";a="733820899" Received: from ahunter6-mobl1.ger.corp.intel.com (HELO [10.0.2.15]) ([10.252.52.51]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Aug 2023 05:07:57 -0700 Message-ID: Date: Tue, 15 Aug 2023 15:07:52 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.14.0 Subject: Re: [PATCH] mmc: sdhci-esdhc-imx: improve ESDHC_FLAG_ERR010450 Content-Language: en-US To: Giulio Benetti , Haibo Chen , Ulf Hansson , Shawn Guo , Sascha Hauer , Fabio Estevam , NXP Linux Team Cc: Pengutronix Kernel Team , linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Jim Reinhart , James Autry , Matthew Maron References: <20230811214853.8623-1-giulio.benetti@benettiengineering.com> From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki In-Reply-To: <20230811214853.8623-1-giulio.benetti@benettiengineering.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230815_050809_356278_77C110AA X-CRM114-Status: GOOD ( 20.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 12/08/23 00:48, Giulio Benetti wrote: > Errata ERR010450 only shows up if voltage is 1.8V, but if the device is > supplied by 3v3 the errata can be ignored. So let's check for if quirk > SDHCI_QUIRK2_NO_1_8_V is defined or not before limiting the frequency. > > Sponsored by: Tekvox Inc. > Cc: Jim Reinhart > Cc: James Autry > Cc: Matthew Maron > Signed-off-by: Giulio Benetti Haibo Chen, can we get an Acked-by from you? > --- > drivers/mmc/host/sdhci-esdhc-imx.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c b/drivers/mmc/host/sdhci-esdhc-imx.c > index eebf94604a7f..cddecc1e1ac2 100644 > --- a/drivers/mmc/host/sdhci-esdhc-imx.c > +++ b/drivers/mmc/host/sdhci-esdhc-imx.c > @@ -171,8 +171,8 @@ > #define ESDHC_FLAG_HS400 BIT(9) > /* > * The IP has errata ERR010450 > - * uSDHC: Due to the I/O timing limit, for SDR mode, SD card clock can't > - * exceed 150MHz, for DDR mode, SD card clock can't exceed 45MHz. > + * uSDHC: At 1.8V due to the I/O timing limit, for SDR mode, SD card > + * clock can't exceed 150MHz, for DDR mode, SD card clock can't exceed 45MHz. > */ > #define ESDHC_FLAG_ERR010450 BIT(10) > /* The IP supports HS400ES mode */ > @@ -961,7 +961,8 @@ static inline void esdhc_pltfm_set_clock(struct sdhci_host *host, > | ESDHC_CLOCK_MASK); > sdhci_writel(host, temp, ESDHC_SYSTEM_CONTROL); > > - if (imx_data->socdata->flags & ESDHC_FLAG_ERR010450) { > + if ((imx_data->socdata->flags & ESDHC_FLAG_ERR010450) && > + (!(host->quirks2 & SDHCI_QUIRK2_NO_1_8_V))) { > unsigned int max_clock; > > max_clock = imx_data->is_ddr ? 45000000 : 150000000; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel