From: "cron2 (Code Review)" Date: Tue, 18 Jun 2024 16:37:11 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="mCcGdT/6/Ck="; charset=UTF-8 Subject: [Openvpn-devel] [XS] Change in openvpn[master]: Remove "experimental" denotation for --fast-io List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: flichtenheld , plaisthos Cc: openvpn-devel --mCcGdT/6/Ck= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable cron2 has uploaded a new patch set (#2) to the change originally created by= flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/664?usp=3Demail ) The following approvals got outdated and were removed: Code-Review+2 by plaisthos Change subject: Remove "experimental" denotation for --fast-io ...................................................................... Remove "experimental" denotation for --fast-io This option is very old (from SVN days) and has been used by Access Server for many years. I don't think it makes sense to claim that it is "experimental" at this point. Change-Id: I913bb70c5e527e78e7cdb43110e23a8944f35a22 Signed-off-by: Frank Lichtenheld Acked-by: Arne Schwabe Message-Id: <20240618120156.4836-1-gert@...1296...> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg28= 772.html Signed-off-by: Gert Doering --- M doc/man-sections/generic-options.rst M src/openvpn/options.c 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/64/664/2 diff --git a/doc/man-sections/generic-options.rst b/doc/man-sections/generi= c-options.rst index f8a0f48..eb9cf28 100644 --- a/doc/man-sections/generic-options.rst +++ b/doc/man-sections/generic-options.rst @@ -215,7 +215,7 @@ are supported by OpenSSL. --fast-io - (Experimental) Optimize TUN/TAP/UDP I/O writes by avoiding a call to + Optimize TUN/TAP/UDP I/O writes by avoiding a call to poll/epoll/select prior to the write operation. The purpose of such a call would normally be to block until the device or socket is ready to accept the write. Such blocking is unnecessary on some platforms which diff --git a/src/openvpn/options.c b/src/openvpn/options.c index abcde89..f2c7536 100644 --- a/src/openvpn/options.c +++ b/src/openvpn/options.c @@ -268,7 +268,7 @@ #if ENABLE_IP_PKTINFO "--multihome : Configure a multi-homed UDP server.\n" #endif - "--fast-io : (experimental) Optimize TUN/TAP/UDP writes.\n" + "--fast-io : Optimize TUN/TAP/UDP writes.\n" "--remap-usr1 s : On SIGUSR1 signals, remap signal (s=3D'SIGHUP' or '= SIGTERM').\n" "--persist-tun : Keep tun/tap device open across SIGUSR1 or --ping-r= estart.\n" "--persist-remote-ip : Keep remote IP address across SIGUSR1 or --ping= -restart.\n" --=20 To view, visit http://gerrit.openvpn.net/c/openvpn/+/664?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I913bb70c5e527e78e7cdb43110e23a8944f35a22 Gerrit-Change-Number: 664 Gerrit-PatchSet: 2 Gerrit-Owner: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-MessageType: newpatchset --mCcGdT/6/Ck= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

cron2 uploaded patch set #2 to the change originally cr= eated by flichtenheld.

View Change

The following approvals got outda= ted and were removed: Code-Review+2 by plaisthos

Remove "experimental" denotation for -=
-fast-io

This option is very old (from SVN days) and has been
use= d by Access Server for many years. I don't think it
makes sense to c= laim that it is "experimental" at this
point.

Change-Id= : I913bb70c5e527e78e7cdb43110e23a8944f35a22
Signed-off-by: Frank Lichten= held <frank@...2641...>
Acked-by: Arne Schwabe <arne-openvpn@...1186...= .1227...>
Message-Id: <20240618120156.4836-1-gert@...1296...>URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg= 28772.html
Signed-off-by: Gert Doering <gert@...1296...>
---M doc/man-sections/generic-options.rst
M src/openvpn/options.c
2 fil= es changed, 2 insertions(+), 2 deletions(-)

git pull ssh://gerrit=
.openvpn.net:29418/openvpn refs/changes/64/664/2
diff --git a/doc/m=
an-sections/generic-options.rst b/doc/man-sections/generic-options.rst
index f8a0f48..eb9cf28 100644
--- a/doc/man-sec= tions/generic-options.rst
+++ b/doc/man-sections/generic-op= tions.rst
@@ -215,7 +215,7 @@
are suppor= ted by OpenSSL.

--fast-io
- (Experimental) Optimize TUN/TAP/UD= P I/O writes by avoiding a call to

+ Optimize TUN/TAP/UDP I/O writes by avoiding a call to
poll/epoll/select prior to the write operation. The purpose = of such a
call would normally be to block until the devi= ce or socket is ready to
accept the write. Such blocking= is unnecessary on some platforms which
diff --git a/src/op= envpn/options.c b/src/openvpn/options.c
index abcde89..f2c7= 536 100644
--- a/src/openvpn/options.c
+++ = b/src/openvpn/options.c
@@ -268,7 +268,7 @@
#if ENABLE_IP_PKTINFO

"--multihome : Config= ure a multi-homed UDP server.\n"
#endif
- "--fast-io : (experi= mental) Optimize TUN/TAP/UDP writes.\n"
+ "--fast-io : Optimize TUN/TAP/UDP w= rites.\n"
"--remap-usr1 s : On SIGUSR1 sign= als, remap signal (s=3D'SIGHUP' or 'SIGTERM').\n"
"--persist-tun : Keep tun/tap device open across SI= GUSR1 or --ping-restart.\n"
"--persist-remot= e-ip : Keep remote IP address across SIGUSR1 or --ping-restart.\n"


To view, visit change 664. To unsubscribe, or f= or help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I913bb70c5e527e78e7cdb43110e= 23a8944f35a22
Gerrit-Change-Number: 664
Gerrit-PatchSet: 2
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-MessageType: newpatchset
--mCcGdT/6/Ck=--