Message-ID: Date: Thu, 23 Jun 2022 20:39:47 +0200 MIME-Version: 1.0 Content-Language: en-US References: <20200106080426.40701-1-list@...1798...> From: David Sommerseth In-Reply-To: <20200106080426.40701-1-list@...1798...> Subject: Re: [Openvpn-devel] [PATCH 1/1] configure.ac: replace set with env List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit To: Christian Hesse Cc: openvpn-devel On 06/01/2020 09:04, Christian Hesse wrote: > From: Christian Hesse > > The shell builtin `set` produces different output for different shells: > > bash$ set | grep '^TERM=' > TERM=xterm > dash$ set | grep '^TERM=' > TERM='xterm' > > This may break reproducible builds depending on what shell is used. > > Let's replace `set` with `env`, which is a real command and always > produces identical output. Hi, Spotted this one now, lingering for way too long. And it looked trivial. Except it doesn't give the expected outcome on my RHEL-8 machine. The CONFIGURE_DEFINES macro in config.h ends up empty. Reverting this patch alone, and it comes back again. So, I'm sorry, I can't ack this one. -- kind regards, David Sommerseth OpenVPN Inc