From: =?UTF-8?Q?Christian_K=c3=b6nig?= Subject: Re: [PATCH 3/3] drm/amdgpu: Warn and update pin_size values when destroying a pinned BO Date: Thu, 12 Jul 2018 09:41:05 +0200 Message-ID: References: <20180711162342.14835-1-michel@daenzer.net> <20180711162342.14835-4-michel@daenzer.net> Reply-To: christian.koenig-5C7GfCeVMHo@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180711162342.14835-4-michel-otUistvHUpPR7s880joybQ@public.gmane.org> Content-Language: en-US List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: =?UTF-8?Q?Michel_D=c3=a4nzer?= , amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org QW0gMTEuMDcuMjAxOCB1bSAxODoyMyBzY2hyaWViIE1pY2hlbCBEw6RuemVyOgo+IEZyb206IE1p Y2hlbCBEw6RuemVyIDxtaWNoZWwuZGFlbnplckBhbWQuY29tPgo+Cj4gVGhpcyBzaG91bGRuJ3Qg aGFwcGVuLCBidXQgaWYgaXQgZG9lcywgd2UnbGwgZ2V0IGEgYmFja3RyYWNlIG9mIHRoZQo+IGNh bGxlciwgYW5kIHVwZGF0ZSB0aGUgcGluX3NpemUgdmFsdWVzIGFzIG5lZWRlZC4KPgo+IFNpZ25l ZC1vZmYtYnk6IE1pY2hlbCBEw6RuemVyIDxtaWNoZWwuZGFlbnplckBhbWQuY29tPgo+IC0tLQo+ ICAgZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X29iamVjdC5jIHwgMzcgKysrKysr KysrKysrKysrKystLS0tLQo+ICAgMSBmaWxlIGNoYW5nZWQsIDI5IGluc2VydGlvbnMoKyksIDgg ZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUv YW1kZ3B1X29iamVjdC5jIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X29iamVj dC5jCj4gaW5kZXggMjRkNmZiODdmM2I2Li45OTQ1ZjA4MGVhN2EgMTAwNjQ0Cj4gLS0tIGEvZHJp dmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X29iamVjdC5jCj4gKysrIGIvZHJpdmVycy9n cHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X29iamVjdC5jCj4gQEAgLTYzLDEwICs2MywzOCBAQCBz dGF0aWMgYm9vbCBhbWRncHVfbmVlZF9iYWNrdXAoc3RydWN0IGFtZGdwdV9kZXZpY2UgKmFkZXYp Cj4gICAJcmV0dXJuIHRydWU7Cj4gICB9Cj4gICAKPiArLyoqCj4gKyAqIGFtZGdwdV9ib19zdWJ0 cmFjdF9waW5fc2l6ZSAtIFJlbW92ZSBCTyBmcm9tIHBpbiBzaXplIGFjY291bnRpbmcKPiArICoK PiArICogQGJvOiAmYW1kZ3B1X2JvIGJ1ZmZlciBvYmplY3QKPiArICoKPiArICogVGhpcyBmdW5j dGlvbiBpcyBjYWxsZWQgd2hlbiBhIEJPIHN0b3BzIGJlaW5nIHBpbm5lZCwgYW5kIHVwZGF0ZXMg dGhlCj4gKyAqICZhbWRncHVfZGV2aWNlIHBpbl9zaXplIHZhbHVlcyBhY2NvcmRpbmdseS4KPiAr ICovCj4gK3N0YXRpYyB2b2lkIGFtZGdwdV9ib19zdWJ0cmFjdF9waW5fc2l6ZShzdHJ1Y3QgYW1k Z3B1X2JvICpibykKPiArewo+ICsJc3RydWN0IGFtZGdwdV9kZXZpY2UgKmFkZXYgPSBhbWRncHVf dHRtX2FkZXYoYm8tPnRiby5iZGV2KTsKPiArCj4gKwlpZiAoYm8tPnRiby5tZW0ubWVtX3R5cGUg PT0gVFRNX1BMX1ZSQU0pIHsKPiArCQlhdG9taWM2NF9zdWIoYW1kZ3B1X2JvX3NpemUoYm8pLCAm YWRldi0+dnJhbV9waW5fc2l6ZSk7Cj4gKwkJYXRvbWljNjRfc3ViKGFtZGdwdV9ib19zaXplKGJv KSAtCj4gKwkJCSAgICAgYW1kZ3B1X3ZyYW1fbWdyX2JvX2ludmlzaWJsZV9zaXplKGJvKSwKPiAr CQkJICAgICAmYWRldi0+dmlzaWJsZV9waW5fc2l6ZSk7Cj4gKwl9IGVsc2UgaWYgKGJvLT50Ym8u bWVtLm1lbV90eXBlID09IFRUTV9QTF9UVCkgewo+ICsJCWF0b21pYzY0X3N1YihhbWRncHVfYm9f c2l6ZShibyksICZhZGV2LT5nYXJ0X3Bpbl9zaXplKTsKPiArCX0KPiArfQo+ICsKPiAgIHN0YXRp YyB2b2lkIGFtZGdwdV90dG1fYm9fZGVzdHJveShzdHJ1Y3QgdHRtX2J1ZmZlcl9vYmplY3QgKnRi bykKPiAgIHsKPiAgIAlzdHJ1Y3QgYW1kZ3B1X2RldmljZSAqYWRldiA9IGFtZGdwdV90dG1fYWRl dih0Ym8tPmJkZXYpOwo+ICAgCXN0cnVjdCBhbWRncHVfYm8gKmJvID0gdHRtX3RvX2FtZGdwdV9i byh0Ym8pOwo+ICsJaW50IGk7Cj4gKwo+ICsJZm9yIChpID0gMDsgaSA8IGJvLT5wbGFjZW1lbnQu bnVtX3BsYWNlbWVudDsgaSsrKSB7Cj4gKwkJaWYgKFdBUk5fT05fT05DRShiby0+cGxhY2VtZW50 c1tpXS5mbGFncyAmIFRUTV9QTF9GTEFHX05PX0VWSUNUKSkKPiArCQkJYW1kZ3B1X2JvX3N1YnRy YWN0X3Bpbl9zaXplKGJvKTsKPiArCX0KClRoYXQgd291bGQgc3VidHJhY3QgdGhlIHZhbHVlcyBv bmNlIGZvciBlYWNoIHBsYWNlbWVudCB3aGljaCBpcyBub3QgCnNvbWV0aGluZyB3ZSB3YW50LiBJ IHdvdWxkIHJhdGhlciB0YWtlIGEgbG9vayBhdCBiby0+cGluX2NvdW50LgoKUmVnYXJkcywKQ2hy aXN0aWFuLgoKPiAgIAo+ICAgCWlmIChiby0+a2ZkX2JvKQo+ICAgCQlhbWRncHVfYW1ka2ZkX3Vu cmVzZXJ2ZV9zeXN0ZW1fbWVtb3J5X2xpbWl0KGJvKTsKPiBAQCAtOTY5LDE0ICs5OTcsNyBAQCBp bnQgYW1kZ3B1X2JvX3VucGluKHN0cnVjdCBhbWRncHVfYm8gKmJvKQo+ICAgCWlmIChiby0+cGlu X2NvdW50KQo+ICAgCQlyZXR1cm4gMDsKPiAgIAo+IC0JaWYgKGJvLT50Ym8ubWVtLm1lbV90eXBl ID09IFRUTV9QTF9WUkFNKSB7Cj4gLQkJYXRvbWljNjRfc3ViKGFtZGdwdV9ib19zaXplKGJvKSwg JmFkZXYtPnZyYW1fcGluX3NpemUpOwo+IC0JCWF0b21pYzY0X3N1YihhbWRncHVfYm9fc2l6ZShi bykgLQo+IC0JCQkgICAgIGFtZGdwdV92cmFtX21ncl9ib19pbnZpc2libGVfc2l6ZShibyksCj4g LQkJCSAgICAgJmFkZXYtPnZpc2libGVfcGluX3NpemUpOwo+IC0JfSBlbHNlIGlmIChiby0+dGJv Lm1lbS5tZW1fdHlwZSA9PSBUVE1fUExfVFQpIHsKPiAtCQlhdG9taWM2NF9zdWIoYW1kZ3B1X2Jv X3NpemUoYm8pLCAmYWRldi0+Z2FydF9waW5fc2l6ZSk7Cj4gLQl9Cj4gKwlhbWRncHVfYm9fc3Vi dHJhY3RfcGluX3NpemUoYm8pOwo+ICAgCj4gICAJZm9yIChpID0gMDsgaSA8IGJvLT5wbGFjZW1l bnQubnVtX3BsYWNlbWVudDsgaSsrKSB7Cj4gICAJCWJvLT5wbGFjZW1lbnRzW2ldLmxwZm4gPSAw OwoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KYW1kLWdm eCBtYWlsaW5nIGxpc3QKYW1kLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbWQtZ2Z4Cg==