Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 22192C35275 for ; Mon, 24 Jan 2022 21:28:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=2RxEb/ZOj+SCSUG9vjR/enP3Bcim2HK/XHzaiqRYalo=; b=1VB3Cc4AHGVEzlcc3cLeFUDXic a9U/LkgQn2S5uIpsQNtwiMymZ8CSB1B0x07q2cXetejn+V05syG2THpH5wmbo0ds0AIlMC7d7xNgT sHBz8ANJUIggIyDA+9Jl6eDBw6S8+gI6eWP5j2cHtEu+HfjjETj6byVxd39kmTxOVKbuKpKdqn97n aqD0xE5Z/VB2qB/KQcXH4MRcXVBZ7wcbGls0l8TXvAcIbHeDL6niKs17LVYYhqfucMD+S24mI11vJ gdLfSuKwtrEDey0rVgX6tYm3txs+Nh+MZEfSCf42wX9gHji1MtuoRPmlYk7MePuugICPw1vavydLi dlWc8JQw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nC6rr-005JQj-Ri; Mon, 24 Jan 2022 21:27:16 +0000 Received: from mail-il1-x133.google.com ([2607:f8b0:4864:20::133]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nC6ro-005JOv-Ao for linux-arm-kernel@lists.infradead.org; Mon, 24 Jan 2022 21:27:13 +0000 Received: by mail-il1-x133.google.com with SMTP id e8so15070254ilm.13 for ; Mon, 24 Jan 2022 13:27:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=U2OOTEeEVZfOH1K8JKszpYA1Lc7+2wsRJpO5eZWN2Ao=; b=PQmntUo/TBuELaF81KWI8+FByADPtTIvkCm1Q9vzpVA0Fu6JOT5pXI3aZnjyB1hgYr QrgL9W9w1C7vH7pZwmsoJTD9W7sTNxbvHWQix1DfG8XPjbBEbIDO/M05o9Y/Qp/zPLNZ o+KqNjTY2el8Mz+XwRykNM4wmPoRTyLqp/23U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=U2OOTEeEVZfOH1K8JKszpYA1Lc7+2wsRJpO5eZWN2Ao=; b=mE4cuKfyhDDMI9tSLRo47w2AB/GwW05y7LwJZIbg032KIKWAsWBI0bofocSESpmLgZ RVbGGNxLKUCzyBq5FgnxqBpJ7p0B/Yla16Dsttidw5gcQPVQcyyllYTA9KVg0TlYU2fL kAnfK8nbKeJZeqZ3WKrEKdo0Oup9JeJclWydqdJhN/au3zQHL7FbEC3m0GcyVDWhl1oS zUWG0h4zF4vFcn6VL9XSSEKCIYfZhcbDKUHK+JX/WUH3NOPYjk8QJ4zeTe1nmf0Z2cMz ssupI0qOtcI0zxf6KIxw4c8oyX2wLUPxpoay/oKBSkwihibM/ixLL5eOfMLHFwwznUjw 9h1Q== X-Gm-Message-State: AOAM531DttFNjAhWYn7//EAGY+ZBexWTctWL7CqV1Z8j0vVjpecJSSWf gzWW8EIpkLedt2SFXa2KLUDFVQ== X-Google-Smtp-Source: ABdhPJwiPWZl3jeukp9LXtarpTVJprj76cYGgmYJJfpDWLQ3lpreXhjBMCZEEyie4LWd53GTAFzbug== X-Received: by 2002:a05:6e02:1529:: with SMTP id i9mr9681422ilu.149.1643059630444; Mon, 24 Jan 2022 13:27:10 -0800 (PST) Received: from ?IPv6:2601:282:8200:4c:b48b:eb27:e282:37fe? ([2601:282:8200:4c:b48b:eb27:e282:37fe]) by smtp.gmail.com with ESMTPSA id n9sm8693321ilk.27.2022.01.24.13.27.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Jan 2022 13:27:10 -0800 (PST) Subject: Re: [PATCH v1 1/2] kselftest/arm64: Skip VL_INHERIT tests for unsupported vector types To: Mark Brown , Catalin Marinas , Will Deacon , Shuah Khan Cc: linux-arm-kernel@lists.infradead.org, linux-kselftest@vger.kernel.org, Shuah Khan References: <20220124175527.3260234-1-broonie@kernel.org> <20220124175527.3260234-2-broonie@kernel.org> From: Shuah Khan Message-ID: Date: Mon, 24 Jan 2022 14:27:07 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20220124175527.3260234-2-broonie@kernel.org> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220124_132712_417966_527E3C61 X-CRM114-Status: GOOD ( 20.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 1/24/22 10:55 AM, Mark Brown wrote: > Currently we unconditionally test the ability to set the vector length > inheritance flag via ptrace meaning that we generate false failures on > systems that don't support SVE when we attempt to set the vector length > there. Check the hwcap and mark the tests as skipped when it's not present. > > Fixes: 0ba1ce1e86052d ("selftests: arm64: Add coverage of ptrace flags for SVE VL inheritance") > Signed-off-by: Mark Brown > --- > tools/testing/selftests/arm64/fp/sve-ptrace.c | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/arm64/fp/sve-ptrace.c b/tools/testing/selftests/arm64/fp/sve-ptrace.c > index af798b9d232c..0cf78360c5bc 100644 > --- a/tools/testing/selftests/arm64/fp/sve-ptrace.c > +++ b/tools/testing/selftests/arm64/fp/sve-ptrace.c > @@ -557,7 +557,14 @@ static int do_parent(pid_t child) > } > > /* prctl() flags */ > - ptrace_set_get_inherit(child, &vec_types[i]); > + if (getauxval(vec_types[i].hwcap_type) & vec_types[i].hwcap) { > + ptrace_set_get_inherit(child, &vec_types[i]); > + } else { > + ksft_test_result_skip("%s SVE_PT_VL_INHERIT set\n", > + vec_types[i].name); > + ksft_test_result_skip("%s SVE_PT_VL_INHERIT cleared\n", > + vec_types[i].name); These messages are a bit confusing. Are we skipping two tests? These messages can be combined into one like this one on lin 572: ksft_test_result_skip("%s get/set VL %d\n", vec_types[i].name, vl); > + } > > /* Step through every possible VQ */ > for (vq = SVE_VQ_MIN; vq <= SVE_VQ_MAX; vq++) { > thanks, -- Shuah _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel