From: Andrey Grodzovsky Subject: Re: [PATCH 03/29] drm/amd/display: Complete TODO item: use new DRM iterator Date: Mon, 30 Oct 2017 13:19:12 -0400 Message-ID: References: <20171026183525.7532-1-harry.wentland@amd.com> <20171026183525.7532-4-harry.wentland@amd.com> <3450881e-59f5-7784-707c-fa9387d9e97e@amd.com> <87b988ad-8c7c-ec08-df65-6b4ff4c1af59@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: Leo , Harry Wentland , amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org CgpPbiAxMC8zMC8yMDE3IDAxOjE0IFBNLCBMZW8gd3JvdGU6Cj4KPgo+IE9uIDIwMTctMTAtMzAg MTI6MzYgUE0sIExlbyB3cm90ZToKPj4KPj4KPj4gT24gMjAxNy0xMC0yNiAxMTowNiBQTSwgQW5k cmV5IEdyb2R6b3Zza3kgd3JvdGU6Cj4+Pgo+Pj4KPj4+IE9uIDIwMTctMTAtMjYgMDI6MzQgUE0s IEhhcnJ5IFdlbnRsYW5kIHdyb3RlOgo+Pj4+IEZyb206ICJMZW8gKFN1bnBlbmcpIExpIiA8c3Vu cGVuZy5saUBhbWQuY29tPgo+Pj4+Cj4+Pj4gQWJhbmRvbiBuZXdfY3J0Y3MgYXJyYXkgYW5kIHVz ZSBmb3JfZWFjaF9uZXcgaXRlcmF0b3IgdG8gYWNxdWlyZSBuZXcKPj4+PiBjcnRjcy4KPj4+Pgo+ Pj4+IFNpZ25lZC1vZmYtYnk6IExlbyAoU3VucGVuZykgTGkgPHN1bnBlbmcubGlAYW1kLmNvbT4K Pj4+PiBSZXZpZXdlZC1ieTogSGFycnkgV2VudGxhbmQgPEhhcnJ5LldlbnRsYW5kQGFtZC5jb20+ Cj4+Pj4gLS0tCj4+Pj4gICBkcml2ZXJzL2dwdS9kcm0vYW1kL2Rpc3BsYXkvYW1kZ3B1X2RtL2Ft ZGdwdV9kbS5jIHwgMzYgCj4+Pj4gKysrKysrKysrLS0tLS0tLS0tLS0tLS0KPj4+PiAgIDEgZmls ZSBjaGFuZ2VkLCAxNCBpbnNlcnRpb25zKCspLCAyMiBkZWxldGlvbnMoLSkKPj4+Pgo+Pj4+IGRp ZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2Rpc3BsYXkvYW1kZ3B1X2RtL2FtZGdwdV9k bS5jIAo+Pj4+IGIvZHJpdmVycy9ncHUvZHJtL2FtZC9kaXNwbGF5L2FtZGdwdV9kbS9hbWRncHVf ZG0uYwo+Pj4+IGluZGV4IDQ0MmIzOTlhOTQwMC4uNTkwZjgwZDI5YjU2IDEwMDY0NAo+Pj4+IC0t LSBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvZGlzcGxheS9hbWRncHVfZG0vYW1kZ3B1X2RtLmMKPj4+ PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2Rpc3BsYXkvYW1kZ3B1X2RtL2FtZGdwdV9kbS5j Cj4+Pj4gQEAgLTQwMTMsMTAgKzQwMTMsOCBAQCBzdGF0aWMgdm9pZCAKPj4+PiBhbWRncHVfZG1f YXRvbWljX2NvbW1pdF90YWlsKHN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICpzdGF0ZSkKPj4+PiAg ICAgICBzdHJ1Y3QgYW1kZ3B1X2Rpc3BsYXlfbWFuYWdlciAqZG0gPSAmYWRldi0+ZG07Cj4+Pj4g ICAgICAgc3RydWN0IGRtX2F0b21pY19zdGF0ZSAqZG1fc3RhdGU7Cj4+Pj4gICAgICAgdWludDMy X3QgaSwgajsKPj4+PiAtICAgIHVpbnQzMl90IG5ld19jcnRjc19jb3VudCA9IDA7Cj4+Pj4gICAg ICAgc3RydWN0IGRybV9jcnRjICpjcnRjOwo+Pj4+ICAgICAgIHN0cnVjdCBkcm1fY3J0Y19zdGF0 ZSAqb2xkX2NydGNfc3RhdGUsICpuZXdfY3J0Y19zdGF0ZTsKPj4+PiAtICAgIHN0cnVjdCBhbWRn cHVfY3J0YyAqbmV3X2NydGNzW01BWF9TVFJFQU1TXTsKPj4+PiAgICAgICB1bnNpZ25lZCBsb25n IGZsYWdzOwo+Pj4+ICAgICAgIGJvb2wgd2FpdF9mb3JfdmJsYW5rID0gdHJ1ZTsKPj4+PiAgICAg ICBzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9yOwo+Pj4+IEBAIC00MDc1LDI1ICs0MDcz LDkgQEAgc3RhdGljIHZvaWQgCj4+Pj4gYW1kZ3B1X2RtX2F0b21pY19jb21taXRfdGFpbChzdHJ1 Y3QgZHJtX2F0b21pY19zdGF0ZSAqc3RhdGUpCj4+Pj4gICAgICAgICAgICAgICAgICAgY29udGlu dWU7Cj4+Pj4gICAgICAgICAgICAgICB9Cj4+Pj4gLQo+Pj4+ICAgICAgICAgICAgICAgaWYgKGRt X29sZF9jcnRjX3N0YXRlLT5zdHJlYW0pCj4+Pj4gICAgICAgICAgICAgICAgICAgcmVtb3ZlX3N0 cmVhbShhZGV2LCBhY3J0YywgCj4+Pj4gZG1fb2xkX2NydGNfc3RhdGUtPnN0cmVhbSk7Cj4+Pj4g LQo+Pj4+IC0gICAgICAgICAgICAvKgo+Pj4+IC0gICAgICAgICAgICAgKiB0aGlzIGxvb3Agc2F2 ZXMgc2V0IG1vZGUgY3J0Y3MKPj4+PiAtICAgICAgICAgICAgICogd2UgbmVlZGVkIHRvIGVuYWJs ZSB2YmxhbmtzIG9uY2UgYWxsCj4+Pj4gLSAgICAgICAgICAgICAqIHJlc291cmNlcyBhY3F1aXJl ZCBpbiBkYyBhZnRlciBkY19jb21taXRfc3RyZWFtcwo+Pj4+IC0gICAgICAgICAgICAgKi8KPj4+ PiAtCj4+Pj4gLSAgICAgICAgICAgIC8qVE9ETyBtb3ZlIGFsbCB0aGlzIGludG8gZG1fY3J0Y19z dGF0ZSwgZ2V0IHJpZCBvZgo+Pj4+IC0gICAgICAgICAgICAgKiBuZXdfY3J0Y3MgYXJyYXkgYW5k IHVzZSBvbGQgYW5kIG5ldyBhdG9taWMgc3RhdGVzCj4+Pj4gLSAgICAgICAgICAgICAqIGluc3Rl YWQKPj4+PiAtICAgICAgICAgICAgICovCj4+Pj4gLSAgICAgICAgICAgIG5ld19jcnRjc1tuZXdf Y3J0Y3NfY291bnRdID0gYWNydGM7Cj4+Pj4gLSAgICAgICAgICAgIG5ld19jcnRjc19jb3VudCsr Owo+Pj4+IC0KPj4+PiAtICAgICAgICAgICAgbmV3X2NydGNfc3RhdGUgPSBkcm1fYXRvbWljX2dl dF9uZXdfY3J0Y19zdGF0ZShzdGF0ZSwgCj4+Pj4gY3J0Yyk7Cj4+Pj4gICAgICAgICAgICAgICBh Y3J0Yy0+ZW5hYmxlZCA9IHRydWU7Cj4+Pj4gICAgICAgICAgICAgICBhY3J0Yy0+aHdfbW9kZSA9 IG5ld19jcnRjX3N0YXRlLT5tb2RlOwo+Pj4+ICAgICAgICAgICAgICAgY3J0Yy0+aHdtb2RlID0g bmV3X2NydGNfc3RhdGUtPm1vZGU7Cj4+Pj4gQEAgLTQyMjEsMTggKzQyMDMsMjggQEAgc3RhdGlj IHZvaWQgCj4+Pj4gYW1kZ3B1X2RtX2F0b21pY19jb21taXRfdGFpbChzdHJ1Y3QgZHJtX2F0b21p Y19zdGF0ZSAqc3RhdGUpCj4+Pj4gICAgICAgICAgICAgICBkbV9lcnJvcigiJXM6IEZhaWxlZCB0 byB1cGRhdGUgc3RyZWFtIHNjYWxpbmchXG4iLCAKPj4+PiBfX2Z1bmNfXyk7Cj4+Pj4gICAgICAg fQo+Pj4+IC0gICAgZm9yIChpID0gMDsgaSA8IG5ld19jcnRjc19jb3VudDsgaSsrKSB7Cj4+Pj4g KyAgICBmb3JfZWFjaF9vbGRuZXdfY3J0Y19pbl9zdGF0ZShzdGF0ZSwgY3J0Yywgb2xkX2NydGNf c3RhdGUsCj4+Pj4gKyAgICAgICAgICAgIG5ld19jcnRjX3N0YXRlLCBpKSB7Cj4+Pj4gICAgICAg ICAgIC8qCj4+Pj4gICAgICAgICAgICAqIGxvb3AgdG8gZW5hYmxlIGludGVycnVwdHMgb24gbmV3 bHkgYXJyaXZlZCBjcnRjCj4+Pj4gICAgICAgICAgICAqLwo+Pj4+IC0gICAgICAgIHN0cnVjdCBh bWRncHVfY3J0YyAqYWNydGMgPSBuZXdfY3J0Y3NbaV07Cj4+Pj4gKyAgICAgICAgc3RydWN0IGFt ZGdwdV9jcnRjICphY3J0YyA9IHRvX2FtZGdwdV9jcnRjKGNydGMpOwo+Pj4+ICsgICAgICAgIGJv b2wgbW9kZXNldF9uZWVkZWQ7Cj4+Pj4gLSAgICAgICAgbmV3X2NydGNfc3RhdGUgPSBkcm1fYXRv bWljX2dldF9uZXdfY3J0Y19zdGF0ZShzdGF0ZSwgCj4+Pj4gJmFjcnRjLT5iYXNlKTsKPj4+PiAg ICAgICAgICAgZG1fbmV3X2NydGNfc3RhdGUgPSB0b19kbV9jcnRjX3N0YXRlKG5ld19jcnRjX3N0 YXRlKTsKPj4+PiArICAgICAgICBkbV9vbGRfY3J0Y19zdGF0ZSA9IHRvX2RtX2NydGNfc3RhdGUo b2xkX2NydGNfc3RhdGUpOwo+Pj4+ICsgICAgICAgIG1vZGVzZXRfbmVlZGVkID0gbW9kZXNldF9y ZXF1aXJlZCgKPj4+PiArICAgICAgICAgICAgICAgIG5ld19jcnRjX3N0YXRlLAo+Pj4+ICsgICAg ICAgICAgICAgICAgZG1fbmV3X2NydGNfc3RhdGUtPnN0cmVhbSwKPj4+PiArICAgICAgICAgICAg ICAgIGRtX29sZF9jcnRjX3N0YXRlLT5zdHJlYW0pOwo+Pj4+ICsKPj4+PiArICAgICAgICBpZiAo ZG1fbmV3X2NydGNfc3RhdGUtPnN0cmVhbSA9PSBOVUxMIHx8ICFtb2Rlc2V0X25lZWRlZCkKPj4+ PiArICAgICAgICAgICAgY29udGludWU7Cj4+Pgo+Pj4gSSBmZWVsIGl0J3MgYSBiaXQgZnV0dXJl IGJ1ZyBwcm9uZSB0byByZXBlYXQgdGhlIDIgY2hlY2tzIGFib3ZlIGZyb20gCj4+PiB0aGUgaW5p dGlhbAo+Pj4gZm9yX2VhY2hfY3J0Y19pbl9zdGF0ZSBsb29wLCBzb21lYm9keSBtYWtlcyBjaGFu Z2VzIHRoZXJlIGFuZCBmb3JnZXQgCj4+PiBhYm91dCB0aGlzIGxvb3AuCj4+PiBUaGUgYXJyYXkg aXMgdWdseSBidXQgaXQgYXZvaWRzIGxvZ2ljIGR1cGxpY2F0aW9uLgo+Pgo+PiBJIHRoaW5rIGEg YmV0dGVyIGZpeCB3b3VsZCBiZSB0byBjb21iaW5lIHRoaXMgZm9yX2VhY2ggc2VjdGlvbiB3aXRo IHRoZQo+PiBvbmUgYWJvdmUgaXQuIFRoZSBvbmx5IHRoaW5nIGtlZXBpbmcgdGhlbSBzZXBhcmF0 ZSAobm90IHNob3duIGluIHRoZQo+PiBhYm92ZSBjb250ZXh0KSBpcyBhbiBgaWYgKGFkZXYtPmRt LmZyZWVzeW5jX21vZHVsZSlgIGd1YXJkLCB3aGljaCBjYW4gYmUKPj4gcHVsbGVkIGludG8gdGhl IGZpcnN0IGZvcl9lYWNoIGxvb3AuIEl0IHdvdWxkIGFsc28gZWxpbWluYXRlIGEgbG90IG9mCj4+ IGR1cGxpY2F0ZWQgaW5pdGlhbGl6YXRpb24gY29kZS4KPj4KPj4gVGhvdWdodHM/Cj4+Cj4+IExl bwo+Pgo+Cj4gSWdub3JlIHdoYXQgSSBzYWlkLCBJdCBzZWVtcyBJIHdhcyBsb29raW5nIGF0IHRo ZSB3cm9uZyBjb250ZXh0IDopIFRoZSAKPiBmYWN0IHRoaXMgYmxvYiBpcyBiZWluZyBkb25lIGFm dGVyIGRjX2NvbW1pdF9zdGF0ZSgpIGlzIGFubm95aW5nLi4uCj4KPiBUaGUgbWFpbnRhaW5hYmls aXR5IG9mIHRoaXMgZHVwbGljYXRlZCBsb2dpYyBpcyBhIGdvb2QgcG9pbnQuIEFsdGhvdWdoIAo+ IEknbSBub3Qgc3VyZSBpZiBnb2luZyBiYWNrIHRvIGEgc2hhcmVkIGFycmF5IHVzaW5nIGN1c3Rv bSBpdGVyYXRvciAKPiBsb2dpYyBpcyB0aGUgYmVzdCBhcHByb2FjaC4gUGVyaGFwc2Ugd2UgY2Fu IHB1bGwgdGhpcyBkdXBsaWNhdGVkIGxvZ2ljIAo+IGludG8gYSBzZXBlcmF0ZSBmdW5jdGlvbj8K ClRoYXQgYWN0dWFsbHkgYSBnb29kIGlkZWEuCgpUaGFua3MsCkFuZHJleQoKPgo+IFRoYW5rcywK PiBMZW8KPgo+Cj4KPj4+Cj4+PiBUaGFua3MsCj4+PiBBbmRyZXkKPj4+Cj4+Pj4gICAgICAgICAg IGlmIChhZGV2LT5kbS5mcmVlc3luY19tb2R1bGUpCj4+Pj4gICAgICAgICAgICAgICBtb2RfZnJl ZXN5bmNfbm90aWZ5X21vZGVfY2hhbmdlKAo+Pj4+IC0gICAgICAgICAgICAgICAgYWRldi0+ZG0u ZnJlZXN5bmNfbW9kdWxlLCAKPj4+PiAmZG1fbmV3X2NydGNfc3RhdGUtPnN0cmVhbSwgMSk7Cj4+ Pj4gKyAgICAgICAgICAgICAgICBhZGV2LT5kbS5mcmVlc3luY19tb2R1bGUsCj4+Pj4gKyAgICAg ICAgICAgICAgICAmZG1fbmV3X2NydGNfc3RhdGUtPnN0cmVhbSwgMSk7Cj4+Pj4gICAgICAgICAg IG1hbmFnZV9kbV9pbnRlcnJ1cHRzKGFkZXYsIGFjcnRjLCB0cnVlKTsKPj4+PiAgICAgICB9Cj4+ Pgo+PiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+PiBh bWQtZ2Z4IG1haWxpbmcgbGlzdAo+PiBhbWQtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+PiBo dHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2FtZC1nZngKCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmFtZC1nZnggbWFp bGluZyBsaXN0CmFtZC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJl ZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vYW1kLWdmeAo=