Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4241FC388F9 for ; Fri, 23 Oct 2020 07:24:23 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CB75020936 for ; Fri, 23 Oct 2020 07:24:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=suse.com header.i=@suse.com header.b="F3++9Q6C" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CB75020936 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.10741.28639 (Exim 4.92) (envelope-from ) id 1kVrQa-0006ke-H5; Fri, 23 Oct 2020 07:23:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 10741.28639; Fri, 23 Oct 2020 07:23:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kVrQa-0006kX-E9; Fri, 23 Oct 2020 07:23:56 +0000 Received: by outflank-mailman (input) for mailman id 10741; Fri, 23 Oct 2020 07:23:55 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kVrQZ-0006jo-5U for xen-devel@lists.xenproject.org; Fri, 23 Oct 2020 07:23:55 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 3572783e-1b9d-4ce2-b6d9-c24579dccee8; Fri, 23 Oct 2020 07:23:54 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 303B9ACC4; Fri, 23 Oct 2020 07:23:53 +0000 (UTC) Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kVrQZ-0006jo-5U for xen-devel@lists.xenproject.org; Fri, 23 Oct 2020 07:23:55 +0000 X-Inumbo-ID: 3572783e-1b9d-4ce2-b6d9-c24579dccee8 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 3572783e-1b9d-4ce2-b6d9-c24579dccee8; Fri, 23 Oct 2020 07:23:54 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1603437833; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XKi9lIqkUcYox5yJhEdLIRNbCvTjIhSfcdCdbLv9Dxs=; b=F3++9Q6CAXssj7ySAz86mgcxN2wY4jEUZHrE9a6jLaZc/pkcomxYxeVhpdyhZlqGQDT6X/ 7tE2xEngsLZibVmfPPX01Ou+ytTqW1U7u+BfPUd72WbJTHMLIxrNmhWaSj54vaCG7i6hV7 6ykzzRAFTNZPiBruXQ9VEl10J9gfTa4= Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 303B9ACC4; Fri, 23 Oct 2020 07:23:53 +0000 (UTC) Subject: Re: [PATCH] xen/arm: ACPI: Remove EXPERT dependancy, default on for ARM64 To: Elliott Mitchell Cc: Stefano Stabellini , Julien Grall , xen-devel@lists.xenproject.org, Volodymyr Babchuk References: <20201022014310.GA70872@mattapan.m5p.com> <7bf92deb-b1ba-31b2-0357-2639cd2a1bca@xen.org> <20201023033506.GC83870@mattapan.m5p.com> From: Jan Beulich Message-ID: Date: Fri, 23 Oct 2020 09:23:55 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.1 MIME-Version: 1.0 In-Reply-To: <20201023033506.GC83870@mattapan.m5p.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 23.10.2020 05:35, Elliott Mitchell wrote: > --- a/xen/arch/arm/Kconfig > +++ b/xen/arch/arm/Kconfig > @@ -32,13 +32,18 @@ menu "Architecture Features" > source "arch/Kconfig" > > config ACPI > - bool "ACPI (Advanced Configuration and Power Interface) Support" if EXPERT > + bool "ACPI (Advanced Configuration and Power Interface) Support" > depends on ARM_64 > + default y if ARM_64 The "if" is pointless with the "depends on". > --- a/xen/arch/arm/acpi/boot.c > +++ b/xen/arch/arm/acpi/boot.c > @@ -254,6 +254,15 @@ int __init acpi_boot_table_init(void) > dt_scan_depth1_nodes, NULL) ) > goto disable; > > + printk("\n" > +"*************************************************************************\n" > +"* WARNING WARNING WARNING WARNING WARNING WARNING WARNING WARNING *\n" > +"* *\n" > +"* Xen-ARM ACPI support is EXPERIMENTAL. It is presently (October 2020) *\n" > +"* recommended you boot your system in device-tree mode if you can. *\n" > +"*************************************************************************\n" > + "\n"); > + We have an abstraction for such warnings, causing them to appear later in the boot process and then consistently all in one place (both increasing, as we believe, the chances of being noticed): warning_add(). There's a delay accompanied with this, so I think you will want to also have a command line option allowing to silence this warning. "acpi=on" or "acpi=force", as available on x86 and (possibly wrongly right now) not documented as x86-specific, may be (re-)usable, i.e. to avoid having to introduce some entirely new option. Also a few formal nits: The subject tag should have been [PATCH v2], there should have been a short revision log outside of the commit message area, and new patch versione would better start their own new threads than being in-reply-to the earlier version's one. Jan