Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 65BA2360EDC for ; Fri, 19 Jun 2026 09:18:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781860708; cv=none; b=V1KIoE9/TMwfB2FynzLBGghwOW9Z03hSQySm1xlF7AodKHdIGKyAjhOqrkgFKE4nKkAdikUEfIV5pC2LJMmoE0VtQOy8gLln5Eq/ESvCX7wKDDQJ13CRw1fZoy58CyuCQAmVAYM+0R3AtmkNbO9A7V0Z/oHhZxldH11q5dms324= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781860708; c=relaxed/simple; bh=lTihVApC4Aw4YsFwbH938d90xKfb3aJCY+8yoi0ez4Q=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=c0cQGK88ssITzHSt13NTPOXOFSDKl4YapDuV9RilW2OiCHNjx2EICS0+fnNrkeCXr6MIacqDwnRJZisOkhzTrUxMjFq7FdkhMJAddIhPLf5xMiTzeJObtqhubI95qywGdWnNL2PF8OTMYS9AKAsYL8TiAhROXTazULbLwII/PWM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=cZ1SaRTa; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=NiLSTnNP; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=cZ1SaRTa; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=NiLSTnNP; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="cZ1SaRTa"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="NiLSTnNP"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="cZ1SaRTa"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="NiLSTnNP" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 247AB6D881; Fri, 19 Jun 2026 09:18:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1781860704; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gwgq7FWbOn6DX94CymExYFiIZQiFrKHwJqkDF/w76xA=; b=cZ1SaRTaWbmtU2ymUNTn8l8eBVdKOuWO0HbXWT3q2t066sGqJYpmpEt/wuhm6iamuWMw4i 4LiflkW6oJRNPEoz2YvpPJmq02mQdGodnPhvUhRWPgfBsXnrtX62bMSD80kdkQDQ8uldZG 6GzHTxOCYJ4sl4Ch74UKbYtnqvsSXi8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1781860704; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gwgq7FWbOn6DX94CymExYFiIZQiFrKHwJqkDF/w76xA=; b=NiLSTnNPA3G6GW+7CRk61Vt4RdgesZuJErYb9LzQsXSLXdUhItvpVaWCie/6O2ay+Cg0KV TmludrAb9YIUNQCw== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=cZ1SaRTa; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=NiLSTnNP DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1781860704; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gwgq7FWbOn6DX94CymExYFiIZQiFrKHwJqkDF/w76xA=; b=cZ1SaRTaWbmtU2ymUNTn8l8eBVdKOuWO0HbXWT3q2t066sGqJYpmpEt/wuhm6iamuWMw4i 4LiflkW6oJRNPEoz2YvpPJmq02mQdGodnPhvUhRWPgfBsXnrtX62bMSD80kdkQDQ8uldZG 6GzHTxOCYJ4sl4Ch74UKbYtnqvsSXi8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1781860704; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gwgq7FWbOn6DX94CymExYFiIZQiFrKHwJqkDF/w76xA=; b=NiLSTnNPA3G6GW+7CRk61Vt4RdgesZuJErYb9LzQsXSLXdUhItvpVaWCie/6O2ay+Cg0KV TmludrAb9YIUNQCw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id ED7C2779A8; Fri, 19 Jun 2026 09:18:23 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id UtbYNl8JNWo8ZgAAD6G6ig (envelope-from ); Fri, 19 Jun 2026 09:18:23 +0000 Message-ID: Date: Fri, 19 Jun 2026 11:18:23 +0200 Precedence: bulk X-Mailing-List: netfilter-devel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/1] netfilter: nf_tables_offload: drop device refcount on error To: Florian Westphal , netfilter-devel@vger.kernel.org References: <20260605114715.11297-1-fw@strlen.de> Content-Language: en-US From: Fernando Fernandez Mancera In-Reply-To: <20260605114715.11297-1-fw@strlen.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Flag: NO X-Rspamd-Action: no action X-Spam-Level: X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; MIME_TRACE(0.00)[0:+]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCVD_TLS_ALL(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:email,suse.de:dkim,suse.de:mid,imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Queue-Id: 247AB6D881 X-Spam-Score: -4.51 On 6/5/26 1:47 PM, Florian Westphal wrote: > Reported by sashiko: > If nft_flow_action_entry_next() returns NULL, dev reference leaks. > > Fixes: c6f85577584b ("netfilter: nf_tables_offload: add nft_flow_action_entry_next() and use it") > Reported-by: Juri Lelli > Signed-off-by: Florian Westphal Reviewed-by: Fernando Fernandez Mancera Thanks!