From: Maarten Lankhorst Subject: Re: [PATCH 11/15] drm/i915: dev_priv cleanup in intel_dp.c Date: Thu, 17 Nov 2016 15:21:02 +0100 Message-ID: References: <1479286545-15020-1-git-send-email-tvrtko.ursulin@linux.intel.com> <1479286545-15020-12-git-send-email-tvrtko.ursulin@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id DA0736E6B2 for ; Thu, 17 Nov 2016 14:21:04 +0000 (UTC) In-Reply-To: <1479286545-15020-12-git-send-email-tvrtko.ursulin@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Tvrtko Ursulin , Intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T3AgMTYtMTEtMTYgb20gMDk6NTUgc2NocmVlZiBUdnJ0a28gVXJzdWxpbjoKPiBGcm9tOiBUdnJ0 a28gVXJzdWxpbiA8dHZydGtvLnVyc3VsaW5AaW50ZWwuY29tPgo+Cj4gQW5kIGFzIHVzdWFsIGEg bGl0dGxlIGJpdCBvZiBjYXNjYWRlZCBmdW5jdGlvbiBwcm90b3R5cGUgY2hhbmdlcy4KPgo+IFNp Z25lZC1vZmYtYnk6IFR2cnRrbyBVcnN1bGluIDx0dnJ0a28udXJzdWxpbkBpbnRlbC5jb20+Cj4g LS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyB8ICA2ICsrKy0tLQo+ ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jICAgICAgfCAyNiArKysrKysrKysrKy0t LS0tLS0tLS0tLS0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYuaCAgICAgfCAg MiArLQo+ICAzIGZpbGVzIGNoYW5nZWQsIDE1IGluc2VydGlvbnMoKyksIDE5IGRlbGV0aW9ucygt KQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyBi L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+IGluZGV4IGY3MjMwNzhjYzVk OS4uZGExZTI5ZWM5ZWI2IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X2Rpc3BsYXkuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+ IEBAIC0xNTU1MSw3ICsxNTU1MSw3IEBAIHN0YXRpYyB2b2lkIGludGVsX3NldHVwX291dHB1dHMo c3RydWN0IGRybV9kZXZpY2UgKmRldikKPiAgCj4gIAl9IGVsc2UgaWYgKEhBU19QQ0hfU1BMSVQo ZGV2X3ByaXYpKSB7Cj4gIAkJaW50IGZvdW5kOwo+IC0JCWRwZF9pc19lZHAgPSBpbnRlbF9kcF9p c19lZHAoZGV2LCBQT1JUX0QpOwo+ICsJCWRwZF9pc19lZHAgPSBpbnRlbF9kcF9pc19lZHAoZGV2 X3ByaXYsIFBPUlRfRCk7Cj4gIAo+ICAJCWlmIChoYXNfZWRwX2EoZGV2X3ByaXYpKQo+ICAJCQlp bnRlbF9kcF9pbml0KGRldiwgRFBfQSwgUE9SVF9BKTsKPiBAQCAtMTU1OTQsMTQgKzE1NTk0LDE0 IEBAIHN0YXRpYyB2b2lkIGludGVsX3NldHVwX291dHB1dHMoc3RydWN0IGRybV9kZXZpY2UgKmRl dikKPiAgCQkgKiB0cnVzdCB0aGUgcG9ydCB0eXBlIHRoZSBWQlQgZGVjbGFyZXMgYXMgd2UndmUg c2VlbiBhdCBsZWFzdAo+ICAJCSAqIEhETUkgcG9ydHMgdGhhdCB0aGUgVkJUIGNsYWltIGFyZSBE UCBvciBlRFAuCj4gIAkJICovCj4gLQkJaGFzX2VkcCA9IGludGVsX2RwX2lzX2VkcChkZXYsIFBP UlRfQik7Cj4gKwkJaGFzX2VkcCA9IGludGVsX2RwX2lzX2VkcChkZXZfcHJpdiwgUE9SVF9CKTsK PiAgCQloYXNfcG9ydCA9IGludGVsX2Jpb3NfaXNfcG9ydF9wcmVzZW50KGRldl9wcml2LCBQT1JU X0IpOwo+ICAJCWlmIChJOTE1X1JFQUQoVkxWX0RQX0IpICYgRFBfREVURUNURUQgfHwgaGFzX3Bv cnQpCj4gIAkJCWhhc19lZHAgJj0gaW50ZWxfZHBfaW5pdChkZXYsIFZMVl9EUF9CLCBQT1JUX0Ip Owo+ICAJCWlmICgoSTkxNV9SRUFEKFZMVl9IRE1JQikgJiBTRFZPX0RFVEVDVEVEIHx8IGhhc19w b3J0KSAmJiAhaGFzX2VkcCkKPiAgCQkJaW50ZWxfaGRtaV9pbml0KGRldiwgVkxWX0hETUlCLCBQ T1JUX0IpOwo+ICAKPiAtCQloYXNfZWRwID0gaW50ZWxfZHBfaXNfZWRwKGRldiwgUE9SVF9DKTsK PiArCQloYXNfZWRwID0gaW50ZWxfZHBfaXNfZWRwKGRldl9wcml2LCBQT1JUX0MpOwo+ICAJCWhh c19wb3J0ID0gaW50ZWxfYmlvc19pc19wb3J0X3ByZXNlbnQoZGV2X3ByaXYsIFBPUlRfQyk7Cj4g IAkJaWYgKEk5MTVfUkVBRChWTFZfRFBfQykgJiBEUF9ERVRFQ1RFRCB8fCBoYXNfcG9ydCkKPiAg CQkJaGFzX2VkcCAmPSBpbnRlbF9kcF9pbml0KGRldiwgVkxWX0RQX0MsIFBPUlRfQyk7Cj4gZGlm ZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMgYi9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9kcC5jCj4gaW5kZXggYTFiMDE4MWY0MmM0Li45MDI4M2VkY2FmYmEgMTAw NjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYwo+ICsrKyBiL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMKPiBAQCAtMTU0Miw4ICsxNTQyLDcgQEAgaW50ZWxf ZHBfY29tcHV0ZV9jb25maWcoc3RydWN0IGludGVsX2VuY29kZXIgKmVuY29kZXIsCj4gIAkJCXN0 cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpwaXBlX2NvbmZpZywKPiAgCQkJc3RydWN0IGRybV9jb25u ZWN0b3Jfc3RhdGUgKmNvbm5fc3RhdGUpCj4gIHsKPiAtCXN0cnVjdCBkcm1fZGV2aWNlICpkZXYg PSBlbmNvZGVyLT5iYXNlLmRldjsKPiAtCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJp diA9IHRvX2k5MTUoZGV2KTsKPiArCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9 IHRvX2k5MTUoZW5jb2Rlci0+YmFzZS5kZXYpOwo+ICAJc3RydWN0IGRybV9kaXNwbGF5X21vZGUg KmFkanVzdGVkX21vZGUgPSAmcGlwZV9jb25maWctPmJhc2UuYWRqdXN0ZWRfbW9kZTsKPiAgCXN0 cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHAgPSBlbmNfdG9faW50ZWxfZHAoJmVuY29kZXItPmJhc2Up Owo+ICAJZW51bSBwb3J0IHBvcnQgPSBkcF90b19kaWdfcG9ydChpbnRlbF9kcCktPnBvcnQ7Cj4g QEAgLTE1NzgsNyArMTU3Nyw3IEBAIGludGVsX2RwX2NvbXB1dGVfY29uZmlnKHN0cnVjdCBpbnRl bF9lbmNvZGVyICplbmNvZGVyLAo+ICAJCWludGVsX2ZpeGVkX3BhbmVsX21vZGUoaW50ZWxfY29u bmVjdG9yLT5wYW5lbC5maXhlZF9tb2RlLAo+ICAJCQkJICAgICAgIGFkanVzdGVkX21vZGUpOwo+ ICAKPiAtCQlpZiAoSU5URUxfSU5GTyhkZXYpLT5nZW4gPj0gOSkgewo+ICsJCWlmIChJTlRFTF9H RU4oZGV2X3ByaXYpID49IDkpIHsKPiAgCQkJaW50IHJldDsKPiAgCQkJcmV0ID0gc2tsX3VwZGF0 ZV9zY2FsZXJfY3J0YyhwaXBlX2NvbmZpZyk7Cj4gIAkJCWlmIChyZXQpCj4gQEAgLTI5NzcsMTMg KzI5NzYsMTIgQEAgaW50ZWxfZHBfZ2V0X2xpbmtfc3RhdHVzKHN0cnVjdCBpbnRlbF9kcCAqaW50 ZWxfZHAsIHVpbnQ4X3QgbGlua19zdGF0dXNbRFBfTElOS18KPiAgdWludDhfdAo+ICBpbnRlbF9k cF92b2x0YWdlX21heChzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2RwKQo+ICB7Cj4gLQlzdHJ1Y3Qg ZHJtX2RldmljZSAqZGV2ID0gaW50ZWxfZHBfdG9fZGV2KGludGVsX2RwKTsKPiAtCXN0cnVjdCBk cm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUoZGV2KTsKPiArCXN0cnVjdCBkcm1f aTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUoaW50ZWxfZHBfdG9fZGV2KGludGVsX2Rw KSk7Cj4gIAllbnVtIHBvcnQgcG9ydCA9IGRwX3RvX2RpZ19wb3J0KGludGVsX2RwKS0+cG9ydDsK PiAgCj4gIAlpZiAoSVNfQlJPWFRPTihkZXZfcHJpdikpCj4gIAkJcmV0dXJuIERQX1RSQUlOX1ZP TFRBR0VfU1dJTkdfTEVWRUxfMzsKPiAtCWVsc2UgaWYgKElOVEVMX0lORk8oZGV2KS0+Z2VuID49 IDkpIHsKPiArCWVsc2UgaWYgKElOVEVMX0dFTihkZXZfcHJpdikgPj0gOSkgewo+ICAJCWlmIChk ZXZfcHJpdi0+dmJ0LmVkcC5sb3dfdnN3aW5nICYmIHBvcnQgPT0gUE9SVF9BKQo+ICAJCQlyZXR1 cm4gRFBfVFJBSU5fVk9MVEFHRV9TV0lOR19MRVZFTF8zOwo+ICAJCXJldHVybiBEUF9UUkFJTl9W T0xUQUdFX1NXSU5HX0xFVkVMXzI7Cj4gQEAgLTQ4NzEsMTUgKzQ4NjksMTMgQEAgaW50ZWxfZHBf aHBkX3B1bHNlKHN0cnVjdCBpbnRlbF9kaWdpdGFsX3BvcnQgKmludGVsX2RpZ19wb3J0LCBib29s IGxvbmdfaHBkKQo+ICB9Cj4gIAo+ICAvKiBjaGVjayB0aGUgVkJUIHRvIHNlZSB3aGV0aGVyIHRo ZSBlRFAgaXMgb24gYW5vdGhlciBwb3J0ICovCj4gLWJvb2wgaW50ZWxfZHBfaXNfZWRwKHN0cnVj dCBkcm1fZGV2aWNlICpkZXYsIGVudW0gcG9ydCBwb3J0KQo+ICtib29sIGludGVsX2RwX2lzX2Vk cChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsIGVudW0gcG9ydCBwb3J0KQo+ICB7 Cj4gLQlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSB0b19pOTE1KGRldik7Cj4g LQo+ICAJLyoKPiAgCSAqIGVEUCBub3Qgc3VwcG9ydGVkIG9uIGc0eC4gc28gYmFpbCBvdXQgZWFy bHkganVzdAo+ICAJICogZm9yIGEgYml0IGV4dHJhIHNhZmV0eSBpbiBjYXNlIHRoZSBWQlQgaXMg Ym9ua2Vycy4KPiAgCSAqLwo+IC0JaWYgKElOVEVMX0lORk8oZGV2KS0+Z2VuIDwgNSkKPiArCWlm IChJTlRFTF9HRU4oZGV2X3ByaXYpIDwgNSkKPiAgCQlyZXR1cm4gZmFsc2U7Cj4gIAo+ICAJaWYg KHBvcnQgPT0gUE9SVF9BKQo+IEBAIC01NDgxLDcgKzU0NzcsNyBAQCBpbnRlbF9kcF9kcnJzX2lu aXQoc3RydWN0IGludGVsX2Nvbm5lY3RvciAqaW50ZWxfY29ubmVjdG9yLAo+ICAJSU5JVF9ERUxB WUVEX1dPUksoJmRldl9wcml2LT5kcnJzLndvcmssIGludGVsX2VkcF9kcnJzX2Rvd25jbG9ja193 b3JrKTsKPiAgCW11dGV4X2luaXQoJmRldl9wcml2LT5kcnJzLm11dGV4KTsKPiAgCj4gLQlpZiAo SU5URUxfSU5GTyhkZXYpLT5nZW4gPD0gNikgewo+ICsJaWYgKElOVEVMX0dFTihkZXZfcHJpdikg PD0gNikgewo+ICAJCURSTV9ERUJVR19LTVMoIkRSUlMgc3VwcG9ydGVkIGZvciBHZW43IGFuZCBh Ym92ZVxuIik7Cj4gIAkJcmV0dXJuIE5VTEw7Cj4gIAl9Cj4gQEAgLTU2NTUsNyArNTY1MSw3IEBA IGludGVsX2RwX2luaXRfY29ubmVjdG9yKHN0cnVjdCBpbnRlbF9kaWdpdGFsX3BvcnQgKmludGVs X2RpZ19wb3J0LAo+ICAJaW50ZWxfZHAtPnBwc19waXBlID0gSU5WQUxJRF9QSVBFOwo+ICAKPiAg CS8qIGludGVsX2RwIHZmdW5jcyAqLwo+IC0JaWYgKElOVEVMX0lORk8oZGV2KS0+Z2VuID49IDkp Cj4gKwlpZiAoSU5URUxfR0VOKGRldl9wcml2KSA+PSA5KQo+ICAJCWludGVsX2RwLT5nZXRfYXV4 X2Nsb2NrX2RpdmlkZXIgPSBza2xfZ2V0X2F1eF9jbG9ja19kaXZpZGVyOwo+ICAJZWxzZSBpZiAo SVNfSEFTV0VMTChkZXZfcHJpdikgfHwgSVNfQlJPQURXRUxMKGRldl9wcml2KSkKPiAgCQlpbnRl bF9kcC0+Z2V0X2F1eF9jbG9ja19kaXZpZGVyID0gaHN3X2dldF9hdXhfY2xvY2tfZGl2aWRlcjsK PiBAQCAtNTY2NCw3ICs1NjYwLDcgQEAgaW50ZWxfZHBfaW5pdF9jb25uZWN0b3Ioc3RydWN0IGlu dGVsX2RpZ2l0YWxfcG9ydCAqaW50ZWxfZGlnX3BvcnQsCj4gIAllbHNlCj4gIAkJaW50ZWxfZHAt PmdldF9hdXhfY2xvY2tfZGl2aWRlciA9IGc0eF9nZXRfYXV4X2Nsb2NrX2RpdmlkZXI7Cj4gIAo+ IC0JaWYgKElOVEVMX0lORk8oZGV2KS0+Z2VuID49IDkpCj4gKwlpZiAoSU5URUxfR0VOKGRldl9w cml2KSA+PSA5KQo+ICAJCWludGVsX2RwLT5nZXRfYXV4X3NlbmRfY3RsID0gc2tsX2dldF9hdXhf c2VuZF9jdGw7Cj4gIAllbHNlCj4gIAkJaW50ZWxfZHAtPmdldF9hdXhfc2VuZF9jdGwgPSBnNHhf Z2V0X2F1eF9zZW5kX2N0bDsKPiBAQCAtNTY3Niw3ICs1NjcyLDcgQEAgaW50ZWxfZHBfaW5pdF9j b25uZWN0b3Ioc3RydWN0IGludGVsX2RpZ2l0YWxfcG9ydCAqaW50ZWxfZGlnX3BvcnQsCj4gIAlp bnRlbF9kcC0+RFAgPSBJOTE1X1JFQUQoaW50ZWxfZHAtPm91dHB1dF9yZWcpOwo+ICAJaW50ZWxf ZHAtPmF0dGFjaGVkX2Nvbm5lY3RvciA9IGludGVsX2Nvbm5lY3RvcjsKPiAgCj4gLQlpZiAoaW50 ZWxfZHBfaXNfZWRwKGRldiwgcG9ydCkpCj4gKwlpZiAoaW50ZWxfZHBfaXNfZWRwKGRldl9wcml2 LCBwb3J0KSkKPiAgCQl0eXBlID0gRFJNX01PREVfQ09OTkVDVE9SX2VEUDsKPiAgCWVsc2UKPiAg CQl0eXBlID0gRFJNX01PREVfQ09OTkVDVE9SX0Rpc3BsYXlQb3J0Owo+IEBAIC01ODE0LDcgKzU4 MTAsNyBAQCBib29sIGludGVsX2RwX2luaXQoc3RydWN0IGRybV9kZXZpY2UgKmRldiwKPiAgCX0g ZWxzZSB7Cj4gIAkJaW50ZWxfZW5jb2Rlci0+cHJlX2VuYWJsZSA9IGc0eF9wcmVfZW5hYmxlX2Rw Owo+ICAJCWludGVsX2VuY29kZXItPmVuYWJsZSA9IGc0eF9lbmFibGVfZHA7Cj4gLQkJaWYgKElO VEVMX0lORk8oZGV2KS0+Z2VuID49IDUpCj4gKwkJaWYgKElOVEVMX0dFTihkZXZfcHJpdikgPj0g NSkKPiAgCQkJaW50ZWxfZW5jb2Rlci0+cG9zdF9kaXNhYmxlID0gaWxrX3Bvc3RfZGlzYWJsZV9k cDsKPiAgCX0KPiAgCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Ry di5oIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmgKPiBpbmRleCAwYmU0MDdlNTBk NjEuLjc3ZmI3MzFkZjE3MCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9kcnYuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oCj4gQEAgLTEz OTAsNyArMTM5MCw3IEBAIGludCBpbnRlbF9kcF9zaW5rX2NyYyhzdHJ1Y3QgaW50ZWxfZHAgKmlu dGVsX2RwLCB1OCAqY3JjKTsKPiAgYm9vbCBpbnRlbF9kcF9jb21wdXRlX2NvbmZpZyhzdHJ1Y3Qg aW50ZWxfZW5jb2RlciAqZW5jb2RlciwKPiAgCQkJICAgICBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0 ZSAqcGlwZV9jb25maWcsCj4gIAkJCSAgICAgc3RydWN0IGRybV9jb25uZWN0b3Jfc3RhdGUgKmNv bm5fc3RhdGUpOwo+IC1ib29sIGludGVsX2RwX2lzX2VkcChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2 LCBlbnVtIHBvcnQgcG9ydCk7Cj4gK2Jvb2wgaW50ZWxfZHBfaXNfZWRwKHN0cnVjdCBkcm1faTkx NV9wcml2YXRlICpkZXZfcHJpdiwgZW51bSBwb3J0IHBvcnQpOwo+ICBlbnVtIGlycXJldHVybiBp bnRlbF9kcF9ocGRfcHVsc2Uoc3RydWN0IGludGVsX2RpZ2l0YWxfcG9ydCAqaW50ZWxfZGlnX3Bv cnQsCj4gIAkJCQkgIGJvb2wgbG9uZ19ocGQpOwo+ICB2b2lkIGludGVsX2VkcF9iYWNrbGlnaHRf b24oc3RydWN0IGludGVsX2RwICppbnRlbF9kcCk7CgpSZXZpZXdlZC1ieTogTWFhcnRlbiBMYW5r aG9yc3QgPG1hYXJ0ZW4ubGFua2hvcnN0QGxpbnV4LmludGVsLmNvbT4KCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QK SW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9w Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=