Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,NORMAL_HTTP_TO_IP,NUMERIC_HTTP_ADDR, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F0A6C433E0 for ; Fri, 22 Jan 2021 09:48:59 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1C94C235F7 for ; Fri, 22 Jan 2021 09:48:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1C94C235F7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:34522 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l2t3q-0004wL-0O for qemu-devel@archiver.kernel.org; Fri, 22 Jan 2021 04:48:58 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:43156) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l2t2f-00046n-Kd for qemu-devel@nongnu.org; Fri, 22 Jan 2021 04:47:46 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:37200) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l2t2X-0005Lq-Re for qemu-devel@nongnu.org; Fri, 22 Jan 2021 04:47:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611308856; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kxxFOGTaeqpyBkDIBzCGPkzlgi9X+Xb1B/2zBw58liQ=; b=hWV6SF09vkxtrj2BmcOSkbcuPqQyMJi4yHX1JajTiOwb9GEA6fExr4xhA5BZVaaIIDtZeN 0UF8gw1fKgqvpFbLZcPGJyB/Uh209OtozLsVESFaH4MrFJbZYBbw+L9NGJFJy30eTpSB+u 076Xi8m7fdjIMau2qzmvspJSbXLqIbw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-90-ms-JIiOVPfyU7NrRIiot8w-1; Fri, 22 Jan 2021 04:47:34 -0500 X-MC-Unique: ms-JIiOVPfyU7NrRIiot8w-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B73A9806665; Fri, 22 Jan 2021 09:47:33 +0000 (UTC) Received: from thuth.remote.csb (ovpn-112-109.ams2.redhat.com [10.36.112.109]) by smtp.corp.redhat.com (Postfix) with ESMTP id 45C5B2CFB1; Fri, 22 Jan 2021 09:47:32 +0000 (UTC) Subject: Re: [PATCH 2/2] meson: Warn when TCI is selected but TCG backend is available To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= References: <20210122092205.1855659-1-philmd@redhat.com> <20210122092205.1855659-3-philmd@redhat.com> From: Thomas Huth Message-ID: Date: Fri, 22 Jan 2021 10:47:31 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=thuth@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=63.128.21.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.168, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Stefan Weil , Richard Henderson , "Daniel P . Berrange" , QEMU Developers , Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 22/01/2021 10.46, Philippe Mathieu-Daudé wrote: > On Fri, Jan 22, 2021 at 10:43 AM Thomas Huth wrote: >> On 22/01/2021 10.22, Philippe Mathieu-Daudé wrote: >>> Some new users get confused with 'TCG' and 'TCI', and enable TCI >>> support expecting to enable TCG. >>> >>> Emit a warning when native TCG backend is available on the >>> host architecture, mentioning this is a suboptimal configuration. >>> >>> Signed-off-by: Philippe Mathieu-Daudé >>> --- >>> meson.build | 3 +++ >>> 1 file changed, 3 insertions(+) >>> >>> diff --git a/meson.build b/meson.build >>> index 0a645e54662..7aa52d306c6 100644 >>> --- a/meson.build >>> +++ b/meson.build >>> @@ -234,6 +234,9 @@ >>> error('Unsupported CPU @0@, try --enable-tcg-interpreter'.format(cpu)) >>> endif >>> endif >>> + if 'CONFIG_TCG_INTERPRETER' in config_host and cpu in supported_cpus >>> + warning('Experimental TCI requested while native TCG is available on @0@, suboptimal performance expected'.format(cpu)) >>> + endif >>> accelerators += 'CONFIG_TCG' >>> config_host += { 'CONFIG_TCG': 'y' } >>> endif >>> >> >> Reviewed-by: Thomas Huth >> >> ... maybe you could also add some wording to the help text of the configure >> script? Or maybe we could simply rename the "--enable-tcg-interpreter" >> option into "--enable-tci" to avoid confusion with the normal TCG ? > > I also thought about renaming as --enable-experimental-tci but then doubt that > would help, some users just want to enable everything :) Then we should rename it into --disable-native-tcg ;-) Thomas