From: gowrishankar muthukrishnan Subject: Re: [PATCH v5 4/8] table: enable table library for ppc64le Date: Tue, 16 Aug 2016 16:04:51 +0530 Message-ID: References: <1471003413-20685-1-git-send-email-gowrishankar.m@linux.vnet.ibm.com> <1471003413-20685-5-git-send-email-gowrishankar.m@linux.vnet.ibm.com> <000001d1f793$b93a8b90$2bafa2b0$@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=gbk; format=flowed Content-Transfer-Encoding: 8bit Cc: "'Bruce Richardson'" , "'Konstantin Ananyev'" , "'Thomas Monjalon'" , "'Cristian Dumitrescu'" , "'Pradeep'" To: Chao Zhu , dev@dpdk.org Return-path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by dpdk.org (Postfix) with ESMTP id BA67F6A44 for ; Tue, 16 Aug 2016 12:35:09 +0200 (CEST) Received: from pps.filterd (m0098399.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.11/8.16.0.11) with SMTP id u7GAXkgg043545 for ; Tue, 16 Aug 2016 06:35:09 -0400 Received: from e28smtp01.in.ibm.com (e28smtp01.in.ibm.com [125.16.236.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 24syq3mfdf-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Tue, 16 Aug 2016 06:35:08 -0400 Received: from localhost by e28smtp01.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 16 Aug 2016 16:05:05 +0530 Received: from d28relay10.in.ibm.com (d28relay10.in.ibm.com [9.184.220.161]) by d28dlp02.in.ibm.com (Postfix) with ESMTP id 7A70A3940064 for ; Tue, 16 Aug 2016 16:05:03 +0530 (IST) Received: from d28av02.in.ibm.com (d28av02.in.ibm.com [9.184.220.64]) by d28relay10.in.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u7GAZ2jZ37093606 for ; Tue, 16 Aug 2016 16:05:02 +0530 Received: from d28av02.in.ibm.com (localhost [127.0.0.1]) by d28av02.in.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u7GAZ0pe015740 for ; Tue, 16 Aug 2016 16:05:01 +0530 In-Reply-To: <000001d1f793$b93a8b90$2bafa2b0$@linux.vnet.ibm.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Thanks Chao for bringing up. I had fixed one of .c earlier before rebasing to master. I then dropped the patch while decoupling ppc enablement and bug fixes. Now I realize on why we need this fix as part of enabling table in ppc completely. So, added one additional patch separately fixing this in v6. After this patch, a ltable lib unit test fail as in Intel case currently and it is not related to powerpc changes. If some one already looking into broken unit test failure for table lib, that is helpful. Regards, Gowrishankar On Tuesday 16 August 2016 01:26 PM, Chao Zhu wrote: > Gowrishankar, > > The unit test of table got failed. > When I took a look at the code, it failed on this line in file > lib/librte_table/rte_table_hash_key8.c , > lib/librte_table/rte_table_hash_key16.c, > lib/librte_table/rte_table_hash_key32.c: > > if ((check_params_create_lru(p) != 0) || > ((sizeof(struct rte_table_hash) % RTE_CACHE_LINE_SIZE) != 0) > || > ((sizeof(struct rte_bucket_4_8) % RTE_CACHE_LINE_SIZE) != > 0)) { > return NULL; > } > > if ((check_params_create_lru(p) != 0) || > ((sizeof(struct rte_table_hash) % RTE_CACHE_LINE_SIZE) != 0) > || > ((sizeof(struct rte_bucket_4_16) % RTE_CACHE_LINE_SIZE) != > 0)) { > return NULL; > } > > if ((check_params_create_lru(p) != 0) || > ((sizeof(struct rte_table_hash) % RTE_CACHE_LINE_SIZE) != 0) > || > ((sizeof(struct rte_bucket_4_32) % RTE_CACHE_LINE_SIZE) != > 0)) { > return NULL; > } > > The size of rte_bucket_4_8/16/32 is not aligned to cache line size. This is > normal, because POWER has different cache line size. The change of struct > rte_bucket_4_8/16/32 may solve this problem. I didn't do further > investigation. Can you help to double check this patch? > > > -----Original Message----- > From: Gowrishankar Muthukrishnan [mailto:gowrishankar.m@linux.vnet.ibm.com] > Sent: 2016Äê8ÔÂ12ÈÕ 20:03 > To: dev@dpdk.org > Cc: Chao Zhu ; Bruce Richardson > ; Konstantin Ananyev > ; Thomas Monjalon ; > Cristian Dumitrescu ; Pradeep > ; gowrishankar > Subject: [PATCH v5 4/8] table: enable table library for ppc64le > > From: gowrishankar > > This patch enables librte_table in ppc64le. > > Signed-off-by: Gowrishankar Muthukrishnan > > --- > config/defconfig_ppc_64-power8-linuxapp-gcc | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/config/defconfig_ppc_64-power8-linuxapp-gcc > b/config/defconfig_ppc_64-power8-linuxapp-gcc > index dede34f..41f67d5 100644 > --- a/config/defconfig_ppc_64-power8-linuxapp-gcc > +++ b/config/defconfig_ppc_64-power8-linuxapp-gcc > @@ -59,5 +59,4 @@ CONFIG_RTE_LIBRTE_FM10K_PMD=n # This following libraries > are not available on Power. So they're turned off. > CONFIG_RTE_LIBRTE_SCHED=n > CONFIG_RTE_LIBRTE_PORT=n > -CONFIG_RTE_LIBRTE_TABLE=n > CONFIG_RTE_LIBRTE_PIPELINE=n > -- > 1.9.1 > > >