From: Andres Rodriguez Subject: Re: [PATCH 1/3] drm/amdgpu: Avoid accessing job->entity after the job is scheduled. Date: Fri, 20 Oct 2017 11:59:01 -0400 Message-ID: References: <1508506327-1084-1-git-send-email-Andrey.Grodzovsky@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1508506327-1084-1-git-send-email-Andrey.Grodzovsky-5C7GfCeVMHo@public.gmane.org> Content-Language: en-US List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: Andrey Grodzovsky , amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Cc: christian.koenig-5C7GfCeVMHo@public.gmane.org CgpPbiAyMDE3LTEwLTIwIDA5OjMyIEFNLCBBbmRyZXkgR3JvZHpvdnNreSB3cm90ZToKPiBCdWc6 IGFtZGdwdV9qb2JfZnJlZV9jYiB3YXMgYWNjZXNzaW5nIHNfam9iLT5zX2VudGl0eSB3aGVuIHRo ZSBhbGxvY2F0ZWQKPiBhbWRncHVfY3R4IChhbmQgdGhlIGVudGl0eSBpbnNpZGUgaXQpIHdlcmUg YWxyZWFkeSBkZWFsbG9jYXRlZCBmcm9tCj4gYW1kZ3B1X2NzX3BhcnNlcl9maW5pLgo+IAo+IEZp eDogU2F2ZSBqb2IncyBwcmlvcml0eSBvbiBpdCdzIGNyZWF0aW9uIGluc3RlYWQgb2YgYWNjZXNz aW5nIGl0IGZyb20KPiBzX2VudGl0eSBsYXRlciBvbi4KCkknbSBub3Qgc3VyZSBpZiB0aGlzIGlz IHRoZSBjb3JyZWN0IGFwcHJvYWNoIGZvciBhIGZpeC4KCktlZXBpbmcgc19lbnRpdHkgYXMgYSBk YW5nbGluZyBwb2ludGVyIGNvdWxkIHJlc3VsdCBpbiBhIHNpbWlsYXIgYnVncyAKYmVpbmcgcmVp bnRyb2R1Y2VkLiBGb3IgZXhhbXBsZSwgdGhlcmUgd291bGQgc3RpbGwgYmUgYSByYWNlIGNvbmRp dGlvbiAKYmV0d2VlbiBhbWRncHVfY3NfcGFyc2VyX2ZpbmkoKSBhbmQgYW1kZ3B1X2pvYl9kZXBl bmRlbmN5KCkuCgpJbnN0ZWFkLCBpdCBtaWdodCBiZSBiZXR0ZXIgZm9yIHRoZSBqb2IgdG8gZ3Jh YiBhIHJlZmVyZW5jZSB0byB0aGUgCmNvbnRleHQgZHVyaW5nIGpvYl9pbml0KCksIGFuZCBwdXQg dGhhdCByZWZlcmVuY2Ugb24gam9iIGZyZWUuCgpSZWdhcmRzLApBbmRyZXMKCj4gCj4gU2lnbmVk LW9mZi1ieTogQW5kcmV5IEdyb2R6b3Zza3kgPEFuZHJleS5Hcm9kem92c2t5QGFtZC5jb20+Cj4g LS0tCj4gICBkcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfY3MuYyAgICAgICAgfCAg MyArLS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9qb2IuYyAgICAgICB8 ICA1ICsrLS0tCj4gICBkcml2ZXJzL2dwdS9kcm0vYW1kL3NjaGVkdWxlci9ncHVfc2NoZWR1bGVy LmMgfCAgMSArCj4gICBkcml2ZXJzL2dwdS9kcm0vYW1kL3NjaGVkdWxlci9ncHVfc2NoZWR1bGVy LmggfCAzMiArKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0KPiAgIDQgZmlsZXMgY2hhbmdlZCwg MTggaW5zZXJ0aW9ucygrKSwgMjMgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9jcy5jIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9h bWRncHUvYW1kZ3B1X2NzLmMKPiBpbmRleCBmN2ZjZWI2Li5hNzYwYjZlIDEwMDY0NAo+IC0tLSBh L2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9jcy5jCj4gKysrIGIvZHJpdmVycy9n cHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2NzLmMKPiBAQCAtMTE5Miw4ICsxMTkyLDcgQEAgc3Rh dGljIGludCBhbWRncHVfY3Nfc3VibWl0KHN0cnVjdCBhbWRncHVfY3NfcGFyc2VyICpwLAo+ICAg CWpvYi0+dWZfc2VxdWVuY2UgPSBzZXE7Cj4gICAKPiAgIAlhbWRncHVfam9iX2ZyZWVfcmVzb3Vy Y2VzKGpvYik7Cj4gLQlhbWRncHVfcmluZ19wcmlvcml0eV9nZXQoam9iLT5yaW5nLAo+IC0JCQkJ IGFtZF9zY2hlZF9nZXRfam9iX3ByaW9yaXR5KCZqb2ItPmJhc2UpKTsKPiArCWFtZGdwdV9yaW5n X3ByaW9yaXR5X2dldChqb2ItPnJpbmcsIGpvYi0+YmFzZS5zX3ByaW9yaXR5KTsKPiAgIAo+ICAg CXRyYWNlX2FtZGdwdV9jc19pb2N0bChqb2IpOwo+ICAgCWFtZF9zY2hlZF9lbnRpdHlfcHVzaF9q b2IoJmpvYi0+YmFzZSk7Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1 L2FtZGdwdV9qb2IuYyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9qb2IuYwo+ IGluZGV4IDBjZmM2OGQuLmE1OGUzYzUgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2Ft ZC9hbWRncHUvYW1kZ3B1X2pvYi5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUv YW1kZ3B1X2pvYi5jCj4gQEAgLTEwNCw3ICsxMDQsNyBAQCBzdGF0aWMgdm9pZCBhbWRncHVfam9i X2ZyZWVfY2Ioc3RydWN0IGFtZF9zY2hlZF9qb2IgKnNfam9iKQo+ICAgewo+ICAgCXN0cnVjdCBh bWRncHVfam9iICpqb2IgPSBjb250YWluZXJfb2Yoc19qb2IsIHN0cnVjdCBhbWRncHVfam9iLCBi YXNlKTsKPiAgIAo+IC0JYW1kZ3B1X3JpbmdfcHJpb3JpdHlfcHV0KGpvYi0+cmluZywgYW1kX3Nj aGVkX2dldF9qb2JfcHJpb3JpdHkoc19qb2IpKTsKPiArCWFtZGdwdV9yaW5nX3ByaW9yaXR5X3B1 dChqb2ItPnJpbmcsIHNfam9iLT5zX3ByaW9yaXR5KTsKPiAgIAlkbWFfZmVuY2VfcHV0KGpvYi0+ ZmVuY2UpOwo+ICAgCWFtZGdwdV9zeW5jX2ZyZWUoJmpvYi0+c3luYyk7Cj4gICAJYW1kZ3B1X3N5 bmNfZnJlZSgmam9iLT5kZXBfc3luYyk7Cj4gQEAgLTE0MSw4ICsxNDEsNyBAQCBpbnQgYW1kZ3B1 X2pvYl9zdWJtaXQoc3RydWN0IGFtZGdwdV9qb2IgKmpvYiwgc3RydWN0IGFtZGdwdV9yaW5nICpy aW5nLAo+ICAgCWpvYi0+ZmVuY2VfY3R4ID0gZW50aXR5LT5mZW5jZV9jb250ZXh0Owo+ICAgCSpm ID0gZG1hX2ZlbmNlX2dldCgmam9iLT5iYXNlLnNfZmVuY2UtPmZpbmlzaGVkKTsKPiAgIAlhbWRn cHVfam9iX2ZyZWVfcmVzb3VyY2VzKGpvYik7Cj4gLQlhbWRncHVfcmluZ19wcmlvcml0eV9nZXQo am9iLT5yaW5nLAo+IC0JCQkJIGFtZF9zY2hlZF9nZXRfam9iX3ByaW9yaXR5KCZqb2ItPmJhc2Up KTsKPiArCWFtZGdwdV9yaW5nX3ByaW9yaXR5X2dldChqb2ItPnJpbmcsIGpvYi0+YmFzZS5zX3By aW9yaXR5KTsKPiAgIAlhbWRfc2NoZWRfZW50aXR5X3B1c2hfam9iKCZqb2ItPmJhc2UpOwo+ICAg Cj4gICAJcmV0dXJuIDA7Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvc2NoZWR1 bGVyL2dwdV9zY2hlZHVsZXIuYyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvc2NoZWR1bGVyL2dwdV9z Y2hlZHVsZXIuYwo+IGluZGV4IGU0ZDNiNGUuLjFiYmJjZTIgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVy cy9ncHUvZHJtL2FtZC9zY2hlZHVsZXIvZ3B1X3NjaGVkdWxlci5jCj4gKysrIGIvZHJpdmVycy9n cHUvZHJtL2FtZC9zY2hlZHVsZXIvZ3B1X3NjaGVkdWxlci5jCj4gQEAgLTUyOSw2ICs1MjksNyBA QCBpbnQgYW1kX3NjaGVkX2pvYl9pbml0KHN0cnVjdCBhbWRfc2NoZWRfam9iICpqb2IsCj4gICB7 Cj4gICAJam9iLT5zY2hlZCA9IHNjaGVkOwo+ICAgCWpvYi0+c19lbnRpdHkgPSBlbnRpdHk7Cj4g Kwlqb2ItPnNfcHJpb3JpdHkgPSBlbnRpdHktPnJxIC0gc2NoZWQtPnNjaGVkX3JxOwo+ICAgCWpv Yi0+c19mZW5jZSA9IGFtZF9zY2hlZF9mZW5jZV9jcmVhdGUoZW50aXR5LCBvd25lcik7Cj4gICAJ aWYgKCFqb2ItPnNfZmVuY2UpCj4gICAJCXJldHVybiAtRU5PTUVNOwo+IGRpZmYgLS1naXQgYS9k cml2ZXJzL2dwdS9kcm0vYW1kL3NjaGVkdWxlci9ncHVfc2NoZWR1bGVyLmggYi9kcml2ZXJzL2dw dS9kcm0vYW1kL3NjaGVkdWxlci9ncHVfc2NoZWR1bGVyLmgKPiBpbmRleCA1MmM4ZTU0Li4zZjc1 YjQ1IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvc2NoZWR1bGVyL2dwdV9zY2hl ZHVsZXIuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvc2NoZWR1bGVyL2dwdV9zY2hlZHVs ZXIuaAo+IEBAIC0zMCw2ICszMCwxOSBAQAo+ICAgc3RydWN0IGFtZF9ncHVfc2NoZWR1bGVyOwo+ ICAgc3RydWN0IGFtZF9zY2hlZF9ycTsKPiAgIAo+ICtlbnVtIGFtZF9zY2hlZF9wcmlvcml0eSB7 Cj4gKwlBTURfU0NIRURfUFJJT1JJVFlfTUlOLAo+ICsJQU1EX1NDSEVEX1BSSU9SSVRZX0xPVyA9 IEFNRF9TQ0hFRF9QUklPUklUWV9NSU4sCj4gKwlBTURfU0NIRURfUFJJT1JJVFlfTk9STUFMLAo+ ICsJQU1EX1NDSEVEX1BSSU9SSVRZX0hJR0hfU1csCj4gKwlBTURfU0NIRURfUFJJT1JJVFlfSElH SF9IVywKPiArCUFNRF9TQ0hFRF9QUklPUklUWV9LRVJORUwsCj4gKwlBTURfU0NIRURfUFJJT1JJ VFlfTUFYLAo+ICsJQU1EX1NDSEVEX1BSSU9SSVRZX0lOVkFMSUQgPSAtMSwKPiArCUFNRF9TQ0hF RF9QUklPUklUWV9VTlNFVCA9IC0yCj4gK307Cj4gKwo+ICsKPiAgIC8qKgo+ICAgICogQSBzY2hl ZHVsZXIgZW50aXR5IGlzIGEgd3JhcHBlciBhcm91bmQgYSBqb2IgcXVldWUgb3IgYSBncm91cAo+ ICAgICogb2Ygb3RoZXIgZW50aXRpZXMuIEVudGl0aWVzIHRha2UgdHVybnMgZW1pdHRpbmcgam9i cyBmcm9tIHRoZWlyCj4gQEAgLTgzLDYgKzk2LDcgQEAgc3RydWN0IGFtZF9zY2hlZF9qb2Igewo+ ICAgCXN0cnVjdCBkZWxheWVkX3dvcmsJCXdvcmtfdGRyOwo+ICAgCXVpbnQ2NF90CQkJaWQ7Cj4g ICAJYXRvbWljX3Qga2FybWE7Cj4gKwllbnVtIGFtZF9zY2hlZF9wcmlvcml0eSBzX3ByaW9yaXR5 Owo+ICAgfTsKPiAgIAo+ICAgZXh0ZXJuIGNvbnN0IHN0cnVjdCBkbWFfZmVuY2Vfb3BzIGFtZF9z Y2hlZF9mZW5jZV9vcHNfc2NoZWR1bGVkOwo+IEBAIC0xMTQsMTggKzEyOCw2IEBAIHN0cnVjdCBh bWRfc2NoZWRfYmFja2VuZF9vcHMgewo+ICAgCXZvaWQgKCpmcmVlX2pvYikoc3RydWN0IGFtZF9z Y2hlZF9qb2IgKnNjaGVkX2pvYik7Cj4gICB9Owo+ICAgCj4gLWVudW0gYW1kX3NjaGVkX3ByaW9y aXR5IHsKPiAtCUFNRF9TQ0hFRF9QUklPUklUWV9NSU4sCj4gLQlBTURfU0NIRURfUFJJT1JJVFlf TE9XID0gQU1EX1NDSEVEX1BSSU9SSVRZX01JTiwKPiAtCUFNRF9TQ0hFRF9QUklPUklUWV9OT1JN QUwsCj4gLQlBTURfU0NIRURfUFJJT1JJVFlfSElHSF9TVywKPiAtCUFNRF9TQ0hFRF9QUklPUklU WV9ISUdIX0hXLAo+IC0JQU1EX1NDSEVEX1BSSU9SSVRZX0tFUk5FTCwKPiAtCUFNRF9TQ0hFRF9Q UklPUklUWV9NQVgsCj4gLQlBTURfU0NIRURfUFJJT1JJVFlfSU5WQUxJRCA9IC0xLAo+IC0JQU1E X1NDSEVEX1BSSU9SSVRZX1VOU0VUID0gLTIKPiAtfTsKPiAtCj4gICAvKioKPiAgICAqIE9uZSBz Y2hlZHVsZXIgaXMgaW1wbGVtZW50ZWQgZm9yIGVhY2ggaGFyZHdhcmUgcmluZwo+ICAgKi8KPiBA QCAtMTc2LDEwICsxNzgsNCBAQCBib29sIGFtZF9zY2hlZF9kZXBlbmRlbmN5X29wdGltaXplZChz dHJ1Y3QgZG1hX2ZlbmNlKiBmZW5jZSwKPiAgIAkJCQkgICAgc3RydWN0IGFtZF9zY2hlZF9lbnRp dHkgKmVudGl0eSk7Cj4gICB2b2lkIGFtZF9zY2hlZF9qb2Jfa2lja291dChzdHJ1Y3QgYW1kX3Nj aGVkX2pvYiAqc19qb2IpOwo+ICAgCj4gLXN0YXRpYyBpbmxpbmUgZW51bSBhbWRfc2NoZWRfcHJp b3JpdHkKPiAtYW1kX3NjaGVkX2dldF9qb2JfcHJpb3JpdHkoc3RydWN0IGFtZF9zY2hlZF9qb2Ig KmpvYikKPiAtewo+IC0JcmV0dXJuIChqb2ItPnNfZW50aXR5LT5ycSAtIGpvYi0+c2NoZWQtPnNj aGVkX3JxKTsKPiAtfQo+IC0KPiAgICNlbmRpZgo+IApfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwphbWQtZ2Z4IG1haWxpbmcgbGlzdAphbWQtZ2Z4QGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2FtZC1nZngK