From: "flichtenheld (Code Review)" Date: Wed, 6 Aug 2025 14:29:39 +0000 References: Reply-To: frank@...2641..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="nKlbdWb12/I="; charset=UTF-8 Subject: [Openvpn-devel] [XS] Change in openvpn[master]: buffer: remove unused function buf_write_alloc_prepend List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos Cc: openvpn-devel --nKlbdWb12/I= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1134?usp=3Demail to review the following change. Change subject: buffer: remove unused function buf_write_alloc_prepend ...................................................................... buffer: remove unused function buf_write_alloc_prepend Change-Id: I71981e39932cafe3fd68b475fdb81a8f20a3a547 Signed-off-by: Frank Lichtenheld --- M src/openvpn/buffer.h 1 file changed, 0 insertions(+), 6 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/34/1134/1 diff --git a/src/openvpn/buffer.h b/src/openvpn/buffer.h index 8d6bb64..6f15115 100644 --- a/src/openvpn/buffer.h +++ b/src/openvpn/buffer.h @@ -644,12 +644,6 @@ } static inline uint8_t * -buf_write_alloc_prepend(struct buffer *buf, int size, bool prepend) -{ - return prepend ? buf_prepend(buf, size) : buf_write_alloc(buf, size); -} - -static inline uint8_t * buf_read_alloc(struct buffer *buf, int size) { uint8_t *ret; -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1134?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I71981e39932cafe3fd68b475fdb81a8f20a3a547 Gerrit-Change-Number: 1134 Gerrit-PatchSet: 1 Gerrit-Owner: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-MessageType: newchange --nKlbdWb12/I= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: plaisthos.

flichtenheld would like plaisthos to review this change.

V= iew Change

buffer: remove unused function buf_write_alloc_prepend
Change-Id: I71981e39932cafe3fd68b475fdb81a8f20a3a547
Signed-off-by: Fr= ank Lichtenheld <frank@...2641...>
---
M src/openvpn/buffer.h1 file changed, 0 insertions(+), 6 deletions(-)

git pull ssh:=
//gerrit.openvpn.net:29418/openvpn refs/changes/34/1134/1
diff --=
git a/src/openvpn/buffer.h b/src/openvpn/buffer.h
index 8d6= bb64..6f15115 100644
--- a/src/openvpn/buffer.h
<= span>+++ b/src/openvpn/buffer.h
@@ -644,12 +644,6 @@=
}

static inline uint8_t *
-buf_write_alloc_prepend(s= truct buffer *buf, int size, bool prepend)
-{
= - return prepend ? buf_prepend(buf, size) : buf_write_alloc(buf, size);<= /span>
-}
-
-static inline uint8_t *
buf_read_alloc(struct = buffer *buf, int size)
{
uint8_t *ret= ;

To view, visit change 1134. To unsubscrib= e, or for help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I71981e39932cafe3fd68b475fdb= 81a8f20a3a547
Gerrit-Change-Number: 1134
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-MessageType: newchange
--nKlbdWb12/I=--