From: "plaisthos (Code Review)"
Date: Thu, 7 Dec 2023 11:27:23 +0000
In-Reply-To:
References:
Reply-To: arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net,
frank@...2641..., gert@...1296...
Message-ID:
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Content-Type: multipart/alternative; boundary="w4lcfpQEceo="; charset=UTF-8
Subject: [Openvpn-devel] [M] Change in openvpn[master]: Implement the
--tls-export-cert feature
List-Id:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
Cc: flichtenheld , cron2 , openvpn-devel
--w4lcfpQEceo=
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: cron2, flichtenheld.
plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c=
/openvpn/+/466?usp=3Demail )
Change subject: Implement the --tls-export-cert feature
......................................................................
Patch Set 2:
(6 comments)
File doc/man-sections/script-options.rst:
http://gerrit.openvpn.net/c/openvpn/+/466/comment/dccfc964_cfd463f3 :
PS2, Line 427: Adds a an environment variables ``peer_cert_{x}`` (and an =
alias
> Remove "a"
Done
File src/openvpn/ssl_verify.c:
http://gerrit.openvpn.net/c/openvpn/+/466/comment/2e49f9a9_cc253bc2 :
PS2, Line 466: /* export the certificate itself as pem when the enabled=
*/
> missing words?
Done
http://gerrit.openvpn.net/c/openvpn/+/466/comment/99393580_9e01f59d :
PS2, Line 477: bool ret =3D true;
> Can combine with the next line.
Done
http://gerrit.openvpn.net/c/openvpn/+/466/comment/9626e926_96849b76 :
PS2, Line 602: * these variables defined */
> can replace repetition of "these variables" with "them"
Done
File src/openvpn/ssl_verify_mbedtls.c:
http://gerrit.openvpn.net/c/openvpn/+/466/comment/32a92534_6ee0a5db :
PS2, Line 225: * The only way to is directly access the DER encoded ra=
w certificate
> "to is" -> "is to"
Done
http://gerrit.openvpn.net/c/openvpn/+/466/comment/85213291_05de576e :
PS2, Line 230: * using needing 3 times the space for the base64 and 10=
0 bytes for the
> drop one of "using needing"
Done
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/466?usp=3Demail
To unsubscribe, or for help writing mail filters, visit http://gerrit.openv=
pn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ia9b3f1813d2d0d492d17c87348b4cebd0bf19ce2
Gerrit-Change-Number: 466
Gerrit-PatchSet: 2
Gerrit-Owner: plaisthos
Gerrit-Reviewer: flichtenheld
Gerrit-CC: cron2
Gerrit-CC: openvpn-devel
Gerrit-Attention: cron2
Gerrit-Attention: flichtenheld
Gerrit-Comment-Date: Thu, 07 Dec 2023 11:27:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: flichtenheld
Gerrit-MessageType: comment
--w4lcfpQEceo=
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: cron2, flichtenheld.
View C=
hange
6 comments:
Done
=
Patch Set #2, Line 477: bool ret =3D true;
Can combine with the next lin=
e.
Done
Patch Set #2, Line 602: * these variables defined */
can replace repetition of "these variables" with "the=
m"
Done
File=
src/openvpn/ssl_verify_mbedtls.c:
Patch Set #2, Line 225: * The only way to is directly access the DER encoded =
raw certificate
"to is" -> "is to&q=
uot;
Done
Patch Set #2, Line 230: * using needing 3 times the space for the =
base64 and 100 bytes for the
drop one of "using =
needing"
Done
To view, visit change 466. To unsub=
scribe, or for help writing mail filters, visit settings.
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ia9b3f1813d2d0d492d17c87348b=
4cebd0bf19ce2
Gerrit-Change-Number: 466
Gerrit-PatchSet: 2
Gerrit-Owner: plaisthos <arne-openvpn@...1711...=
27...>
Gerrit-Reviewer: flichtenheld <frank@...2716...=
1...>
Gerrit-CC: cron2 <gert@...1296...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...=
ts.sourceforge.net>
Gerrit-Attention: cron2 <gert@...1296...>=
;
Gerrit-Attention: flichtenheld <frank@...2375...=
41...>
Gerrit-Comment-Date: Thu, 07 Dec 2023 11:27:23=
+0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: flichtenheld <frank@...1186...=
.2641...>
Gerrit-MessageType: comment
--w4lcfpQEceo=--