Message-ID: Date: Fri, 18 Jul 2025 16:07:08 +0200 MIME-Version: 1.0 References: Content-Language: en-US From: Antonio Quartulli In-Reply-To: Subject: Re: [Openvpn-devel] [PATCH ovpn] net: ovpn: use correct array size to parse nested attributes in ovpn_nl_key_swap_doit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit To: Sabrina Dubroca Cc: openvpn-devel@lists.sourceforge.net On 14/07/2025 16:20, Sabrina Dubroca wrote: > In ovpn_nl_key_swap_doit, the attributes array used to parse the > OVPN_A_KEYCONF uses OVPN_A_PEER_MAX instead of > OVPN_A_KEYCONF_MAX. Note that this does not cause any bug, since > currently OVPN_A_KEYCONF_MAX < OVPN_A_PEER_MAX. > > Fixes: 203e2bf55990 ("ovpn: implement key add/get/del/swap via netlink") > Signed-off-by: Sabrina Dubroca Nice catch, thanks a lot! As you suggested I fixed the reverse christmas-tree while applying this patch. It's now queued for sending to net-next. Regards, -- Antonio Quartulli