Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 99CBCC433FE for ; Sat, 22 Oct 2022 23:33:05 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id EE58084DEB; Sun, 23 Oct 2022 01:33:01 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=benettiengineering.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=aruba.it header.i=@aruba.it header.b="buXDrDeK"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 3F4DE84EA8; Sun, 23 Oct 2022 01:32:59 +0200 (CEST) Received: from smtpcmd0986.aruba.it (smtpcmd0986.aruba.it [62.149.156.86]) by phobos.denx.de (Postfix) with ESMTP id 321F184DEB for ; Sun, 23 Oct 2022 01:32:56 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=benettiengineering.com Authentication-Results: phobos.denx.de; spf=none smtp.mailfrom=giulio.benetti@benettiengineering.com Received: from [192.168.50.18] ([146.241.87.206]) by Aruba Outgoing Smtp with ESMTPSA id mNz5o8GuPaWj1mNz5oyAyd; Sun, 23 Oct 2022 01:32:55 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=aruba.it; s=a1; t=1666481575; bh=0ELd3s90GdgyNQ+zAlPqiOhFCbDTxYKSn5ApjJk6Cf4=; h=Date:MIME-Version:Subject:To:From:Content-Type; b=buXDrDeKOou2XyLJ8WzueZQdkr2BYZLRw+knPTjkMq3mpRotVECnoaCGpN/+mR4VW POXe/XyqMqQV203UK6Z0Y2WvrAyX4yUMT+dbzKWc6XK+e345Lu/HklCBUy0Md4Cy4C PVaQU3PEaCgq8XpeQ4Tim8hBC9MnrOZkjLHUYQish5/p2mKGbx+h7b3dTFHbjTp7eb UkdT1yFo+EDHXjyswYCbxxNDB0/yNQmvyqMHVy9V/YnTEoXzY+xwPbNjFGJ8kvt54r QXlexGBnfrGj+6is4WStZ7NyuVG9+vP03qi3d/Ip5Yefc6CAO91nxIcOdtCqNhQGkb eVpQVLylwQsNQ== Message-ID: Date: Sun, 23 Oct 2022 01:32:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH v3 2/8] imxrt1020: fix lpuart issue in common u-boot device tree To: Marcel Ziswiler , u-boot@lists.denx.de Cc: Fabio Estevam , Jesse Taube , Marcel Ziswiler , "NXP i.MX U-Boot Team" , Stefano Babic References: <20221022214233.82467-1-marcel@ziswiler.com> <20221022214233.82467-3-marcel@ziswiler.com> From: Giulio Benetti In-Reply-To: <20221022214233.82467-3-marcel@ziswiler.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CMAE-Envelope: MS4xfP7zFnFWZHbUuCYez0BHkilbWFhuF3+NDu/RAfNkc7/xiShultHOYJR6+pVkV32+GVlvNyBNGZk+w0GA8MTFTwd/mbG6a7XJaLkXL2z8ASj217Hhbo57 AiCDWdmK4q12jBbzDnwrrJKnL9gZrCg/YD8QhCfNy8mwFZEn35oMZM5MmIVDtZyZx6EKJdlTvK7+KSsZlbCdccadLbjhvvKdnxxrlhZAM/d+j8oJ1CKGmk4J v2imvnMG2ygZZ4LyeHDoAcVhUB20A7XCvt0bKNT0Khnctgslt6HN6tKLxIZOHRww67g1bXLSHI7z1PPxIIl2RvAXQc6jR8+mLdsAhnvJQLRJ9qBH39yjY5Nd +he7Zs9OAz49nWpM/S5sJ2EggCac/dunLFNwSz28BpSLBDg3pq8= X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Hi Marcel, thanks for contributing, Il 22/10/2022 23:42, Marcel Ziswiler ha scritto: > From: Marcel Ziswiler > > Fix lpuart issue in common U-Boot device tree. There's no need to repeat in commit log the subject. > > Signed-off-by: Marcel Ziswiler > --- > > (no changes since v1) > > arch/arm/dts/imxrt1020-evk-u-boot.dtsi | 7 ++++--- > arch/arm/dts/imxrt1020-evk.dts | 1 - > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/arm/dts/imxrt1020-evk-u-boot.dtsi b/arch/arm/dts/imxrt1020-evk-u-boot.dtsi > index 9e1b074d2e..7cab486f5f 100644 > --- a/arch/arm/dts/imxrt1020-evk-u-boot.dtsi > +++ b/arch/arm/dts/imxrt1020-evk-u-boot.dtsi > @@ -67,9 +67,6 @@ > > imxrt1020-evk { > u-boot,dm-spl; > - pinctrl_lpuart1: lpuart1grp { > - u-boot,dm-spl; > - }; > > pinctrl_semc: semcgrp { > u-boot,dm-spl; > @@ -81,6 +78,10 @@ > }; > }; > > +&pinctrl_lpuart1 { > + u-boot,dm-spl; > +}; > + I don't understand the goal of this change, can you elaborate? As I remember pinctrl_lpuart1 already works correctly. The same goes for: pinctrl_semc pinctrl_usdhc0 So you're not fixing something. > &usdhc1 { > u-boot,dm-spl; > }; > diff --git a/arch/arm/dts/imxrt1020-evk.dts b/arch/arm/dts/imxrt1020-evk.dts > index 22ae5ed735..d4d1de4ea8 100644 > --- a/arch/arm/dts/imxrt1020-evk.dts > +++ b/arch/arm/dts/imxrt1020-evk.dts > @@ -6,7 +6,6 @@ > > /dts-v1/; > #include "imxrt1020.dtsi" > -#include "imxrt1020-evk-u-boot.dtsi" This ^^^ is needed, please revert it. > #include "imxrt1020-pinfunc.h" > > / { Have you also tested the change on a board? Best regards -- Giulio Benetti CEO/CTO@Benetti Engineering sas