From: Neil Armstrong Subject: Re: [PATCH] drm/bridge: dw-hdmi: Use automatic CTS generation mode when using non-AHB audio Date: Thu, 20 Jun 2019 16:38:13 +0200 Message-ID: References: <20190612085147.26971-1-narmstrong@baylibre.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8CF576E5AA for ; Thu, 20 Jun 2019 14:38:16 +0000 (UTC) Received: by mail-wr1-x442.google.com with SMTP id x17so3272467wrl.9 for ; Thu, 20 Jun 2019 07:38:16 -0700 (PDT) In-Reply-To: <20190612085147.26971-1-narmstrong@baylibre.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: a.hajda@samsung.com, Laurent.pinchart@ideasonboard.com Cc: Jernej Skrabec , Jonas Karlman , Maxime Ripard , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Jerome Brunet List-Id: dri-devel@lists.freedesktop.org SGkgQW5kcnplaiwKCkdlbnRsZSBwaW5nLCBkbyB5b3UgdGhpbmsgdGhpcyBjb3VsZCBnbyBpbiBk cm0tbWlzYy1uZXh0IGZvciA1LjMgPwoKVGhhbmtzLApOZWlsCgpPbiAxMi8wNi8yMDE5IDEwOjUx LCBOZWlsIEFybXN0cm9uZyB3cm90ZToKPiBXaGVuIHVzaW5nIGFuIEkyUyBzb3VyY2UgdXNpbmcg YSBkaWZmZXJlbnQgY2xvY2sgc291cmNlICh1c3VhbGx5IHRoZSBJMlMKPiBhdWRpbyBIVyB1c2Vz IGRlZGljYXRlZCBQTExzLCBkaWZmZXJlbnQgZnJvbSB0aGUgSERNSSBQSFkgUExMKSwgZml4ZWQK PiBDVFMgdmFsdWVzIHdpbGwgY2F1c2Ugc29tZSBmcmVxdWVudCBhdWRpbyBkcm9wLW91dCBhbmQg Z2xpdGNoZXMgYXMKPiByZXBvcnRlZCBvbiBBbWxvZ2ljLCBBbGx3aW5uZXIgYW5kIFJvY2tjaGlw IFNvQ3Mgc2V0dXBzLgo+IAo+IFNldHRpbmcgdGhlIENUUyBpbiBhdXRvbWF0aWMgbW9kZSB3aWxs IGxldCB0aGUgSERNSSBjb250cm9sbGVyIGdlbmVyYXRlCj4gYXV0b21hdGljYWxseSB0aGUgQ1RT IHZhbHVlIHRvIG1hdGNoIHRoZSBpbnB1dCBhdWRpbyBjbG9jay4KPiAKPiBUaGUgRGVzaWduV2Fy ZSBEVy1IRE1JIFVzZXIgR3VpZGUgZXhwbGFpbnM6Cj4gICBGb3IgQXV0b21hdGljIENUUyBnZW5l cmF0aW9uCj4gICBXcml0ZSAiMCIgb24gdGhlIGJpdCBmaWVsZCAiQ1RTX21hbnVhbCIsIFJlZ2lz dGVyIDB4MzIwNTogQVVEX0NUUzMKPiAKPiBUaGUgRGVzaWduV2FyZSBEVy1IRE1JIERhdGFib29r IGV4cGxhaW5zIDoKPiAgIElmICJDVFNfbWFudWFsIiBiaXQgZXF1YWxzIDBiIHRoaXMgcmVnaXN0 ZXJzIGNvbnRhaW5zICJhdWRDVFNbMTk6MF0iCj4gICBnZW5lcmF0ZWQgYnkgdGhlIEN5Y2xlIHRp bWUgY291bnRlciBhY2NvcmRpbmcgdG8gc3BlY2lmaWVkIHRpbWluZy4KPiAKPiBDYzogSmVybmVq IFNrcmFiZWMgPGplcm5lai5za3JhYmVjQHNpb2wubmV0Pgo+IENjOiBNYXhpbWUgUmlwYXJkIDxt YXhpbWUucmlwYXJkQGJvb3RsaW4uY29tPgo+IENjOiBKb25hcyBLYXJsbWFuIDxqb25hc0Brd2li b28uc2U+Cj4gQ2M6IEhlaWtvIFN0dWVibmVyIDxoZWlrb0BzbnRlY2guZGU+Cj4gQ2M6IEplcm9t ZSBCcnVuZXQgPGpicnVuZXRAYmF5bGlicmUuY29tPgo+IFNpZ25lZC1vZmYtYnk6IE5laWwgQXJt c3Ryb25nIDxuYXJtc3Ryb25nQGJheWxpYnJlLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJt L2JyaWRnZS9zeW5vcHN5cy9kdy1oZG1pLmMgfCA0NCArKysrKysrKysrKysrKystLS0tLS0tLQo+ ICAxIGZpbGUgY2hhbmdlZCwgMjkgaW5zZXJ0aW9ucygrKSwgMTUgZGVsZXRpb25zKC0pCj4gCj4g ZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9icmlkZ2Uvc3lub3BzeXMvZHctaGRtaS5jIGIv ZHJpdmVycy9ncHUvZHJtL2JyaWRnZS9zeW5vcHN5cy9kdy1oZG1pLmMKPiBpbmRleCBjNjhiNmVk MWJiMzUuLjY0NThjM2EzMWQyMyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vYnJpZGdl L3N5bm9wc3lzL2R3LWhkbWkuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9icmlkZ2Uvc3lub3Bz eXMvZHctaGRtaS5jCj4gQEAgLTQzNyw4ICs0MzcsMTQgQEAgc3RhdGljIHZvaWQgaGRtaV9zZXRf Y3RzX24oc3RydWN0IGR3X2hkbWkgKmhkbWksIHVuc2lnbmVkIGludCBjdHMsCj4gIAkvKiBuc2hp ZnQgZmFjdG9yID0gMCAqLwo+ICAJaGRtaV9tb2RiKGhkbWksIDAsIEhETUlfQVVEX0NUUzNfTl9T SElGVF9NQVNLLCBIRE1JX0FVRF9DVFMzKTsKPiAgCj4gLQloZG1pX3dyaXRlYihoZG1pLCAoKGN0 cyA+PiAxNikgJiBIRE1JX0FVRF9DVFMzX0FVRENUUzE5XzE2X01BU0spIHwKPiAtCQkgICAgSERN SV9BVURfQ1RTM19DVFNfTUFOVUFMLCBIRE1JX0FVRF9DVFMzKTsKPiArCS8qIFVzZSBhdXRvbWF0 aWMgQ1RTIGdlbmVyYXRpb24gbW9kZSB3aGVuIENUUyBpcyBub3Qgc2V0ICovCj4gKwlpZiAoY3Rz KQo+ICsJCWhkbWlfd3JpdGViKGhkbWksICgoY3RzID4+IDE2KSAmCj4gKwkJCQkgICBIRE1JX0FV RF9DVFMzX0FVRENUUzE5XzE2X01BU0spIHwKPiArCQkJCSAgSERNSV9BVURfQ1RTM19DVFNfTUFO VUFMLAo+ICsJCQkgICAgSERNSV9BVURfQ1RTMyk7Cj4gKwllbHNlCj4gKwkJaGRtaV93cml0ZWIo aGRtaSwgMCwgSERNSV9BVURfQ1RTMyk7Cj4gIAloZG1pX3dyaXRlYihoZG1pLCAoY3RzID4+IDgp ICYgMHhmZiwgSERNSV9BVURfQ1RTMik7Cj4gIAloZG1pX3dyaXRlYihoZG1pLCBjdHMgJiAweGZm LCBIRE1JX0FVRF9DVFMxKTsKPiAgCj4gQEAgLTUwOCwyNCArNTE0LDMyIEBAIHN0YXRpYyB2b2lk IGhkbWlfc2V0X2Nsa19yZWdlbmVyYXRvcihzdHJ1Y3QgZHdfaGRtaSAqaGRtaSwKPiAgewo+ICAJ dW5zaWduZWQgbG9uZyBmdGRtcyA9IHBpeGVsX2NsazsKPiAgCXVuc2lnbmVkIGludCBuLCBjdHM7 Cj4gKwl1OCBjb25maWczOwo+ICAJdTY0IHRtcDsKPiAgCj4gIAluID0gaGRtaV9jb21wdXRlX24o c2FtcGxlX3JhdGUsIHBpeGVsX2Nsayk7Cj4gIAo+IC0JLyoKPiAtCSAqIENvbXB1dGUgdGhlIENU UyB2YWx1ZSBmcm9tIHRoZSBOIHZhbHVlLiAgTm90ZSB0aGF0IENUUyBhbmQgTgo+IC0JICogY2Fu IGJlIHVwIHRvIDIwIGJpdHMgaW4gdG90YWwsIHNvIHdlIG5lZWQgNjQtYml0IG1hdGguICBBbHNv Cj4gLQkgKiBub3RlIHRoYXQgb3VyIFRETVMgY2xvY2sgaXMgbm90IGZ1bGx5IGFjY3VyYXRlOyBp dCBpcyBhY2N1cmF0ZQo+IC0JICogdG8ga0h6LiAgVGhpcyBjYW4gaW50cm9kdWNlIGFuIHVubmVj ZXNzYXJ5IHJlbWFpbmRlciBpbiB0aGUKPiAtCSAqIGNhbGN1bGF0aW9uIGJlbG93LCBzbyB3ZSBk b24ndCB0cnkgdG8gd2FybiBhYm91dCB0aGF0Lgo+IC0JICovCj4gLQl0bXAgPSAodTY0KWZ0ZG1z ICogbjsKPiAtCWRvX2Rpdih0bXAsIDEyOCAqIHNhbXBsZV9yYXRlKTsKPiAtCWN0cyA9IHRtcDsK PiArCWNvbmZpZzMgPSBoZG1pX3JlYWRiKGhkbWksIEhETUlfQ09ORklHM19JRCk7Cj4gIAo+IC0J ZGV2X2RiZyhoZG1pLT5kZXYsICIlczogZnM9JXVIeiBmdGRtcz0lbHUuJTAzbHVNSHogTj0lZCBj dHM9JWRcbiIsCj4gLQkJX19mdW5jX18sIHNhbXBsZV9yYXRlLCBmdGRtcyAvIDEwMDAwMDAsIChm dGRtcyAvIDEwMDApICUgMTAwMCwKPiAtCQluLCBjdHMpOwo+ICsJLyogT25seSBjb21wdXRlIENU UyB3aGVuIHVzaW5nIGludGVybmFsIEFIQiBhdWRpbyAqLwo+ICsJaWYgKGNvbmZpZzMgJiBIRE1J X0NPTkZJRzNfQUhCQVVERE1BKSB7Cj4gKwkJLyoKPiArCQkgKiBDb21wdXRlIHRoZSBDVFMgdmFs dWUgZnJvbSB0aGUgTiB2YWx1ZS4gIE5vdGUgdGhhdCBDVFMgYW5kIE4KPiArCQkgKiBjYW4gYmUg dXAgdG8gMjAgYml0cyBpbiB0b3RhbCwgc28gd2UgbmVlZCA2NC1iaXQgbWF0aC4gIEFsc28KPiAr CQkgKiBub3RlIHRoYXQgb3VyIFRETVMgY2xvY2sgaXMgbm90IGZ1bGx5IGFjY3VyYXRlOyBpdCBp cwo+ICsJCSAqIGFjY3VyYXRlIHRvIGtIei4gIFRoaXMgY2FuIGludHJvZHVjZSBhbiB1bm5lY2Vz c2FyeSByZW1haW5kZXIKPiArCQkgKiBpbiB0aGUgY2FsY3VsYXRpb24gYmVsb3csIHNvIHdlIGRv bid0IHRyeSB0byB3YXJuIGFib3V0IHRoYXQuCj4gKwkJICovCj4gKwkJdG1wID0gKHU2NClmdGRt cyAqIG47Cj4gKwkJZG9fZGl2KHRtcCwgMTI4ICogc2FtcGxlX3JhdGUpOwo+ICsJCWN0cyA9IHRt cDsKPiArCj4gKwkJZGV2X2RiZyhoZG1pLT5kZXYsICIlczogZnM9JXVIeiBmdGRtcz0lbHUuJTAz bHVNSHogTj0lZCBjdHM9JWRcbiIsCj4gKwkJCV9fZnVuY19fLCBzYW1wbGVfcmF0ZSwKPiArCQkJ ZnRkbXMgLyAxMDAwMDAwLCAoZnRkbXMgLyAxMDAwKSAlIDEwMDAsCj4gKwkJCW4sIGN0cyk7Cj4g Kwl9IGVsc2UKPiArCQljdHMgPSAwOwo+ICAKPiAgCXNwaW5fbG9ja19pcnEoJmhkbWktPmF1ZGlv X2xvY2spOwo+ICAJaGRtaS0+YXVkaW9fbiA9IG47Cj4gCgpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZl bEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFp bG1hbi9saXN0aW5mby9kcmktZGV2ZWw=