Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60007C10F29 for ; Tue, 17 Mar 2020 10:39:12 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 330D420663 for ; Tue, 17 Mar 2020 10:39:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 330D420663 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.ibm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:56300 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jE9ct-00019Z-BS for qemu-devel@archiver.kernel.org; Tue, 17 Mar 2020 06:39:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47790) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jE9WL-00089g-Ut for qemu-devel@nongnu.org; Tue, 17 Mar 2020 06:32:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jE9WK-0000Zq-GV for qemu-devel@nongnu.org; Tue, 17 Mar 2020 06:32:25 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:29912) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jE9WK-0000Lk-4K for qemu-devel@nongnu.org; Tue, 17 Mar 2020 06:32:24 -0400 Received: from pps.filterd (m0098399.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 02HAWLFc025689 for ; Tue, 17 Mar 2020 06:32:23 -0400 Received: from e06smtp05.uk.ibm.com (e06smtp05.uk.ibm.com [195.75.94.101]) by mx0a-001b2d01.pphosted.com with ESMTP id 2yrue2w4wp-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 17 Mar 2020 06:32:22 -0400 Received: from localhost by e06smtp05.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 17 Mar 2020 10:32:09 -0000 Received: from b06cxnps3075.portsmouth.uk.ibm.com (9.149.109.195) by e06smtp05.uk.ibm.com (192.168.101.135) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Tue, 17 Mar 2020 10:32:05 -0000 Received: from d06av24.portsmouth.uk.ibm.com (mk.ibm.com [9.149.105.60]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 02HAW4De59113710 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 17 Mar 2020 10:32:05 GMT Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E530442045; Tue, 17 Mar 2020 10:32:04 +0000 (GMT) Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 968074203F; Tue, 17 Mar 2020 10:32:04 +0000 (GMT) Received: from localhost.localdomain (unknown [9.145.9.241]) by d06av24.portsmouth.uk.ibm.com (Postfix) with ESMTP; Tue, 17 Mar 2020 10:32:04 +0000 (GMT) Subject: Re: [PATCH v9 07/15] s390x: protvirt: Move STSI data over SIDAD To: Cornelia Huck References: <20200311132151.172389-1-frankja@linux.ibm.com> <20200311132151.172389-8-frankja@linux.ibm.com> <5936071e-36d7-b456-5106-d377eab15785@de.ibm.com> <4f99c8bc-932d-2d38-a4dd-71ef54399af6@linux.ibm.com> <20200317112850.70daa19c.cohuck@redhat.com> From: Janosch Frank Autocrypt: addr=frankja@linux.ibm.com; prefer-encrypt=mutual; keydata= mQINBFubpD4BEADX0uhkRhkj2AVn7kI4IuPY3A8xKat0ihuPDXbynUC77mNox7yvK3X5QBO6 qLqYr+qrG3buymJJRD9xkp4mqgasHdB5WR9MhXWKH08EvtvAMkEJLnqxgbqf8td3pCQ2cEpv 15mH49iKSmlTcJ+PvJpGZcq/jE42u9/0YFHhozm8GfQdb9SOI/wBSsOqcXcLTUeAvbdqSBZe zuMRBivJQQI1esD9HuADmxdE7c4AeMlap9MvxvUtWk4ZJ/1Z3swMVCGzZb2Xg/9jZpLsyQzb lDbbTlEeyBACeED7DYLZI3d0SFKeJZ1SUyMmSOcr9zeSh4S4h4w8xgDDGmeDVygBQZa1HaoL Esb8Y4avOYIgYDhgkCh0nol7XQ5i/yKLtnNThubAcxNyryw1xSstnKlxPRoxtqTsxMAiSekk 0m3WJwvwd1s878HrQNK0orWd8BzzlSswzjNfQYLF466JOjHPWFOok9pzRs+ucrs6MUwDJj0S cITWU9Rxb04XyigY4XmZ8dywaxwi2ZVTEg+MD+sPmRrTw+5F+sU83cUstuymF3w1GmyofgsU Z+/ldjToHnq21MNa1wx0lCEipCCyE/8K9B9bg9pUwy5lfx7yORP3JuAUfCYb8DVSHWBPHKNj HTOLb2g2UT65AjZEQE95U2AY9iYm5usMqaWD39pAHfhC09/7NQARAQABtCVKYW5vc2NoIEZy YW5rIDxmcmFua2phQGxpbnV4LmlibS5jb20+iQI3BBMBCAAhBQJbm6Q+AhsjBQsJCAcCBhUI CQoLAgQWAgMBAh4BAheAAAoJEONU5rjiOLn4p9gQALjkdj5euJVI2nNT3/IAxAhQSmRhPEt0 AmnCYnuTcHRWPujNr5kqgtyER9+EMQ0ZkX44JU2q7OWxTdSNSAN/5Z7qmOR9JySvDOf4d3mS bMB5zxL9d8SbnSs1uW96H9ZBTlTQnmLfsiM9TetAjSrR8nUmjGhe2YUhJLR1v1LguME+YseT eXnLzIzqqpu311/eYiiIGcmaOjPCE+vFjcXL5oLnGUE73qSYiujwhfPCCUK0850o1fUAYq5p CNBCoKT4OddZR+0itKc/cT6NwEDwdokeg0+rAhxb4Rv5oFO70lziBplEjOxu3dqgIKbHbjza EXTb+mr7VI9O4tTdqrwJo2q9zLqqOfDBi7NDvZFLzaCewhbdEpDYVu6/WxprAY94hY3F4trT rQMHJKQENtF6ZTQc9fcT5I3gAmP+OEvDE5hcTALpWm6Z6SzxO7gEYCnF+qGXqp8sJVrweMub UscyLqHoqdZC2UG4LQ1OJ97nzDpIRe0g6oJ9ZIYHKmfw5jjwH6rASTld5MFWajWdNsqK15k/ RZnHAGICKVIBOBsq26m4EsBlfCdt3b/6emuBjUXR1pyjHMz2awWzCq6/6OWs5eANZ0sdosNq dq2v0ULYTazJz2rlCXV89qRa7ukkNwdBSZNEwsD4eEMicj1LSrqWDZMAALw50L4jxaMD7lPL jJbauQINBFubpD4BEADAcUTRqXF/aY53OSH7IwIK9lFKxIm0IoFkOEh7LMfp7FGzaP7ANrZd cIzhZi38xyOkcaFY+npGEWvko7rlIAn0JpBO4x3hfhmhBD/WSY8LQIFQNNjEm3vzrMo7b9Jb JAqQxfbURY3Dql3GUzeWTG9uaJ00u+EEPlY8zcVShDltIl5PLih20e8xgTnNzx5c110lQSu0 iZv2lAE6DM+2bJQTsMSYiwKlwTuv9LI9Chnoo6+tsN55NqyMxYqJgElk3VzlTXSr3+rtSCwf tq2cinETbzxc1XuhIX6pu/aCGnNfuEkM34b7G1D6CPzDMqokNFbyoO6DQ1+fW6c5gctXg/lZ 602iEl4C4rgcr3+EpfoPUWzKeM8JXv5Kpq4YDxhvbitr8Dm8gr38+UKFZKlWLlwhQ56r/zAU v6LIsm11GmFs2/cmgD1bqBTNHHcTWwWtRTLgmnqJbVisMJuYJt4KNPqphTWsPY8SEtbufIlY HXOJ2lqUzOReTrie2u0qcSvGAbSfec9apTFl2Xko/ddqPcZMpKhBiXmY8tJzSPk3+G4tqur4 6TYAm5ouitJsgAR61Cu7s+PNuq/pTLDhK+6/Njmc94NGBcRA4qTuysEGE79vYWP2oIAU4Fv6 gqaWHZ4MEI2XTqH8wiwzPdCQPYsSE0fXWiYu7ObeErT6iLSTZGx4rQARAQABiQIfBBgBCAAJ BQJbm6Q+AhsMAAoJEONU5rjiOLn4DDEP/RuyckW65SZcPG4cMfNgWxZF8rVjeVl/9PBfy01K 8R0hajU40bWtXSMiby7j0/dMjz99jN6L+AJHJvrLz4qYRzn2Ys843W+RfXj62Zde4YNBE5SL jJweRCbMWKaJLj6499fctxTyeb9+AMLQS4yRSwHuAZLmAb5AyCW1gBcTWZb8ON5BmWnRqeGm IgC1EvCnHy++aBnHTn0m+zV89BhTLTUal35tcjUFwluBY39R2ux/HNlBO1GY3Z+WYXhBvq7q katThLjaQSmnOrMhzqYmdShP1leFTVbzXUUIYv/GbynO/YrL2gaQpaP1bEUEi8lUAfXJbEWG dnHFkciryi092E8/9j89DJg4mmZqOau7TtUxjRMlBcIliXkzSLUk+QvD4LK1kWievJse4mte FBdkWHfP4BH/+8DxapRcG1UAheSnSRQ5LiO50annOB7oXF+vgKIaie2TBfZxQNGAs3RQ+bga DchCqFm5adiSP5+OT4NjkKUeGpBe/aRyQSle/RropTgCi85pje/juYEn2P9UAgkfBJrOHvQ9 Z+2Sva8FRd61NJLkCJ4LFumRn9wQlX2icFbi8UDV3do0hXJRRYTWCxrHscMhkrFWLhYiPF4i phX7UNdOWBQ90qpHyAxHmDazdo27gEjfvsgYMdveKknEOTEb5phwxWgg7BcIDoJf9UMC Date: Tue, 17 Mar 2020 11:32:03 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <20200317112850.70daa19c.cohuck@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="51HOmlmj7U3FQCH3qI7CICnuUkGi3v4Iu" X-TM-AS-GCONF: 00 x-cbid: 20031710-0020-0000-0000-000003B5CCC4 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 20031710-0021-0000-0000-0000220E308B Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138, 18.0.645 definitions=2020-03-17_02:2020-03-12, 2020-03-17 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 impostorscore=0 phishscore=0 adultscore=0 mlxlogscore=999 suspectscore=0 clxscore=1015 lowpriorityscore=0 priorityscore=1501 spamscore=0 mlxscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2003170044 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-Received-From: 148.163.156.1 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Christian Borntraeger , qemu-s390x@nongnu.org, qemu-devel@nongnu.org, david@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --51HOmlmj7U3FQCH3qI7CICnuUkGi3v4Iu Content-Type: multipart/mixed; boundary="rt0cLuEUglSipEn4ke8Y9J1mELQZC1Rm9" --rt0cLuEUglSipEn4ke8Y9J1mELQZC1Rm9 Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 3/17/20 11:28 AM, Cornelia Huck wrote: > On Thu, 12 Mar 2020 12:20:25 +0100 > Janosch Frank wrote: >=20 >> On 3/12/20 11:42 AM, Christian Borntraeger wrote: >>> >>> >>> On 11.03.20 14:21, Janosch Frank wrote: =20 >>>> For protected guests, we need to put the STSI emulation results into= >>>> the SIDA, so SIE will write them into the guest at the next entry. >>>> >>>> Signed-off-by: Janosch Frank >>>> Reviewed-by: David Hildenbrand >>>> --- >>>> target/s390x/kvm.c | 11 +++++++++-- >>>> 1 file changed, 9 insertions(+), 2 deletions(-) >>>> >>>> diff --git a/target/s390x/kvm.c b/target/s390x/kvm.c >>>> index cdcd538b4f7fb318..8085d5030e7c6454 100644 >>>> --- a/target/s390x/kvm.c >>>> +++ b/target/s390x/kvm.c >>>> @@ -50,6 +50,7 @@ >>>> #include "exec/memattrs.h" >>>> #include "hw/s390x/s390-virtio-ccw.h" >>>> #include "hw/s390x/s390-virtio-hcall.h" >>>> +#include "hw/s390x/pv.h" >>>> =20 >>>> #ifndef DEBUG_KVM >>>> #define DEBUG_KVM 0 >>>> @@ -1800,7 +1801,9 @@ static void insert_stsi_3_2_2(S390CPU *cpu, __= u64 addr, uint8_t ar) >>>> SysIB_322 sysib; >>>> int del; >>>> =20 >>>> - if (s390_cpu_virt_mem_read(cpu, addr, ar, &sysib, sizeof(sysib)= )) { >>>> + if (s390_is_pv()) { >>>> + s390_cpu_pv_mem_read(cpu, 0, &sysib, sizeof(sysib)); =20 >>> >>> Not strictly necessary, but do we also want to do an early exit if th= e pv case fails? >>> =20 >> >> I'd rather do an early exit for the SIDA read/write ioctl itself >=20 > Early exit in what respect? Abort? Yes, abort If a write fails we most likely will not succeed on the continuation check and if a read fails we will error out somewhere in qemu anyway >=20 > If not, checking the return code here and returning looks like > something we want. >=20 --rt0cLuEUglSipEn4ke8Y9J1mELQZC1Rm9-- --51HOmlmj7U3FQCH3qI7CICnuUkGi3v4Iu Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEwGNS88vfc9+v45Yq41TmuOI4ufgFAl5wpyQACgkQ41TmuOI4 ufgykA//Y5sCg9Vp79Gq4CE2NcqzM8E1WcnxfCMeTJqBFWQ1w2gfUcmByqIkR7/Z MG8vsjs1hbzWithvZPiQ5qblqEPWhjy2K9C+NTF/8Udu2p21px2CkG4kA8SFqCGB 3gVDOl+C0ApeEDMp5dUksxeqNH4Z20Ca/a0PlGmh6s+RFChcl2kJckC1aBq/X9b8 1gWJ8Rd4morD8fuR8SRrvWUUsJgii8xa7pxiRMwK2hUO0PNPt/scOGDt7g4P0Y5V OcAtY43yOLPd3op0avtZVWKzWvGT0B52G7Nt4+hsWPdXAIRQcgDtD3wfXzLEJqp/ SYEbFp9g3xgrvx5J3pQ1wEHwTIeQ2HzudBjW0Sy1YQPqfx+dAwWYreGlQgGUmLLY 7Hz/Ky3gWSvIXHJCnSq5t0P6/qJZZsXJAWfgurL4fX0XK59Gb5pCU2VjtHp7uO0c SSIpwnDulv1T3zKYFUCce2hwOIPT7jA3b9wacDPLWRLOgW3IfnMnKI2OJ/OrcwUg H0Fdv/8MCGArWc3ei7+vfuMpR5zlyeZdkwzYdoT41DPN/SKzy5Xj65IjWhCqma0N k8OWQcZ9o6Hl2lpWee52JDaj+gkBpq53Z0ygECTUhYG4Ct598OrduUknogdDEkbr vMcH7D5X3ODEiO+64EdjHT55vTkL0bvz13WIoCVaDsdHy6KPDyI= =JeQ2 -----END PGP SIGNATURE----- --51HOmlmj7U3FQCH3qI7CICnuUkGi3v4Iu--