Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6653CC433F5 for ; Thu, 3 Mar 2022 21:19:36 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 99C5883D8B; Thu, 3 Mar 2022 22:17:40 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="GhOjBAUq"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 9E4AD83D8F; Thu, 3 Mar 2022 22:17:38 +0100 (CET) Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [IPv6:2a00:1450:4864:20::631]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 4732583D8B for ; Thu, 3 Mar 2022 22:17:33 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=alpernebiyasak@gmail.com Received: by mail-ej1-x631.google.com with SMTP id yy13so4524340ejb.2 for ; Thu, 03 Mar 2022 13:17:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:from:subject:to:cc :references:content-language:in-reply-to:content-transfer-encoding; bh=nFzvWRDLxs7mPkmhNjoAsALyS3pY4+SiTPRH4kWwwV8=; b=GhOjBAUq191Cw7b3By0MauoRTK/qtaLW2vk4jokaC8SvjURPYaKMMcyssN9pVk8uHm DFFNjfWrh5k7I4hK78eXC/1K1zy8gCgsdTrDalkks+/T9cMGK+QPKXvZmcta7qkKWIa3 J/txK0z5slenRQbm6OlvKKIWevzUsXypFY0sxbe4Tz8//C4Y32b1Nr15dnbD8Fywxm8v rlUmmrdkSiZ3311vDOUlwi/S2SAz9GXcSG7V5aAoDfDNbViK9eqShtmy47wfoe//7O0E eM8ZNluiO/gcnmwdvZ9lDz6Wv+/K9DNpaA5niwoSiJAbDjD69HidOlDbaD4mVgA/++OB yVlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:from :subject:to:cc:references:content-language:in-reply-to :content-transfer-encoding; bh=nFzvWRDLxs7mPkmhNjoAsALyS3pY4+SiTPRH4kWwwV8=; b=Q1u4gIvc9uJInUKe3gem40poxTVKJtK/iwQSjPF1w79+t7RUJgFzoW3u5gjlNBzjFX XbOFdcvlJPn+2z86u/LcEEBXv2qWUW1XkoY3t4Q41mZ489i8xiy3RdV14BCbREAAH9Hp i+4X2QlKZlOPJKt66BpHNM1ASEOHRJi+myOZ/965iH6F54nIX/tH/DZIy7AUaKzsOtVN dv9JZFrJv6R/Tg4XL7hqJgVY33O86LAMUW7T4l/B9g4SdP0FBuvglQxeIs6mRca85SX+ 7e+hPicsob2+6wxMrznFkSVciegAPZc5DemqiMGjJBQ1nIpJTcVv2grgJJAAyXIhDjlm Owsg== X-Gm-Message-State: AOAM531R1lM0O0Vmy4V55pC8aCeW/a8dw6Cho4biZ/S7YO7m+nLAyCQ0 NtcNmJWn5iY/9510qk7G5oUULZ9w16Y= X-Google-Smtp-Source: ABdhPJzCkxXWiVq2xLOKOzZOe0hPGmlpzMoLZUs5cphGJkU+6pCoAiprxmptAK/hsduU/mVZFpppwQ== X-Received: by 2002:a17:907:72c4:b0:6da:9276:e973 with SMTP id du4-20020a17090772c400b006da9276e973mr3819350ejc.663.1646342252880; Thu, 03 Mar 2022 13:17:32 -0800 (PST) Received: from [192.168.0.74] ([178.233.26.119]) by smtp.gmail.com with ESMTPSA id cc20-20020a0564021b9400b00412f2502469sm1369373edb.23.2022.03.03.13.17.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Mar 2022 13:17:32 -0800 (PST) Message-ID: Date: Fri, 4 Mar 2022 00:11:07 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 From: Alper Nebi Yasak Subject: Re: [PATCH v2 23/25] rockchip: Support building the all output files in binman To: Peter Geis , Simon Glass Cc: U-Boot Mailing List , Ivan Mikhaylov , Tom Rini , Philippe Reynes , huang lin , Jeffy Chen , Kever Yang References: <20220223230040.159317-1-sjg@chromium.org> <20220223230040.159317-24-sjg@chromium.org> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On 03/03/2022 01:16, Peter Geis wrote: > On Wed, Feb 23, 2022 at 6:04 PM Simon Glass wrote: >> diff --git a/arch/arm/dts/rockchip-u-boot.dtsi b/arch/arm/dts/rockchip-u-boot.dtsi >> index eae3ee715d..64e4466489 100644 >> --- a/arch/arm/dts/rockchip-u-boot.dtsi >> +++ b/arch/arm/dts/rockchip-u-boot.dtsi >> @@ -17,13 +17,93 @@ >> filename = "u-boot-rockchip.bin"; >> pad-byte = <0xff>; >> >> - blob { >> - filename = "idbloader.img"; >> +#ifdef CONFIG_TPL >> + mkimage { >> + args = "-n", CONFIG_SYS_SOC, "-T", "rksd"; >> + >> + u-boot-tpl { >> + }; >> + }; >> + >> + u-boot-spl { >> }; >> +#elif defined(CONFIG_SPL) /* SPL only */ >> + mkimage { >> + args = "-n", CONFIG_SYS_SOC, "-T", "rksd"; >> + >> + u-boot-spl { >> + }; >> + }; >> +#endif >> +#if defined(CONFIG_SPL_FIT) && defined(CONFIG_ARM64) >> + fit: fit { >> + description = "FIT image for U-Boot with bl31 (TF-A)"; >> + #address-cells = <1>; >> + fit,fdt-list = "of-list"; >> + fit,external-offset = ; > > You need: > offset = ; > here or the image is located at the wrong location. Thanks for confirming this. > The image produced is not functional however, because it swaps the > firmware node with the loadable-1 node. > Working image: > Configuration 0 (config_1) > Description: rk3399-pinephone-pro.dtb > Kernel: unavailable > Firmware: atf_1 > FDT: fdt_1 > Loadables: uboot > atf_2 > atf_3 > > Non working image produced from this: > Configuration 0 (config-1) > Description: rk3399-rockpro64.dtb > Kernel: unavailable > Firmware: u-boot > FDT: fdt-1 > Loadables: atf-1 > atf-2 > atf-3 And also this. I encountered the same things on rk3399-gru-kevin, mentioned them in my reply [1] to v1 but I guess Simon missed it. [1] My reply to v1 of this patch https://lore.kernel.org/u-boot/d50a7e13-7113-8c95-1861-cbc6c1000755@gmail.com/ > Also, it still doesn't support passing two separate files to mkimage > at the same time, required for proper support of rk33xx_SPI generation > and for rk35xx in general. I got v1 of this booting from SPI, but on a board that doesn't use TPL. I see in doc/boards/rockchip.rst that one would indeed pass TPL+SPL to mkimage as two different files. I don't know how they're processed or anything about the rksd/rkspi formats though. > Please see my standalone patch for what I hacked together to get that working: > http://patchwork.ozlabs.org/project/uboot/patch/20220301024826.1228290-1-pgwipeout@gmail.com/ > Note: those images are not functional either due to this issue. > > A wishlist item would be for it to produce the original idbloader.img > and u-boot.itb files, at least for now. > > Thanks! > Very Respectfully, > Peter Geis