Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7965AC83000 for ; Thu, 30 Apr 2020 14:20:23 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 483932076D for ; Thu, 30 Apr 2020 14:20:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="MEx/VKOp" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 483932076D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:58292 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jUA34-0001ej-68 for qemu-devel@archiver.kernel.org; Thu, 30 Apr 2020 10:20:22 -0400 Received: from eggs.gnu.org ([209.51.188.92]:58498) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jU9zm-0006Yy-8U for qemu-devel@nongnu.org; Thu, 30 Apr 2020 10:16:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jU9zj-0007fj-IO for qemu-devel@nongnu.org; Thu, 30 Apr 2020 10:16:57 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:53370 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jU9zi-0007b7-M6 for qemu-devel@nongnu.org; Thu, 30 Apr 2020 10:16:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1588256212; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=v6+wg0CSmrihXbrvRtquVZSF8pjNP4FF0We0Dct9c4g=; b=MEx/VKOpcwvr5Qi2No0O4R0MObVOHSZkuSQjliXJBW5c3zuVmHb13hr4aq/jMcqNBcBTZF /qsJLn4QfO2V2rdMVq6CCax8zKYqMHe2aAvLNmBXts7At6JpkD9CCt7/Nc2QRplo/gj0OZ 0aQ6nothGNc4NjR5tA0xvjkFxHjeCPM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-397-sC00jAq_Mtua2vA2h0J_ZA-1; Thu, 30 Apr 2020 10:16:51 -0400 X-MC-Unique: sC00jAq_Mtua2vA2h0J_ZA-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1A80E1B18BD0; Thu, 30 Apr 2020 14:16:50 +0000 (UTC) Received: from [10.10.116.80] (ovpn-116-80.rdu2.redhat.com [10.10.116.80]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 620B95EDEB; Thu, 30 Apr 2020 14:16:49 +0000 (UTC) Subject: Re: [PATCH 3/6] vmdk: Fix partial overwrite of zero cluster To: Kevin Wolf , qemu-block@nongnu.org References: <20200430133007.170335-1-kwolf@redhat.com> <20200430133007.170335-4-kwolf@redhat.com> From: Eric Blake Organization: Red Hat, Inc. Message-ID: Date: Thu, 30 Apr 2020 09:16:48 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200430133007.170335-4-kwolf@redhat.com> Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=207.211.31.120; envelope-from=eblake@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/04/29 23:34:52 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, mreitz@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 4/30/20 8:30 AM, Kevin Wolf wrote: > When overwriting a zero cluster, we must not perform copy-on-write from > the backing file, but from a zeroed buffer. > > Signed-off-by: Kevin Wolf > --- > block/vmdk.c | 18 ++++++++++++------ > 1 file changed, 12 insertions(+), 6 deletions(-) > Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org