From: "Sharma, Shashank" Subject: Re: [PATCH v7 04/10] drm/i915/dsb: Indexed register write function for DSB. Date: Thu, 19 Sep 2019 23:16:51 +0530 Message-ID: References: <20190918075745.17076-1-animesh.manna@intel.com> <20190918075745.17076-5-animesh.manna@intel.com> <87pnjwutpu.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id E5E066F47D for ; Thu, 19 Sep 2019 17:46:58 +0000 (UTC) In-Reply-To: <87pnjwutpu.fsf@intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula , Animesh Manna , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDkvMTkvMjAxOSAxMDowOCBQTSwgSmFuaSBOaWt1bGEgd3JvdGU6Cj4gT24gV2VkLCAxOCBT ZXAgMjAxOSwgQW5pbWVzaCBNYW5uYSA8YW5pbWVzaC5tYW5uYUBpbnRlbC5jb20+IHdyb3RlOgo+ PiBEU0IgY2FuIHByb2dyYW0gbGFyZ2Ugc2V0IG9mIGRhdGEgdGhyb3VnaCBpbmRleGVkIHJlZ2lz dGVyIHdyaXRlCj4+IChvcGNvZGUgMHg5KSBpbiBvbmUgc2hvdC4gRFNCIGZlYXR1cmUgY2FuIGJl IHVzZWQgZm9yIGJ1bGsgcmVnaXN0ZXIKPj4gcHJvZ3JhbW1pbmcgZS5nLiBnYW1tYSBsdXQgcHJv Z3JhbW1pbmcsIEhEUiBtZXRhIGRhdGEgcHJvZ3JhbW1pbmcuCj4+Cj4+IHYxOiBpbml0aWFsIHZl cnNpb24uCj4+IHYyOiBzaW1wbGlmaWVkIGNvZGUgYnkgdXNpbmcgQUxJR04oKS4gKENocmlzKQo+ PiB2MzogYXNjaWkgdGFibGUgYWRkZWQgYXMgY29kZSBjb21tZW50LiAoU2hhc2hhbmspCj4+IHY0 OiBjb3NtZXRpYyBjaGFuZ2VzIGRvbmUuIChTaGFzaGFuaykKPj4KPj4gQ2M6IFNoYXNoYW5rIFNo YXJtYSA8c2hhc2hhbmsuc2hhcm1hQGludGVsLmNvbT4KPj4gQ2M6IEltcmUgRGVhayA8aW1yZS5k ZWFrQGludGVsLmNvbT4KPj4gQ2M6IEphbmkgTmlrdWxhIDxqYW5pLm5pa3VsYUBpbnRlbC5jb20+ Cj4+IENjOiBSb2RyaWdvIFZpdmkgPHJvZHJpZ28udml2aUBpbnRlbC5jb20+Cj4+IFJldmlld2Vk LWJ5OiBTaGFzaGFuayBTaGFybWEgPHNoYXNoYW5rLnNoYXJtYUBpbnRlbC5jb20+Cj4+IFNpZ25l ZC1vZmYtYnk6IEFuaW1lc2ggTWFubmEgPGFuaW1lc2gubWFubmFAaW50ZWwuY29tPgo+PiAtLS0K Pj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX2RzYi5jIHwgNjYgKysrKysr KysrKysrKysrKysrKysrKysrCj4+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRl bF9kc2IuaCB8ICA4ICsrKwo+PiAgIDIgZmlsZXMgY2hhbmdlZCwgNzQgaW5zZXJ0aW9ucygrKQo+ Pgo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9kc2Iu YyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfZHNiLmMKPj4gaW5kZXggZjk0 Y2Q2ZGM5OGI2Li4yZDgwZTQ1MmUyODQgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2Rpc3BsYXkvaW50ZWxfZHNiLmMKPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlz cGxheS9pbnRlbF9kc2IuYwo+PiBAQCAtMTIsOCArMTIsMTAgQEAKPj4gICAvKiBEU0Igb3Bjb2Rl cy4gKi8KPj4gICAjZGVmaW5lIERTQl9PUENPREVfU0hJRlQJCTI0Cj4+ICAgI2RlZmluZSBEU0Jf T1BDT0RFX01NSU9fV1JJVEUJCTB4MQo+PiArI2RlZmluZSBEU0JfT1BDT0RFX0lOREVYRURfV1JJ VEUJMHg5Cj4+ICAgI2RlZmluZSBEU0JfQllURV9FTgkJCTB4Rgo+PiAgICNkZWZpbmUgRFNCX0JZ VEVfRU5fU0hJRlQJCTIwCj4+ICsjZGVmaW5lIERTQl9SRUdfVkFMVUVfTUFTSwkJMHhmZmZmZgo+ PiAgIAo+PiAgIHN0cnVjdCBpbnRlbF9kc2IgKgo+PiAgIGludGVsX2RzYl9nZXQoc3RydWN0IGlu dGVsX2NydGMgKmNydGMpCj4+IEBAIC04Niw2ICs4OCw3MCBAQCB2b2lkIGludGVsX2RzYl9wdXQo c3RydWN0IGludGVsX2RzYiAqZHNiKQo+PiAgIAl9Cj4+ICAgfQo+PiAgIAo+PiArdm9pZCBpbnRl bF9kc2JfaW5kZXhlZF9yZWdfd3JpdGUoc3RydWN0IGludGVsX2RzYiAqZHNiLCBpOTE1X3JlZ190 IHJlZywKPj4gKwkJCQkgdTMyIHZhbCkKPj4gK3sKPj4gKwlzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0 YyA9IGNvbnRhaW5lcl9vZihkc2IsIHR5cGVvZigqY3J0YyksIGRzYik7Cj4+ICsJc3RydWN0IGRy bV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gdG9faTkxNShjcnRjLT5iYXNlLmRldik7Cj4+ICsJ dTMyICpidWYgPSBkc2ItPmNtZF9idWY7Cj4+ICsJdTMyIHJlZ192YWw7Cj4+ICsKPj4gKwlpZiAo IWJ1Zikgewo+PiArCQlJOTE1X1dSSVRFKHJlZywgdmFsKTsKPj4gKwkJcmV0dXJuOwo+PiArCX0K Pj4gKwo+PiArCWlmIChXQVJOX09OKGRzYi0+ZnJlZV9wb3MgPj0gRFNCX0JVRl9TSVpFKSkgewo+ PiArCQlEUk1fREVCVUdfS01TKCJEU0IgYnVmZmVyIG92ZXJmbG93XG4iKTsKPj4gKwkJcmV0dXJu Owo+PiArCX0KPj4gKwo+PiArCS8qCj4+ICsJICogRm9yIGV4YW1wbGUgdGhlIGJ1ZmZlciB3aWxs IGxvb2sgbGlrZSBiZWxvdyBmb3IgMyBkd29yZHMgZm9yIGF1dG8KPj4gKwkgKiBpbmNyZW1lbnQg cmVnaXN0ZXI6Cj4+ICsJICogKy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tKwo+PiArCSAqIHwgc2l6ZSA9IDMgfCBvZmZzZXQgJnwgdmFsdWUx IHwgdmFsdWUyIHwgdmFsdWUzIHwgemVybyAgIHwKPj4gKwkgKiB8ICAgICAgICAgIHwgb3Bjb2Rl ICB8ICAgICAgICB8ICAgICAgICB8ICAgICAgICB8ICAgICAgICB8Cj4+ICsJICogKy0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tKwo+PiArCSAq ICsgICAgICAgICAgKyAgICAgICAgICsgICAgICAgICsgICAgICAgICsgICAgICAgICsgICAgICAg ICsKPj4gKwkgKiAwICAgICAgICAgIDQgICAgICAgICA4ICAgICAgICAxMiAgICAgICAxNiAgICAg ICAyMCAgICAgICAyNAo+PiArCSAqIEJ5dGUKPj4gKwkgKgo+PiArCSAqIEFzIGV2ZXJ5IGluc3Ry dWN0aW9uIGlzIDggYnl0ZSBhbGlnbmVkIHRoZSBpbmRleCBvZiBkc2IgaW5zdHJ1Y3Rpb24KPj4g KwkgKiB3aWxsIHN0YXJ0IGFsd2F5cyBmcm9tIGV2ZW4gbnVtYmVyIHdoaWxlIGRlYWxpbmcgd2l0 aCB1MzIgYXJyYXkuIElmCj4+ICsJICogd2UgYXJlIHdyaXRpbmcgb2RkIG5vIG9mIGR3b3Jkcywg WmVyb3Mgd2lsbCBiZSBhZGRlZCBpbiB0aGUgZW5kIGZvcgo+PiArCSAqIHBhZGRpbmcuCj4+ICsJ ICovCj4+ICsJcmVnX3ZhbCA9IGJ1Zltkc2ItPmluc19zdGFydF9vZmZzZXQgKyAxXSAmIERTQl9S RUdfVkFMVUVfTUFTSzsKPiBkc2ItPmluc19zdGFydF9vZmZzZXQgaXMgbmV2ZXIgcmVzZXQgYW55 d2hlcmUuCj4KPiBJbWFnaW5lIHlvdSBkbzoKPgo+IGludGVsX2RzYl9pbmRleGVkX3JlZ193cml0 ZShkc2IsIEZPTywgMCk7Cj4gaW50ZWxfZHNiX2luZGV4ZWRfcmVnX3dyaXRlKGRzYiwgRk9PLCAw KTsKPiBpbnRlbF9kc2JfcmVnX3dyaXRlKGRzYiwgQkFSLCAwKTsKPiBpbnRlbF9kc2JfaW5kZXhl ZF9yZWdfd3JpdGUoZHNiLCBGT08sIDApOwo+Cj4gVGhlIGxhc3Qgb25lIHdpbGwgc2NyZXcgdXAg dGhlIHByZXZpb3VzIGluZGV4ZWQgd3JpdGVzLgo+Cj4gQlIsCj4gSmFuaS4KPgo+Cj4+ICsJaWYg KHJlZ192YWwgIT0gaTkxNV9tbWlvX3JlZ19vZmZzZXQocmVnKSkgewo+PiArCQkvKiBFdmVyeSBp bnN0cnVjdGlvbiBzaG91bGQgYmUgOCBieXRlIGFsaWduZWQuICovCj4+ICsJCWRzYi0+ZnJlZV9w b3MgPSBBTElHTihkc2ItPmZyZWVfcG9zLCAyKTsKPj4gKwo+PiArCQlkc2ItPmluc19zdGFydF9v ZmZzZXQgPSBkc2ItPmZyZWVfcG9zOwo+PiArCgpOb3Qgc3VyZSBpZiBJIGdvdCB5b3VyIHBvaW50 IGNvcnJlY3RseSwgYnV0IGhlcmUgaXMgdGhlIGluc19zdGFydF9vZmZzZXQgCmdldHRpbmcgcmVz ZXQsIHdpdGggdGhlIG5ldyBmcmVlX3BvcyBhbGlnbmVkIHdpdGggMgoKLSBTaGFzaGFuawoKPj4g KwkJLyogVXBkYXRlIHRoZSBzaXplLiAqLwo+PiArCQlidWZbZHNiLT5mcmVlX3BvcysrXSA9IDE7 Cj4+ICsKPj4gKwkJLyogVXBkYXRlIHRoZSBvcGNvZGUgYW5kIHJlZy4gKi8KPj4gKwkJYnVmW2Rz Yi0+ZnJlZV9wb3MrK10gPSAoRFNCX09QQ09ERV9JTkRFWEVEX1dSSVRFICA8PAo+PiArCQkJCQlE U0JfT1BDT0RFX1NISUZUKSB8Cj4+ICsJCQkJCWk5MTVfbW1pb19yZWdfb2Zmc2V0KHJlZyk7Cj4+ ICsKPj4gKwkJLyogVXBkYXRlIHRoZSB2YWx1ZS4gKi8KPj4gKwkJYnVmW2RzYi0+ZnJlZV9wb3Mr K10gPSB2YWw7Cj4+ICsJfSBlbHNlIHsKPj4gKwkJLyogVXBkYXRlIHRoZSBuZXcgdmFsdWUuICov Cj4+ICsJCWJ1Zltkc2ItPmZyZWVfcG9zKytdID0gdmFsOwo+PiArCj4+ICsJCS8qIFVwZGF0ZSB0 aGUgc2l6ZS4gKi8KPj4gKwkJYnVmW2RzYi0+aW5zX3N0YXJ0X29mZnNldF0rKzsKPj4gKwl9Cj4+ ICsKPj4gKwkvKiBpZiBudW1iZXIgb2YgZGF0YSB3b3JkcyBpcyBvZGQsIHRoZW4gdGhlIGxhc3Qg ZHdvcmQgc2hvdWxkIGJlIDAuKi8KPj4gKwlpZiAoZHNiLT5mcmVlX3BvcyAmIDB4MSkKPj4gKwkJ YnVmW2RzYi0+ZnJlZV9wb3NdID0gMDsKPj4gK30KPj4gKwo+PiAgIHZvaWQgaW50ZWxfZHNiX3Jl Z193cml0ZShzdHJ1Y3QgaW50ZWxfZHNiICpkc2IsIGk5MTVfcmVnX3QgcmVnLCB1MzIgdmFsKQo+ PiAgIHsKPj4gICAJc3RydWN0IGludGVsX2NydGMgKmNydGMgPSBjb250YWluZXJfb2YoZHNiLCB0 eXBlb2YoKmNydGMpLCBkc2IpOwo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUv ZGlzcGxheS9pbnRlbF9kc2IuaCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxf ZHNiLmgKPj4gaW5kZXggMDY4NmQ2N2IzNGQ1Li5kNmNlZDQ0MjI4MTQgMTAwNjQ0Cj4+IC0tLSBh L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfZHNiLmgKPj4gKysrIGIvZHJpdmVy cy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9kc2IuaAo+PiBAQCAtMzAsMTEgKzMwLDE5IEBA IHN0cnVjdCBpbnRlbF9kc2Igewo+PiAgIAkgKiBhbmQgaGVscCBpbiBjYWxjdWxhdGluZyB0YWls IG9mIGNvbW1hbmQgYnVmZmVyLgo+PiAgIAkgKi8KPj4gICAJaW50IGZyZWVfcG9zOwo+PiArCj4+ ICsJLyoKPj4gKwkgKiBpbnNfc3RhcnRfb2Zmc2V0IHdpbGwgaGVscCB0byBzdG9yZSBzdGFydCBh ZGRyZXNzCj4+ICsJICogb2YgdGhlIGRzYiBpbnN0dWN0aW9uIG9mIGF1dG8taW5jcmVtZW50IHJl Z2lzdGVyLgo+PiArCSAqLwo+PiArCXUzMiBpbnNfc3RhcnRfb2Zmc2V0Owo+PiAgIH07Cj4+ICAg Cj4+ICAgc3RydWN0IGludGVsX2RzYiAqCj4+ICAgaW50ZWxfZHNiX2dldChzdHJ1Y3QgaW50ZWxf Y3J0YyAqY3J0Yyk7Cj4+ICAgdm9pZCBpbnRlbF9kc2JfcHV0KHN0cnVjdCBpbnRlbF9kc2IgKmRz Yik7Cj4+ICAgdm9pZCBpbnRlbF9kc2JfcmVnX3dyaXRlKHN0cnVjdCBpbnRlbF9kc2IgKmRzYiwg aTkxNV9yZWdfdCByZWcsIHUzMiB2YWwpOwo+PiArdm9pZCBpbnRlbF9kc2JfaW5kZXhlZF9yZWdf d3JpdGUoc3RydWN0IGludGVsX2RzYiAqZHNiLCBpOTE1X3JlZ190IHJlZywKPj4gKwkJCQkgdTMy IHZhbCk7Cj4+ICAgCj4+ICAgI2VuZGlmCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZy ZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2ludGVsLWdmeA==