Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2037CEB64D7 for ; Fri, 30 Jun 2023 07:14:26 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 0D3F786638; Fri, 30 Jun 2023 09:14:24 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=oss.nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="IidxfkYd"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id E0CB0866A8; Fri, 30 Jun 2023 09:14:19 +0200 (CEST) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20615.outbound.protection.outlook.com [IPv6:2a01:111:f400:7d00::615]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 0731A86638 for ; Fri, 30 Jun 2023 09:14:17 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=oss.nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=peng.fan@oss.nxp.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PX88VdpCrBAdo9/kEjmiomaCoxs8oRL10FYjKjtOUwRXa+NgJLwyIDm8gjCq9LE+hj/wl95NHx6qnHla7Gb0URS+vScKsjf8NQ3oWjUQqEXO01YUJlwHT4ZCQ+StewZ/Og0TjtxfrvLzR13bDUNw0QcPAhNmXhXvLb2ILjvjLVLYDuRGEJxQ9FUFAcfgCYQvoHWIwNcsMqomgSKkYPCsc1FYd3equBe6J8OCtW/6MkmlxYsBHO6WPQZirPxD9U1qSHUnfWvA/FZ6FXFqdO2vwB6Mn6sQDAHDZjv8kgZqIG1xpclzbToxm8Vs5ZqUhtSb0wJ09c+kLhWSdP7Lxs5wgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kK6JBW+VKC/GoIM2HXEFSSDyCPakRHQnwQJW/DButqI=; b=XbXBhYLsr+EzyB5/Yb4ZOxxEEjEYfl/awJNkY0KvAROoJPBSVYGEiAGHD389jvsm7JH2rzlbm67ypyGfaEtl/io6U1vA1GRRdB8mNOSY9/N+BQ9Zlo3SHmV6DCydMXngBzDYSek1j4+qQ0OxVI2cgPrxJj9cKUuVXX2bBTARSe1MZfy6cMnhVce/HA7NemtPDwELpGQqLFVb+17tTEUpoU1DSLTJf6iwe6z7Q0Mjw4xo0/OFFAKqGkLGsA5liPz65iEkhRVoG1lIfmc86Bvdiyx5I3lWs8sVPfpXzkZ/ZIHOf/9GLmYdMVU3eP4LcC3k4xZnrJnKzdoG9l6znBczSg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kK6JBW+VKC/GoIM2HXEFSSDyCPakRHQnwQJW/DButqI=; b=IidxfkYdatyLES1GNO+D7U+HmqyJnnFtQe01BR48Oz8EH4ajXEtdxjgh0mUASd2Jf/6TulWR1ARRvWtbM9ttV7yq4K1/Orf7xSkOEdqPQNqL76NWD+LUXfNYnTeuByohxXQJYE6+S7mlZzDo0TRxnmsNcWAZ7pq3xmacau8Uvig= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) by AS5PR04MB10043.eurprd04.prod.outlook.com (2603:10a6:20b:67f::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.19; Fri, 30 Jun 2023 07:14:15 +0000 Received: from DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::efff:43d6:6f46:eea]) by DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::efff:43d6:6f46:eea%7]) with mapi id 15.20.6521.026; Fri, 30 Jun 2023 07:14:15 +0000 Message-ID: Date: Fri, 30 Jun 2023 15:14:04 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH] ARM: imx: romapi: Fix signed integer bitwise ops misuse To: Marek Vasut , u-boot@lists.denx.de Cc: trini@konsulko.com, "NXP i.MX U-Boot Team" , Fabio Estevam , Heiko Schocher , Heinrich Schuchardt , Rasmus Villemoes , Simon Glass , Stefano Babic , Ye Li References: <20230625103452.5742-1-marex@denx.de> From: Peng Fan In-Reply-To: <20230625103452.5742-1-marex@denx.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SI2PR06CA0016.apcprd06.prod.outlook.com (2603:1096:4:186::22) To DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR04MB9417:EE_|AS5PR04MB10043:EE_ X-MS-Office365-Filtering-Correlation-Id: c0af1a38-441e-4892-414b-08db79399c37 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: u6E2G1+tpeL/DgivEt9zRRZqGisOAylJVdpcGmClRZcWjdtY2o+OsxbpibXAXuWDzQRRxu1uIheYYvEi9ZjS28RtOpajfdOWTG5RHXkdN3oY7EIs9foUDoQ+MeF8skJY8BFKlfUqOC021x06hqWKZgp5SEglzX9EEeN0E7bEU+4dzfVRQlrf0T6xceIt5OwW2ZPsBIvZyHEX1bwAi+ax/+3hq7tBltwBj/aZFBTbY0vkWcFtmtGpIKnl0kNBuG3DGivJDKPtAYtT48zK82egtOihbwibuU6tiCAszhcmPZQPi0NUMc1z2hJe491AiA8N1SGqjkyhfvafSUBiwYPSPLGsG1j9AubTxRIwetd9ph8rEbKY0F7x/3GUD/RwAB89oJMZdBEpYqea36ttFhW8UQsk/a+wXiP7r+9TgmjDfCvWyfFSd8eZPKPtVmoIiNcmHrJtNT87NNVT/zebmj8WYUSYx7MTMcd8nB78GbT3445ZAvdun/9L3YP62bKEVkWtNAfqLx61uo7hUZOfokPOURrkLTI9jEdBN7qE0kIfI1odSPR/jPSfLh7eFGFKh+JC/oXzDOUUl/7liwT8M4Fq9/pk1akxti/mi4afAyKGIFv6nbK6IfMvMHmyV6GdXkdp9/XjLwS6rcffTm+7GoTyVQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DU0PR04MB9417.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(346002)(39860400002)(136003)(396003)(376002)(366004)(451199021)(44832011)(31686004)(66946007)(558084003)(66556008)(66476007)(4326008)(478600001)(316002)(5660300002)(8676002)(8936002)(2906002)(41300700001)(54906003)(86362001)(31696002)(6486002)(53546011)(6512007)(6506007)(26005)(186003)(38100700002)(6666004)(2616005)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SUxDUXhaNFkwa3ZMNnlzODR3Z3Z3TVRnK1BNVUdvL0VqZWNNR1R2T202bHZK?= =?utf-8?B?QlpqZS9zZVZvNWhLRXFhTlhEaEtaTUJsUFd5dVdKY01CNlB0S2NBSi9HZnBX?= =?utf-8?B?cG5OQmErSko5cm9LVTk3ZmYrZ2hEc2hTa292S2ZhZjdFQ0NWa3g3K2owSitn?= =?utf-8?B?YVkwTUsrSnBMMlJDYzJCTENzVkhXTVdUWW9GTlMxTzI3SG1GNVAzZkdBN3ox?= =?utf-8?B?THlQbDA1NVBLZGpJRm51dFQ4N0lGZmNkeXJIM2xTeDBPMHdOa3ZkQkRiZ0x0?= =?utf-8?B?M0pmam90N0xRQlVnSlpmRFRUM3VRam5uNXlRNXBIaWxyTzlHODJINzZ4VTI3?= =?utf-8?B?TFA1QWExWmtwVGdnSzNQN0F2RFZycXRET0llc1NBR08wekVJWTdNY1VNYlp3?= =?utf-8?B?RWc2V1FtM3RsOFd4YWtacHpnOXU3VDE4Sm1sSVRJSDdIMHhLdVBmTjBnT1l1?= =?utf-8?B?b2pwajVGOTFEa2QwVmo2SDZwMGJPVTlCbVN4MXRuUU1pSlBoVldSOEZlQW5n?= =?utf-8?B?Q1QxMzhxZ0dxM1RVWmhVbmVZOUdCdE9CbVVJZWh5OWRwV3VHZTdqTVFqN2ZW?= =?utf-8?B?VkM0a0tzVndOUTM0VGNaNDRGdVZQQnAzQjFLYmVKV0ExMTJjdXVjSTQyV3pP?= =?utf-8?B?a1cwdWRoUlkyOVgvSkh2KzdTQVFCeEptbTJUUTRpMVNmV1JPQ2g2YmFRREUy?= =?utf-8?B?ZDVUZ2dHem5YSk1oZUpTR1RFRXp3WHFzVEp3SVh5dm1KZnhPL0ZtejZ2bVdw?= =?utf-8?B?OXRJM1VGOC9vUTgrRGlvY1ExcjVVSHFTVFRWMGVnUFFFVFJxRjFwSWNIWE1U?= =?utf-8?B?MzY0cEROcDdaTUh2d0orakhLMkN0Q2dzQlN2L21Ia21ka3Q5S20zTWkvVW10?= =?utf-8?B?VC9ZNHQ5dy8wcUV1cUxMMm0wTGxMQ3VtZTNUYzFiYWdUd3lYQ3NYY0dEWFdK?= =?utf-8?B?NlZWY0NHOEFnRjJMR0NwNzBudmFFNEtYVGlGdzNMTHBnR0I3Q0o0VGhTcDND?= =?utf-8?B?ejFqOE51S0xTd3FxRkFKdms5SlV3b1JsOXNJRnd2eU96eWdVNERtTWxuazkz?= =?utf-8?B?UjVLbDNZdm8wYndKaGI0MjNJUmZmYmNYcGpXQUM5Q2REWmFrOWlKeE1Xa1k5?= =?utf-8?B?eDY3ekRZcW1kSnExWm1ob2F4Q3R5dXZHL0p5MXY2bzJJUWZRNndlYWxnRXJH?= =?utf-8?B?N21aOHdQa1owNjJ1Q0ZwVWpyYWhieGJDcVFBbnhXZm04SEZpRzZjQy9kek85?= =?utf-8?B?STg1a0JPZFphRHdTd1Y3azQ0QlpIZjdyQWNXVk02ZDhWdjE0SjZvSENONDdx?= =?utf-8?B?aHR6ZHZ2blpmeGhpRHY5V3ZzVGJJaGVtMlJ4RUN6NGdtUjVJQjQxNHh3bG0v?= =?utf-8?B?ZEdjT0l1b1JZU3RyMHVDcjJQUGhTSi9nT0lEOVlYbFdmNC9od0pmQkF0ZUZZ?= =?utf-8?B?K0RmazlKbktHbk1wRXBGTnA3eFp6Z1pDUVVzL0xubHE2QVVtdUNWK0RINnBT?= =?utf-8?B?Z0dXZW0yQzMzVU05Wk9KdW9xamhYTWlRVUI0S1Z5WHdHTC8vaENLQzVmTUhM?= =?utf-8?B?akJEQkR4VFFDdlpBNHQ1eUtZTWJiZGtCa0I1ZGRrOWV2aSs3OXB0bTFrWlZX?= =?utf-8?B?UzhndUJBV3VxUFFzczBoWEhGay9iYmJiekQ2aUx1b0l3dUN4YkMrcWxEdmRL?= =?utf-8?B?djRjRklZc3NQbVZHNU1pRG83eDgxRDZNTGg2UkpRV1Y0UHFWaW53Q2xaR2Ur?= =?utf-8?B?dlZrUkpHQWZrQ095R0pycjhDRFlONE5TM1dsSnBZK2p6OWNWdG9IbElyek1H?= =?utf-8?B?bFJzdG03TU4vdVBWeTVkb0p6NmRIeWF2aXJBUm5NRGZBNXYybHNjalRBRXB2?= =?utf-8?B?RWZGWDJOZ2FOaWd6SjBsaDA5SDRkSTlndGxsdkhEN29haEZ5OU1aYlRYR2lB?= =?utf-8?B?cndXa3hlOWo0TlpYNDJzRDREZlN6c0Q3NHRQVXRFdG9VQkJNbmtOQ1ZmWi9j?= =?utf-8?B?QlgwMU96ZWxzU0JOaWkyeW5XRkg1WVkrUFppT0k1dWNNQjZtWU95dWwrMGlZ?= =?utf-8?B?c1ZUNE1JaVA3bFJJUGsrK08rZGI4QlM0d2dEaXRVRHd3ZFk4aUx0MTNJN2RG?= =?utf-8?Q?IGZC6rUM/X8zldTAiRWCmEzx/?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: c0af1a38-441e-4892-414b-08db79399c37 X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jun 2023 07:14:14.9410 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: z13AFue+cOmumEYMqUXP7Nhiz7Gmvx5pCpqsh5bVHqT+kCoE3JdyHd+g20Scz2iNyGSLuqY4jQlxKdvyBOo1cg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS5PR04MB10043 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On 6/25/2023 6:34 PM, Marek Vasut wrote: > Bitwise operations on signed integers are not defined, > replace then with per-call checks. Typo: then->them > > Signed-off-by: Marek Vasut Reviewed-by: Peng Fan