Received: from 013.lax.mailroute.net (013.lax.mailroute.net [199.89.1.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 712A53E3C46 for ; Tue, 19 May 2026 21:07:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=199.89.1.16 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779224872; cv=none; b=cLW7zXqe2Ugcs6d4V9QwpP3GcJLou4RQ64AjujI27ukmvpusG004la4g1bYPrBRUb/a6W4ahd+wepjZkgCalEi+mFufokXaAEHweNAdkf/+YUWE++FpyAjuB+s7GcvD1hHJoF42X3s9CLPdAArUFweCGwDfFlVg+d9S2o5bUdy4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779224872; c=relaxed/simple; bh=c3y1RI0Ifb8ics+JlKUWQ5DENDN84udF6PlUaqcWjaM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=n2MpjBi6VcZt0yk6kpimUu6uRyfW4PMtM87fhPQjvzNUgH/jxybgK/nN0BBmPhywK50j1Nx+9TbFSDJjJH//XwhUwBd1H+fesJdGr726hd3yeiforhbHSIAGBX11J7TAHODPR/RwDF9oifhNn36cXwBz4yr8663YlzUDlxG6TyU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=acm.org; spf=pass smtp.mailfrom=acm.org; dkim=pass (2048-bit key) header.d=acm.org header.i=@acm.org header.b=O4x250/J; arc=none smtp.client-ip=199.89.1.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=acm.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=acm.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=acm.org header.i=@acm.org header.b="O4x250/J" Received: from localhost (localhost [127.0.0.1]) by 013.lax.mailroute.net (Postfix) with ESMTP id 4gKnLn5wGQzlfgS0; Tue, 19 May 2026 21:07:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=acm.org; h= content-transfer-encoding:content-type:content-type:in-reply-to :from:from:content-language:references:subject:subject :user-agent:mime-version:date:date:message-id:received:received; s=mr01; t=1779224864; x=1781816865; bh=yefsolRAAR6ovHixH9nidgEo 0SlacCFYq9g1nlTEJeA=; b=O4x250/JGeCExgmdDJqJfJqXBCCZ5PILfYIV4ov7 2P+m7VIP0NSPUs0NC/NGPqouCZgaOId/a5SF4cYtA9kjByCmf3IrHFvR4Mkm26+7 7LLBDxD/dMOp9wgfeQVNLi1Njyk0Ov1Fz7v9Xg6dyUf4MqtyhLrj0xD5tqsp/k+4 llOMAbUXpGzTU9YmB49gTuJrlqjJ5qnpAWg4kSdJ6fN7aj/elTlfa38/5wXcFmFz 4cbMVzqPOe5mqyV6yzO25JJo6bxks0+3TZ/gi4Zf4Y9X1nCXXYveD9IXMelShcV9 6cphM1pw7sd5OBHTbMovGM2UsPcUbfzmaY2Zneve+vGcEw== X-Virus-Scanned: by MailRoute Received: from 013.lax.mailroute.net ([127.0.0.1]) by localhost (013.lax [127.0.0.1]) (mroute_mailscanner, port 10029) with LMTP id dygXnzUaepjv; Tue, 19 May 2026 21:07:44 +0000 (UTC) Received: from [100.119.48.131] (unknown [104.135.180.219]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bvanassche@acm.org) by 013.lax.mailroute.net (Postfix) with ESMTPSA id 4gKnLl4pcfzlfgf6; Tue, 19 May 2026 21:07:43 +0000 (UTC) Message-ID: Date: Tue, 19 May 2026 14:07:42 -0700 Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] scsi: scsi_debug: Missing "\n" in sdev_printk() in scsi_debug_device_reset() To: "Ewan D. Milne" , linux-scsi@vger.kernel.org Cc: john.g.garry@oracle.com References: <20260519205356.1040855-1-emilne@redhat.com> Content-Language: en-US From: Bart Van Assche In-Reply-To: <20260519205356.1040855-1-emilne@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 5/19/26 1:53 PM, Ewan D. Milne wrote: > A "\n" at the end of the sdev_printk() string appears to have been > inadvertently removed. Add it back for correct log message formatting. Reviewed-by: Bart Van Assche