From: bugtrack@alsa-project.org Subject: [ALSA - driver 0001239]: forgotten __init and __exit in memory.c Date: Fri, 8 Jul 2005 11:52:54 +0200 Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Return-path: Received: from bugtrack.alsa-project.org (gate.perex.cz [82.113.61.162]) by alsa.jcu.cz (ALSA's E-mail Delivery System) with ESMTP id A3FF718A for ; Fri, 8 Jul 2005 11:52:54 +0200 (MEST) Sender: alsa-devel-admin@lists.sourceforge.net Errors-To: alsa-devel-admin@lists.sourceforge.net List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , List-Archive: To: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org A NOTE has been added to this issue. ====================================================================== ====================================================================== Reported By: Henne Assigned To: ====================================================================== Project: ALSA - driver Issue ID: 1239 Category: 1_OTHERS Reproducibility: always Severity: minor Priority: normal Status: new Distribution: Kernel Version: ====================================================================== Date Submitted: 07-07-2005 10:37 CEST Last Modified: 07-08-2005 11:52 CEST ====================================================================== Summary: forgotten __init and __exit in memory.c Description: I think that snd_memory_init() should get an __init, and snd_memory_exit() an __exit, cause that __init function isn't called again and can be removed from the memory. That doesn't save too much space, but it's cleaner and mekes more sense . The patch I added will fix it and is made for the current cvs version(memory.c 1.38). ====================================================================== ---------------------------------------------------------------------- tiwai - 07-08-05 11:52 ---------------------------------------------------------------------- __exit can't be applied since it's called from init function, too. Could you regenerate the patch? Issue History Date Modified Username Field Change ====================================================================== 07-07-05 10:37 Henne New Issue 07-07-05 10:37 Henne File Added: memory_c.diff 07-08-05 11:52 tiwai Note Added: 0005410 ====================================================================== ------------------------------------------------------- This SF.Net email is sponsored by the 'Do More With Dual!' webinar happening July 14 at 8am PDT/11am EDT. We invite you to explore the latest in dual core and dual graphics technology at this free one hour event hosted by HP, AMD, and NVIDIA. To register visit http://www.hp.com/go/dualwebinar