From: Robert Foss Subject: Re: [PATCH i-g-t rfc 01/29] lib/igt_debugfs: Prevent buffer overflow Date: Thu, 12 Jan 2017 11:30:35 -0500 Message-ID: References: <20170111204204.7727-1-robert.foss@collabora.com> <20170111204204.7727-2-robert.foss@collabora.com> <1484212439.2171.0.camel@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8F0F36EB36 for ; Thu, 12 Jan 2017 16:30:40 +0000 (UTC) In-Reply-To: <1484212439.2171.0.camel@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "Lankhorst, Maarten" , "intel-gfx@lists.freedesktop.org" , "tomeu.vizoso@collabora.com" , "gustavo.padovan@collabora.com" , "daniels@collabora.com" List-Id: intel-gfx@lists.freedesktop.org CgpPbiAyMDE3LTAxLTEyIDA0OjE0IEFNLCBMYW5raG9yc3QsIE1hYXJ0ZW4gd3JvdGU6Cj4gUm9i ZXJ0IEZvc3Mgc2NocmVlZiBvcCB3byAxMS0wMS0yMDE3IG9tIDE1OjQxIFstMDUwMF06Cj4+IGJ1 ZiBhcnJheSBtYXkgb3ZlcmZsb3cgd2l0aCB3aGVuIHdyaXRpbmcgJ1wwJyBpZgo+PiBNQVhfTElO RV9MRU4gYnl0ZXMgYXJlIHJlYWQgZHVyaW5nIHJlYWQoKS4KPiBIb3c/Cj4KPiBjaGFyIGJ1ZltN QVhfTElORV9MRU4gKyAxXTsKCkkgYWN0dWFsbHkgbWlzc2VkIHRoZSArIDEsIGJ1dCBwYXJ0cyBv ZiB0aGUgY29tbWl0IGFyZSBzdGlsbCByZWxldmFudCAKdGhvdWdoLCBhcyB0aGUgZXJybm8gYXQg bGVhc3QgaW4gdGhlb3J5IGNvdWxkIGJlICE9IEVBR0FJTi4KClNvIEknZCBsaWtlIHRvIGtlZXAg dGhlIGJlbG93IGNoZWNrLCB0byBwcmV2ZW50IGNvbXBpbGVyIHdhcm5pbmdzLgppZiAoYnl0ZXNf cmVhZCA8IDApCgpTb3VuZHMgb2s/CgoKUm9iLgo+Cj4+IFNpZ25lZC1vZmYtYnk6IFJvYmVydCBG b3NzIDxyb2JlcnQuZm9zc0Bjb2xsYWJvcmEuY29tPgo+PiAtLS0KPj4gIGxpYi9pZ3RfZGVidWdm cy5jIHwgOCArKysrKy0tLQo+PiAgMSBmaWxlIGNoYW5nZWQsIDUgaW5zZXJ0aW9ucygrKSwgMyBk ZWxldGlvbnMoLSkKPj4KPj4gZGlmZiAtLWdpdCBhL2xpYi9pZ3RfZGVidWdmcy5jIGIvbGliL2ln dF9kZWJ1Z2ZzLmMKPj4gaW5kZXggZDgyODY4N2EuLjhiOGE2MjdhIDEwMDY0NAo+PiAtLS0gYS9s aWIvaWd0X2RlYnVnZnMuYwo+PiArKysgYi9saWIvaWd0X2RlYnVnZnMuYwo+PiBAQCAtNTk0LDEz ICs1OTQsMTUgQEAgc3RhdGljIGludCByZWFkX2NyYyhpZ3RfcGlwZV9jcmNfdCAqcGlwZV9jcmMs Cj4+IGlndF9jcmNfdCAqb3V0KQo+PiAgCQlyZWFkX2xlbiA9IE1BWF9MSU5FX0xFTjsKPj4KPj4g IAlpZ3Rfc2V0X3RpbWVvdXQoNSwgIkNSQyByZWFkaW5nIik7Cj4+IC0JYnl0ZXNfcmVhZCA9IHJl YWQocGlwZV9jcmMtPmNyY19mZCwgJmJ1ZiwgcmVhZF9sZW4pOwo+PiArCWJ5dGVzX3JlYWQgPSBy ZWFkKHBpcGVfY3JjLT5jcmNfZmQsICZidWYsIHJlYWRfbGVuIC0gMSk7Cj4+ICAJaWd0X3Jlc2V0 X3RpbWVvdXQoKTsKPj4KPj4gLQlpZiAoYnl0ZXNfcmVhZCA8IDAgJiYgZXJybm8gPT0gRUFHQUlO KSB7Cj4+ICsJaWYgKGJ5dGVzX3JlYWQgPCAwICYmIGVycm5vID09IEVBR0FJTikKPj4gIAkJaWd0 X2Fzc2VydChwaXBlX2NyYy0+ZmxhZ3MgJiBPX05PTkJMT0NLKTsKPj4gKwo+PiArCWlmIChieXRl c19yZWFkIDwgMCkKPj4gIAkJYnl0ZXNfcmVhZCA9IDA7Cj4+IC0JfQo+PiArCj4+ICAJYnVmW2J5 dGVzX3JlYWRdID0gJ1wwJzsKPj4KPj4gIAlpZiAoYnl0ZXNfcmVhZCAmJiAhcGlwZV9jcmNfaW5p dF9mcm9tX3N0cmluZyhwaXBlX2NyYywgb3V0LAo+PiBidWYpKQpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVs LWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcv bWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK