Received: from stravinsky.debian.org (stravinsky.debian.org [82.195.75.108]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA03830C15B for ; Tue, 26 May 2026 15:26:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=82.195.75.108 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779809162; cv=none; b=LoBGs0x7bDwryp47kkcdNQ7m4cl8amwS63cdqEbBAvz7z4EZubqh/I2KrE51754NGtd1o5E/Cdpt415onctQJyVoAO4jbZwszplaf9pTgubbFjWztFDQRCG3+jndEL/LTz7eASo1PBG+V1MeL6JsQMx50S9hDB8DpCgKdRxW22M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779809162; c=relaxed/simple; bh=5Y8oR+KoKskA3FNVYnfA0EbDZ68H3oWIh6hZUHqJx0o=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=N6ZxfSvImRRWRdPTUMJNiecnaoIOxIDw1kD3xa8+F6IxOjxFezWutZEV6Q3SP2wqToQpaLArUaQk/ZpKLYNWQYTHwfP9uqfhJOAVxgn0MNfefZgdPgmMKQ/sVNFvwbTiB7rQPGgd2FXrNQCzndOUuYHuCSuh/cIwVS98pt2Vz9M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=debian.org; spf=pass smtp.mailfrom=debian.org; dkim=pass (2048-bit key) header.d=debian.org header.i=@debian.org header.b=Jx1lG1Ki; arc=none smtp.client-ip=82.195.75.108 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=debian.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=debian.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=debian.org header.i=@debian.org header.b="Jx1lG1Ki" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debian.org; s=smtpauto.stravinsky; h=X-Debian-User:MIME-Version:Content-Type:References: In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=9iS3sJAasiDC8zeOw7PtnPEZBgzSBjSgT17X4V1FFos=; b=Jx1lG1KiWLXQiYXfbTDmysYKjq +agzMmBczRQO0tM9Cfa7FDQkDraVtc1T+VqOx8rj8/v+lgFvTBATFbH4w5i1IapHv1rZ+Yq+Si7rv SeqRzxTBLEhT/+PM5j6T4GHSMCCzp4zJ3+EdLHTsX//sOylOh3qKmV3kMRX8GsGAIa67ymDtEIDUf 3oCzV0fl+5F/haKkDKcfxsvPjLvxe5ZOpJf+Xd6Fk4qMgh2wQn0iWpXzeqWOK4hjObYli8mZHgUpx 4j0w5j7+x5Fyrszdjcu4mrd03oG75/5IFXt8Ulk+dy6UIoZZqGQckttY+NKxtZDuLtZyLD7gkAl53 YIr1UxLA==; Received: from authenticated-user by stravinsky.debian.org with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.96) (envelope-from ) id 1wRtfE-002RUJ-1a; Tue, 26 May 2026 15:25:52 +0000 Message-ID: Subject: Re: [PATCH 5.10] Revert "s390/cio: Fix device lifecycle handling in css_alloc_subchannel()" From: Ben Hutchings To: Sasha Levin , Greg Kroah-Hartman Cc: stable , Salah Triki , Heiko Carstens , Vineeth Vijayan Date: Tue, 26 May 2026 17:25:44 +0200 In-Reply-To: <20260526140000.agent5-0001@kernel.org> References: <20260526140000.agent5-0001@kernel.org> Organization: Debian Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-0coBZp/mt3fhBitbhzYV" User-Agent: Evolution 3.56.2-9 Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Debian-User: benh --=-0coBZp/mt3fhBitbhzYV Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 2026-05-26 at 09:38 -0400, Sasha Levin wrote: > On Tue, May 26, 2026 at 11:56:02AM +0200, Ben Hutchings wrote: > > The backported commit calls put_device() on the embedded struct > > device, which is now reached if css_sch_create_locks() fails, before > > it was initialised. This effectively reverts upstream commit > > f65c75b0b9b5 for 5.10. >=20 > Queued for 5.10, thanks. I also queued matching reverts on 5.15 (of > b1d4e6fb24167) and 6.1 (of fd295a75d828c), since the same goto-err > path lands at the err: label before device_initialize() on those > branches too. Thanks. I am still working my way through various fixes needed for different stable branches. I agree with reverting for exactly those branches too. Ben. --=20 Ben Hutchings - Debian developer, member of kernel, installer and LTS teams --=-0coBZp/mt3fhBitbhzYV Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEErCspvTSmr92z9o8157/I7JWGEQkFAmoVu3gACgkQ57/I7JWG EQk2dw/+PQTuaJ+CdUCCw3txIxgmXi9AsOcS//HL+VtUfdYYOnRw3ZhOHQFXNC0i 9f5NvA7ZZxcglhnTPpKNjEqPX+CMnDhFgH+On6A5p37BrMSYdDhJhzD+WA/dwOwx JLOmW8M62kSjTrVO2iI+MGUNe4dC5pC1OQdOqnTT/VssuInDYawXuDVeTAsFK3i9 aQs+Kg4SC4wlnpkoi4a1Fa4siuFO3TqSYeMCjdYu8JVHs379lDlPtglES84EsEkm gWROBGNiP2+ohLMaKwhm64Xp9bjhi+zh/Kuxg6fb66lp6gFOH8Wd+yItSQY7qqnV tiDXgkYmb2kd3ySKJNe7XXXw0gbuIZ0P06CDEzRGEhsNYwYTnIlF2rDBn7JvMDfD XuQrLC3AqBGb19tVMCHpqGHfynk3pXpQY9Eb9KK3NR8L4m6nTtjLpWpDhmCRhgoI p9gDbNgdmx+AsQXbMBpdEIuG2cZvEptnDOyXC/Aouhch5sZ61v7QYbHzKZPpYHAO 5zyMd6+7NGA5cq37cuq98JBOV1G3DZQFA3hStTUk8THx450r9qMGd8WnzuCFSCmL MtHOZENTU6kjlFKy3XcLccFAV8fw31z8LDmk4tQpBQgH/5YaUqrcpMPNiRDxz6rx I+65X0ROpovpqIgHt1NZtnqAUEU9Yzkmz5HmQG+kw/kJWzPSYmo= =LjJw -----END PGP SIGNATURE----- --=-0coBZp/mt3fhBitbhzYV--