From: "cron2 (Code Review)" Date: Thu, 8 Jan 2026 17:27:48 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="KIfmOoqUyB4="; charset=UTF-8 Subject: [Openvpn-devel] [M] Change in openvpn[master]: openvpnserv: Fix conversion warnings in interactive.c List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: flichtenheld Cc: plaisthos , openvpn-devel --KIfmOoqUyB4= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld, plaisthos. cron2 has posted comments on this change by flichtenheld. ( http://gerrit.o= penvpn.net/c/openvpn/+/1457?usp=3Demail ) Change subject: openvpnserv: Fix conversion warnings in interactive.c ...................................................................... Patch Set 3: Code-Review-1 (3 comments) Patchset: PS3: Two comments, and I really think Heiko should have a look at these changes. File src/openvpnserv/interactive.c: http://gerrit.openvpn.net/c/openvpn/+/1457/comment/55b31c70_6a63bb5f?usp=3D= email : PS3, Line 1391: RegWStringLength(PCWSTR string) I'd suggest to name that `RegWStringSize()` - d12fk has tried to make every= thing that is a "number of bytes in memory" named "xxxsize", and everything= that is "length of glyphs in a whatever-string" a "xxxlength". So this wo= uld be a "size" function. (Also for `length` inside the function, as soon as `wcslen()` is multiplied= it's not longer a "length" in that terminology) http://gerrit.openvpn.net/c/openvpn/+/1457/comment/6dd9276d_710aa1d2?usp=3D= email : PS3, Line 1744: static LSTATUS why is that change? We have a `DWORD err` and return that? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1457?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings?usp=3Demail Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I864cd4a718886f437b72e93d0286f90fcb73592b Gerrit-Change-Number: 1457 Gerrit-PatchSet: 3 Gerrit-Owner: flichtenheld Gerrit-Reviewer: cron2 Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: flichtenheld Gerrit-Comment-Date: Thu, 08 Jan 2026 17:27:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes --KIfmOoqUyB4= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is cur= rently required from: flichtenheld, plaisthos.

Patch set 3:Code-Review -1=

V= iew Change

3 comments:

  • Patchset:

    • Patch Set #3:

      Two commen= ts, and I really think Heiko should have a look at these changes.

    • <= /ul>
    • File src/openvpnserv/inter= active.c:

      • Patch Set #3, Line 1391: RegWStringLength(PCWSTR string)

        I'd suggest to name = that `RegWStringSize()` - d12fk has tried to make everything that is a &quo= t;number of bytes in memory" named "xxxsize", and everything= that is "length of glyphs in a whatever-string" a "xxxlengt= h". So this would be a "size" function.

        (Also for `leng= th` inside the function, as soon as `wcslen()` is multiplied it's not l= onger a "length" in that terminology)

      • Patch Set #3, Line 1744: static LSTATUS

        why is that change? We have a `DWORD err` a= nd return that?

    To view, visit change 1457. To unsubs= cribe, or for help writing mail filters, visit settings.

    Gerrit-MessageType: comment
    Gerrit-Project: openvpn
    Gerrit-Branch: master
    Gerrit-Change-Id: I864cd4a718886f437b72e93d028= 6f90fcb73592b
    Gerrit-Change-Number: 1457
    Gerrit-PatchSet: 3
    Gerrit-Owner: flichtenheld <frank@...2723...= .>
    Gerrit-Reviewer: cron2 <gert@...1296...>=
    Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
    Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
    Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
    Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
    Gerrit-Comment-Date: Thu, 08 Jan 2026 17:27:48= +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    = --KIfmOoqUyB4=--