From: "plaisthos (Code Review)" Date: Mon, 9 Mar 2026 12:52:28 +0000 In-Reply-To: References: Reply-To: arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="ZsRClrz0/FA="; charset=UTF-8 Subject: [Openvpn-devel] [S] Change in openvpn[master]: Try to emphasise the transition from old ovpn-dco to new ovpn module List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: flichtenheld , openvpn-devel --ZsRClrz0/FA= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld. plaisthos has posted comments on this change by plaisthos. ( http://gerrit.= openvpn.net/c/openvpn/+/1550?usp=3Demail ) Change subject: Try to emphasise the transition from old ovpn-dco to new ov= pn module ...................................................................... Patch Set 2: (2 comments) File src/openvpn/dco.c: http://gerrit.openvpn.net/c/openvpn/+/1550/comment/d69c5c22_e41422ac?usp=3D= email : PS2, Line 381: msg(msglevel, "Interface %s exists and its not u= sing " > "its not using" -> "it's not using the" or "it doesn't use the" Done File src/openvpn/dco_linux.c: http://gerrit.openvpn.net/c/openvpn/+/1550/comment/f1eb5789_7fb2d671?usp=3D= email : PS2, Line 1244: "ovpn-backports to enable data channe= l offload."); > Replace redundant "data channel offload" with "enable it"? enable it feels a bit too short here. I feel a bit better with repeating it= here to make it a more clear. But I rewrote the sentence to make it a less= annoying. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1550?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings?usp=3Demail Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Iff9f6811fdf553f59f2afee0072d7bf90133d328 Gerrit-Change-Number: 1550 Gerrit-PatchSet: 2 Gerrit-Owner: plaisthos Gerrit-Reviewer: flichtenheld Gerrit-CC: openvpn-devel Gerrit-Attention: flichtenheld Gerrit-Comment-Date: Mon, 09 Mar 2026 12:52:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: flichtenheld --ZsRClrz0/FA= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is cur= rently required from: flichtenheld.

View = Change

2 comments:

  • File src/openvpn/dco.c:

    • Patch Set #2, Li= ne 381: msg= (msglevel, "Interface %s exists and its not using "

      =

      "its not using" -> "it's not using the"= or "it doesn't use the"

      Done

    <= /li>
  • File src/openvpn/dco_linux.c:

    • Patch S= et #2, Line 1244: = "ovpn-backports to enable data channel offload."= );

      Replace redundant "data channel offload"= with "enable it"?

      enable it feels a bit too sho= rt here. I feel a bit better with repeating it here to make it a more clear= . But I rewrote the sentence to make it a less annoying.

  • =

To view, visit change 1550. To unsubscribe, or for help writing mail fi= lters, visit set= tings.

=
Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Iff9f6811fdf553f59f2afee0072= d7bf90133d328
Gerrit-Change-Number: 1550
Gerrit-PatchSet: 2
Gerrit-Owner: plaisthos <arne-openvpn@...1711...= 27...>
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-Comment-Date: Mon, 09 Mar 2026 12:52:28= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: flichtenheld <frank@...1186...= .2641...>
= --ZsRClrz0/FA=--