Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EB774C46CD2 for ; Sun, 17 Dec 2023 00:19:32 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 1BD0C87702; Sun, 17 Dec 2023 01:19:31 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1702772371; bh=VYEH/w2aim25MuCZNT2Yqm213jy0wAyxUiwYQkQK/Uw=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=nCONsNPymFImpYRzQb4rWXT+csk8pFDaee+bNuuQYEJ2MsMkgWJKMZSbffv9UlWev KTv6uv8+ZBUOf2iAbZaWO2/1lZAL45RaD7wWWKi6iJ93V6q4MWvvhwgtidsNMKqNj3 hx2yYKzDTATfGBJjZWJkwz5v5Rzn1kvlrPX/IAxxJncUQ2jDmGIQucdrhl2Th/JWnr qEfCTvLcgJ3tUxiI3hCsbvlzyO77t8NxxYKEk2yFlQvPK6fIVgA/jZKcGZ+W7U7MaM cN8ZNgGskTconapHTneg4d2H5ZDb32RZ0P4JXx25DLxtbgrmQN+ru3RuVDG9k5mP+U bWOuTlic+Da6g== Received: from [127.0.0.1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id F24DF8753C; Sun, 17 Dec 2023 01:19:28 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1702772369; bh=VYEH/w2aim25MuCZNT2Yqm213jy0wAyxUiwYQkQK/Uw=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=YIYlxTlSu52OlnEXd77yyOnDNjpjgOZYoNJJ5p3/0/3OKma6CbuOPS1I0BIhL/eR2 RPGv8NcsxscsLRBWFjcobRRagfQl8ynzXDid5FJ6Tx4+jeYDGT7SGP/9OEJH+Ylk8s moeEklSOiRjlLUAgFGF/8yPwp7BHUcG/Tuq0jzHPmX3/mn5yM7cCTNtLUaiqrKtQSR zD9E2hleWH51JpUcJUHC7ACLzprVHyhdiUaF6UPi4XrGXmTWdwRo+GpWUmPDYQmAEV r4Q9bcCjrkOlzuODVg9zxsu8xEA8cEY3RwVGqTOh450l6k8V0nKSQN8RuAplMj1ma4 QxeAv0gZa/8qw== Message-ID: Date: Sun, 17 Dec 2023 01:19:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/1] clk: clk-gpio: add actual gated clock To: Sean Anderson , Svyatoslav Ryhel Cc: u-boot@lists.denx.de, Lukasz Majewski References: <20231216084838.19403-1-clamor95@gmail.com> <20231216084838.19403-2-clamor95@gmail.com> <17d230d0-0118-4a22-9f75-14c5b06dd915@denx.de> <56f7d33e-88dd-edeb-9a1e-d79fd057b380@gmail.com> Content-Language: en-US From: Marek Vasut In-Reply-To: <56f7d33e-88dd-edeb-9a1e-d79fd057b380@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On 12/16/23 17:56, Sean Anderson wrote: > On 12/16/23 11:52, Marek Vasut wrote: >> On 12/16/23 16:37, Sean Anderson wrote: >>> On 12/16/23 03:48, Svyatoslav Ryhel wrote: >>>> Existing gpio-gate-clock driver acts like a simple GPIO switch >>>> without any >>>> effect on gated clock. Add actual clock actions into enable/disable >>>> ops and >>>> implement get_rate op by passing gated clock if it is enabled. >>>> >>>> Signed-off-by: Svyatoslav Ryhel >>>> --- >>>>   drivers/clk/clk-gpio.c | 44 >>>> ++++++++++++++++++++++++++++++++++-------- >>>>   1 file changed, 36 insertions(+), 8 deletions(-) >>>> >>>> diff --git a/drivers/clk/clk-gpio.c b/drivers/clk/clk-gpio.c >>>> index 26d795b978..72d9747a47 100644 >>>> --- a/drivers/clk/clk-gpio.c >>>> +++ b/drivers/clk/clk-gpio.c >>>> @@ -3,19 +3,23 @@ >>>>    * Copyright (C) 2023 Marek Vasut >>>>    */ >>>> -#include >>>> -#include >>>> -#include >>>> +#include >>>>   #include >>>> +#include >>>> +#include >>>> + >>>> +#include >>>>   struct clk_gpio_priv { >>>> -    struct gpio_desc    enable; >>>> +    struct gpio_desc    enable;    /* GPIO, controlling the gate */ >>>> +    struct clk        *clk;    /* Gated clock */ >>>>   }; >>>>   static int clk_gpio_enable(struct clk *clk) >>>>   { >>>>       struct clk_gpio_priv *priv = dev_get_priv(clk->dev); >>>> +    clk_enable(priv->clk); >>>>       dm_gpio_set_value(&priv->enable, 1); >>>>       return 0; >>>> @@ -26,21 +30,45 @@ static int clk_gpio_disable(struct clk *clk) >>>>       struct clk_gpio_priv *priv = dev_get_priv(clk->dev); >>>>       dm_gpio_set_value(&priv->enable, 0); >>>> +    clk_disable(priv->clk); >>>>       return 0; >>>>   } >>>> +static ulong clk_gpio_get_rate(struct clk *clk) >>>> +{ >>>> +    struct clk_gpio_priv *priv = dev_get_priv(clk->dev); >>>> + >>>> +    return clk_get_rate(priv->clk); >>>> +} >>>> + >>>>   const struct clk_ops clk_gpio_ops = { >>>>       .enable        = clk_gpio_enable, >>>>       .disable    = clk_gpio_disable, >>>> +    .get_rate    = clk_gpio_get_rate, >>>>   }; >>>> -static int clk_gpio_probe(struct udevice *dev) >>>> +static int clk_gpio_of_to_plat(struct udevice *dev) >>>>   { >>>>       struct clk_gpio_priv *priv = dev_get_priv(dev); >>>> +    int ret; >>>> -    return gpio_request_by_name(dev, "enable-gpios", 0, >>>> -                    &priv->enable, GPIOD_IS_OUT); >>>> +    priv->clk = devm_clk_get(dev, NULL); >>>> +    if (IS_ERR(priv->clk)) { >>>> +        log_debug("%s: Could not get gated clock: %ld\n", >>>> +              __func__, PTR_ERR(priv->clk)); >>>> +        return PTR_ERR(priv->clk); >>>> +    } >>>> + >>>> +    ret = gpio_request_by_name(dev, "enable-gpios", 0, >>>> +                   &priv->enable, GPIOD_IS_OUT); >>>> +    if (ret) { >>>> +        log_debug("%s: Could not decode enable-gpios (%d)\n", >>>> +              __func__, ret); >>>> +        return ret; >>>> +    } >>>> + >>>> +    return 0; >> >> All this forwarding of clock enable/disable/get_rate for parent clock >> should already be done in clock core. If it is not, then it should be >> fixed in clock core. > > Only CCF forwards things. It's up to the driver to do it in the non-CCF > case. Shall we add dependency on CCF instead of duplicating code in drivers ?